mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

clang-analyzer-deadcode.DeadStores

Browse Source 
...introduced with dc5383e2fa "fdo#84229 - don't
set error when seeking beyond end of valid data."

Change-Id: Ic26872ce47ff27a0e1170ebc66cdf10587334192
This commit is contained in:
Stephan Bergmann
2015-10-07 15:13:59 +02:00
parent bdf9ece338
commit 1edb2a1040
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
sot/source/sdstor/stgstrms.cxx
View File

@@ -431,12 +431,13 @@ bool StgStrm::Pos2Page( sal_Int32 nBytePos )
SAL_WARN("sot", "seek to index " << nIdx << SAL_WARN("sot", "seek to index " << nIdx <<
" beyond page cache size " << m_aPagesCache.size()); " beyond page cache size " << m_aPagesCache.size());
// fdo#84229 - handle seek to end and back as eg. XclImpStream expects // fdo#84229 - handle seek to end and back as eg. XclImpStream expects
nIdx = m_aPagesCache.size();
nPage = STG_EOF; nPage = STG_EOF;
nOffset = 0; nOffset = 0;
// Intriguingly in the past we didn't reset nPos to match the real // Intriguingly in the past we didn't reset nPos to match the real
// length of the stream thus: nPos = nPageSize * nIdx; so retain // length of the stream thus:
// this behavior for now. // nIdx = m_aPagesCache.size();
// nPos = nPageSize * nIdx;
// so retain this behavior for now.
return false; return false;
} }