Improved loplugin:stringconstant (now that GCC 7 supports it): starmath

Change-Id: I12c7978be638fb875be1b183c70a8eb08bedf778
Reviewed-on: https://gerrit.libreoffice.org/76645
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

starmath/source/AccessibleSmElement.cxx

@@ -107,7 +107,7 @@ void AccessibleSmElement::disposing()
 
 OUString AccessibleSmElement::getImplementationName()
 {
-    return OUString("com.sun.star.comp.toolkit.AccessibleSmElement");
+    return "com.sun.star.comp.toolkit.AccessibleSmElement";
 }
 
 sal_Bool AccessibleSmElement::supportsService(const OUString& rServiceName)
@@ -274,7 +274,7 @@ OUString AccessibleSmElement::getAccessibleActionDescription(sal_Int32 nIndex)
 
     testAction(nIndex);
 
-    return OUString("press");
+    return "press";
 }
 
 uno::Reference<XAccessibleKeyBinding>

starmath/source/AccessibleSmElementsControl.cxx

@@ -156,7 +156,7 @@ sal_Int32 AccessibleSmElementsControl::getBackground()
 // XServiceInfo
 OUString AccessibleSmElementsControl::getImplementationName()
 {
-    return OUString("com.sun.star.comp.toolkit.AccessibleSmElementsControl");
+    return "com.sun.star.comp.toolkit.AccessibleSmElementsControl";
 }
 
 sal_Bool AccessibleSmElementsControl::supportsService(const OUString& rServiceName)

starmath/source/accessibility.cxx

@@ -720,7 +720,7 @@ sal_Bool SAL_CALL SmGraphicAccessible::copyText(
 
 OUString SAL_CALL SmGraphicAccessible::getImplementationName()
 {
-    return OUString("SmGraphicAccessible");
+    return "SmGraphicAccessible";
 }
 
 sal_Bool SAL_CALL SmGraphicAccessible::supportsService(
@@ -1763,7 +1763,7 @@ void SAL_CALL SmEditAccessible::removeAccessibleEventListener( const uno::Refere
 
 OUString SAL_CALL SmEditAccessible::getImplementationName()
 {
-    return OUString("SmEditAccessible");
+    return "SmEditAccessible";
 }
 
 sal_Bool SAL_CALL SmEditAccessible::supportsService(

starmath/source/action.cxx

@@ -47,7 +47,7 @@ void SmFormatAction::Repeat(SfxRepeatTarget& rDocSh)
 
 OUString SmFormatAction::GetComment() const
 {
-    return OUString(RID_UNDOFORMATNAME);
+    return RID_UNDOFORMATNAME;
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

starmath/source/smdetect.cxx

@@ -80,7 +80,7 @@ OUString SAL_CALL SmFilterDetect::detect( Sequence< PropertyValue >& lDescriptor
             {
                 sal_uInt8 nVersion;
                 if ( GetMathTypeVersion( aStorage.get(), nVersion ) && nVersion <=3 )
-                    return OUString("math_MathType_3x");
+                    return "math_MathType_3x";
             }
         }
     }
@@ -114,7 +114,7 @@ OUString SAL_CALL SmFilterDetect::detect( Sequence< PropertyValue >& lDescriptor
                                0 == strncmp( "<math:math> ", aBuffer, 12));
 
             if ( bIsMathType )
-                return OUString("math_MathML_XML_Math");
+                return "math_MathML_XML_Math";
         }
     }
 
@@ -124,7 +124,7 @@ OUString SAL_CALL SmFilterDetect::detect( Sequence< PropertyValue >& lDescriptor
 /* XServiceInfo */
 OUString SAL_CALL SmFilterDetect::getImplementationName()
 {
-    return OUString("com.sun.star.comp.math.FormatDetector");
+    return "com.sun.star.comp.math.FormatDetector";
 }
 
 /* XServiceInfo */

starmath/source/uiobject.cxx

@@ -104,7 +104,7 @@ std::unique_ptr<UIObject> ElementSelectorUIObject::create(vcl::Window* pWindow)
 
 OUString ElementSelectorUIObject::get_name() const
 {
-    return OUString("SmElementSelector");
+    return "SmElementSelector";
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

starmath/source/unodoc.cxx

@@ -28,7 +28,7 @@ using namespace ::com::sun::star;
 
 OUString SmDocument_getImplementationName() throw()
 {
-    return OUString( "com.sun.star.comp.Math.FormulaDocument" );
+    return "com.sun.star.comp.Math.FormulaDocument";
 }
 
 uno::Sequence< OUString > SmDocument_getSupportedServiceNames() throw()

starmath/source/unofilter.cxx

@@ -101,7 +101,7 @@ void MathTypeFilter::setTargetDocument(const uno::Reference< lang::XComponent >&
 
 OUString MathTypeFilter::getImplementationName()
 {
-    return OUString("com.sun.star.comp.Math.MathTypeFilter");
+    return "com.sun.star.comp.Math.MathTypeFilter";
 }
 
 sal_Bool MathTypeFilter::supportsService(const OUString& rServiceName)

starmath/source/unomodel.cxx

@@ -387,7 +387,7 @@ static sal_Int16 lcl_AnyToINT16(const uno::Any& rAny)
 
 OUString SmModel::getImplementationName()
 {
-    return OUString("com.sun.star.comp.Math.FormulaDocument");
+    return "com.sun.star.comp.Math.FormulaDocument";
 }
 
 sal_Bool SmModel::supportsService(const OUString& rServiceName)