WTF "WTF 255 return value?"

0e68bac852 "set up python unit test
infrastructure" had introduced unotest/source/python/org/libreoffice/unotest.py
with the comment and commented-out code.  It claims it has extraced "boostraping
code from convwatch.py to unotest.py", but I can't find a trace in the git
history of a prior incarnation of that comment and commented-out code.  It is
unclear what problem exactly the commenting-out of the check was supposed to
address.  So put the check in place and see what, if anything, breaks.

(The commented-out return appears to be truly unnecessary, and has been removed
completely.)

Change-Id: Ie2108d70fbe076cd0832bd23bfb29fc60eedffef
Reviewed-on: https://gerrit.libreoffice.org/80029
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2019-10-02 13:58:09 +02:00
parent 094d8dd461
commit 2c1a55641b

View File

@@ -142,10 +142,8 @@ class OfficeConnection(object):
self.xContext = None
self.socket = None
self.soffice = None
# WTF 255 return value?
# if ret != 0:
# raise Exception("Exit status indicates failure: " + str(ret))
# return ret
if ret != 0:
raise Exception("Exit status indicates failure: " + str(ret))
def getContext(self):
return self.xContext