mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

formula: fix crash in FormulaDlg_Impl::UpdateSelection

Browse Source 
m_pFuncDesc can be nullptr

See https://crashreport.libreoffice.org/stats/signature/formula::FormulaDlg_Impl::UpdateSelection()

Change-Id: If8a95bef8b0a8a03ffe63041409ee7c1cf322b0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150550
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Xisco Fauli
2023-04-18 13:31:42 +02:00
committed by Caolán McNamara
parent 10fac0f7f7
commit 2d62a54d15
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
formula/source/ui/dlg/formula.cxx
View File

@@ -1456,15 +1456,23 @@ IMPL_LINK_NOARG( FormulaDlg_Impl, FormulaCursorHdl, weld::TextView&, void)
void FormulaDlg_Impl::UpdateSelection()
{
m_pHelper->setSelection( m_aFuncSel.Min(), m_aFuncSel.Max());
m_pHelper->setCurrentFormula( m_pFuncDesc->getFormula( m_aArguments ) );
if (m_pFuncDesc)
{
m_pHelper->setCurrentFormula( m_pFuncDesc->getFormula( m_aArguments ) );
m_nArgs = m_pFuncDesc->getSuppressedArgumentCount();
}
else
{
m_pHelper->setCurrentFormula("");
m_nArgs = 0;
}
m_xMEdit->set_text(m_pHelper->getCurrentFormula());
sal_Int32 PrivStart, PrivEnd;
m_pHelper->getSelection( PrivStart, PrivEnd);
m_aFuncSel.Min() = PrivStart;
m_aFuncSel.Max() = PrivEnd;
m_nArgs = m_pFuncDesc->getSuppressedArgumentCount();
OUString aFormula = m_xMEdit->get_text();
sal_Int32 nArgPos = m_aFormulaHelper.GetArgStart( aFormula, PrivStart, 0);