mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove duplicate com.sun.star.i18n.IndexEntrySupplier_ja_phonetic_* impls

Browse Source 
Ever since 95823ae83c "#95565#add new phonetic
entry for CJK index modules", "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic
(alphanumeric first)" was using the same implementation as
"com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped
by syllable)", and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic
(alphanumeric last)" was using the same implementation as
"com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last) (grouped
by syllable)".  But there appears to be no evidence that those implementation
names "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first)"
and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic  (alphanumeric last)" are
actually used anywhere (see also c9b6bf655e "Add
some tests for (Japanese) i18n::IndexEntrySupplier behavior").

And a problem with the current setup is that instantiation those two
implementation names will return implementations whose getImplementationName()
does not match those implementation names (but rather returns
"com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped
by syllable)" and "com.sun.star.i18n.IndexEntrySupplier_ja_phonetic
(alphanumeric last) (grouped by syllable)", resp.)---which is something that
would create failures with an improved CppunitTest_services.

Change-Id: I27cf4ffdb2b84195c6d96f8a7a269120f6a17714
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151144
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2023-04-27 22:19:44 +02:00
parent 21fad629e7
commit 2eb3922750
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
i18npool/util/i18npool.component
View File

@@ -120,10 +120,6 @@
constructor="i18npool_IndexEntrySupplier_asian_get_implementation">
<service name="com.sun.star.i18n.IndexEntrySupplier_asian"/>
</implementation>
<implementation name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first)"
constructor="i18npool_IndexEntrySupplier_ja_phonetic_alphanumeric_first_by_syllable_get_implementation">
<service name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first)"/>
</implementation>
<implementation name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by consonant)"
constructor="i18npool_IndexEntrySupplier_ja_phonetic_alphanumeric_first_by_consonant_get_implementation">
<service name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by consonant)"/>
@@ -132,10 +128,6 @@
constructor="i18npool_IndexEntrySupplier_ja_phonetic_alphanumeric_first_by_syllable_get_implementation">
<service name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric first) (grouped by syllable)"/>
</implementation>
<implementation name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last)"
constructor="i18npool_IndexEntrySupplier_ja_phonetic_alphanumeric_last_by_syllable_get_implementation">
<service name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last)"/>
</implementation>
<implementation name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last) (grouped by consonant)"
constructor="i18npool_IndexEntrySupplier_ja_phonetic_alphanumeric_last_by_consonant_get_implementation">
<service name="com.sun.star.i18n.IndexEntrySupplier_ja_phonetic (alphanumeric last) (grouped by consonant)"/>