tdf#147723 sw_fieldmarkhide: fix crash when copying multiple fieldmarks
The problem is the UpdateFramesForAddDeleteRedline() call in makeMark(),
this is called in a loop for multiple fieldmarks and when it's called
for the first one, of course the other ones aren't in the document yet,
so HideIterator::Next() can't find them.
But this is only needed when inserting a new fieldmark anyway, so just
disable for copying.
(regression from commit 92384a8131
)
Change-Id: Ic1b34d469a553cf7bbf2d1a99edaea900bdd7417
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133215
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
This commit is contained in:
@@ -683,8 +683,9 @@ namespace sw::mark
|
||||
// no special array for these
|
||||
break;
|
||||
}
|
||||
if (eType == IDocumentMarkAccess::MarkType::TEXT_FIELDMARK
|
||||
|| eType == IDocumentMarkAccess::MarkType::DATE_FIELDMARK)
|
||||
if (eMode == InsertMode::New
|
||||
&& (eType == IDocumentMarkAccess::MarkType::TEXT_FIELDMARK
|
||||
|| eType == IDocumentMarkAccess::MarkType::DATE_FIELDMARK))
|
||||
{
|
||||
// due to SwInsText notifications everything is visible now - tell
|
||||
// layout to hide as appropriate
|
||||
|
Reference in New Issue
Block a user