tdf#42949 Fix IWYU warnings in registry/

Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I819bb44e36bdb6ec671cf11bd779085767d82fd0 Reviewed-on: https://gerrit.libreoffice.org/67697 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-11 01:28:33 +01:00
parent d9f9a9e56d
commit 3478f4741c
15 changed files with 23 additions and 28 deletions
--- a/registry/IwyuFilter_registry.yaml
+++ b/registry/IwyuFilter_registry.yaml
@@ -0,0 +1,16 @@
+---
+assumeFilename: registry/source/registry.cxx
+blacklist:
+    registry/source/regimpl.hxx:
+    # Needed for correct linker visibility
+    - regapi.hxx
+    registry/source/reflwrit.cxx:
+    # OSL_BIGENDIAN is being checked
+    - osl/endian.h
+    # Needed for correct linker visibility
+    - registry/writer.h
+    registry/source/reflread.cxx:
+    # OSL_BIGENDIAN is being checked
+    - osl/endian.h
+    # Needed for correct linker visibility
+    - registry/typereg_reader.hxx
--- a/registry/inc/regapi.hxx
+++ b/registry/inc/regapi.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_REGISTRY_INC_REGAPI_HXX
 #define INCLUDED_REGISTRY_INC_REGAPI_HXX

-#include <stddef.h>
 #include <rtl/ustring.h>
 #include <registry/regtype.h>
 #include <registry/regdllapi.h>
--- a/registry/source/keyimpl.hxx
+++ b/registry/source/keyimpl.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_REGISTRY_SOURCE_KEYIMPL_HXX
 #define INCLUDED_REGISTRY_SOURCE_KEYIMPL_HXX

-#include <regapi.hxx>
 #include "regimpl.hxx"
 #include <rtl/ustring.hxx>

--- a/registry/source/reflcnst.hxx
+++ b/registry/source/reflcnst.hxx
@@ -20,8 +20,7 @@
 #ifndef INCLUDED_REGISTRY_SOURCE_REFLCNST_HXX
 #define INCLUDED_REGISTRY_SOURCE_REFLCNST_HXX

-#include <registry/refltype.hxx>
-#include <sal/macros.h>
+#include <registry/types.hxx>

 #include <string.h>

--- a/registry/source/reflread.cxx
+++ b/registry/source/reflread.cxx
@@ -24,7 +24,6 @@
 #include <new>
 #include <vector>

-#include <string.h>
 #include <sal/types.h>
 #include <osl/endian.h>
 #include <osl/diagnose.h>
--- a/registry/source/reflread.hxx
+++ b/registry/source/reflread.hxx
@@ -21,7 +21,6 @@
 #define INCLUDED_REGISTRY_SOURCE_REFLREAD_HXX

 #include <registry/refltype.hxx>
-#include <registry/regtype.h>
 #include <rtl/ustring.hxx>

 /// Implememetation handle
--- a/registry/source/reflwrit.cxx
+++ b/registry/source/reflwrit.cxx
@@ -22,13 +22,12 @@
 #include <memory>
 #include <algorithm>
 #include <sal/types.h>
-#include <sal/macros.h>
 #include <osl/endian.h>
-#include <rtl/alloc.h>
 #include <rtl/string.hxx>
 #include <rtl/ustring.hxx>

 #include "reflwrit.hxx"
+#include <registry/refltype.hxx>
 #include <registry/version.h>
 #include <registry/writer.h>

--- a/registry/source/reflwrit.hxx
+++ b/registry/source/reflwrit.hxx
@@ -20,10 +20,11 @@
 #ifndef INCLUDED_REGISTRY_SOURCE_REFLWRIT_HXX
 #define INCLUDED_REGISTRY_SOURCE_REFLWRIT_HXX

-#include <registry/refltype.hxx>
-#include <registry/regtype.h>
+#include <registry/types.hxx>
 #include <rtl/ustring.hxx>

+class RTConstValue;
+
 /// Implememetation handle
 typedef void* TypeWriterImpl;

--- a/registry/source/regimpl.cxx
+++ b/registry/source/regimpl.cxx
@@ -21,6 +21,7 @@
 #include "regimpl.hxx"

 #include <memory>
+#include <set>
 #include <vector>
 #include <string.h>
 #include <stdio.h>
@@ -36,13 +37,11 @@
 #include <registry/reader.hxx>
 #include <registry/refltype.hxx>
 #include <registry/types.hxx>
-#include <registry/version.h>

 #include "reflcnst.hxx"
 #include "keyimpl.hxx"

 #include <osl/thread.h>
-#include <rtl/alloc.h>
 #include <rtl/ustring.hxx>
 #include <rtl/ustrbuf.hxx>
 #include <osl/file.hxx>
--- a/registry/source/regimpl.hxx
+++ b/registry/source/regimpl.hxx
@@ -20,10 +20,10 @@
 #ifndef INCLUDED_REGISTRY_SOURCE_REGIMPL_HXX
 #define INCLUDED_REGISTRY_SOURCE_REGIMPL_HXX

-#include <set>
 #include <unordered_map>

 #include <regapi.hxx>
+#include <registry/regtype.h>
 #include <rtl/ustring.hxx>
 #include <osl/mutex.hxx>
 #include <store/store.hxx>
--- a/registry/source/registry.cxx
+++ b/registry/source/registry.cxx
@@ -18,11 +18,8 @@
 */


-#include <regapi.hxx>
 #include <registry/registry.hxx>

-#include <osl/process.h>
-
 #include "keyimpl.hxx"
 #include "regimpl.hxx"
 #include "regkey.hxx"
@@ -31,12 +28,6 @@
 #include <io.h>
 #endif

-#include <string.h>
-#if defined(UNX)
-#include <stdlib.h>
-#include <unistd.h>
-#endif
-
 extern "C" {


--- a/registry/source/regkey.cxx
+++ b/registry/source/regkey.cxx
@@ -20,8 +20,6 @@

 #include "regkey.hxx"

-#include <registry/registry.hxx>
-#include <rtl/alloc.h>
 #include <osl/diagnose.h>
 #include "regimpl.hxx"
 #include "keyimpl.hxx"
--- a/registry/tools/fileurl.cxx
+++ b/registry/tools/fileurl.cxx
@@ -20,7 +20,6 @@
 #include "fileurl.hxx"

 #include <rtl/ustring.hxx>
-#include <osl/diagnose.h>
 #include <osl/file.hxx>
 #include <osl/process.h>
 #include <osl/thread.h>
--- a/registry/tools/options.cxx
+++ b/registry/tools/options.cxx
@@ -22,7 +22,6 @@
 #include <osl/diagnose.h>

 #include <stdio.h>
-#include <string.h>

 namespace registry
 {
--- a/registry/tools/options.hxx
+++ b/registry/tools/options.hxx
@@ -23,8 +23,6 @@
 #include <string>
 #include <vector>

-#include <sal/types.h>
-
 namespace registry
 {
 namespace tools