mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Improve loplugin:sequenceloop diagnostic advice

Browse Source 
"make range var const" sounded to me like it talked about the variable declared
in the for-range-declaration, not a variable referenced in the for-range-
initializer

Change-Id: Ie777e1374ead7f37c8efb022cd87e980d2ee9810
Reviewed-on: https://gerrit.libreoffice.org/79563
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This commit is contained in:
Stephan Bergmann
2019-09-25 17:26:06 +02:00
parent b2efa7da5b
commit 3a7d479c4c
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/sequenceloop.cxx
View File

@@ -64,7 +64,8 @@ bool SequenceLoop::VisitCXXForRangeStmt(CXXForRangeStmt const* forStmt)
return true;
report(DiagnosticsEngine::Warning,
"use std::as_const, or make range var const, to avoid creating a copy of the Sequence",
("use std::as_const, or otherwise make the for-range-initializer expression const, to"
" avoid creating a copy of the Sequence"),
compat::getBeginLoc(forStmt->getRangeInit()))
<< forStmt->getSourceRange();
return true;

2
compilerplugins/clang/test/sequenceloop.cxx
View File

@@ -15,7 +15,7 @@ namespace test1
{
void foo(css::uno::Sequence<css::uno::Reference<css::uno::XInterface>>& aSeq)
{
// expected-error@+1 {{use std::as_const, or make range var const, to avoid creating a copy of the Sequence [loplugin:sequenceloop]}}
// expected-error@+1 {{use std::as_const, or otherwise make the for-range-initializer expression const, to avoid creating a copy of the Sequence [loplugin:sequenceloop]}}
for (const auto& x : aSeq)
x.get();
// no warning expected