coverity#705811 Dereference before null check

Change-Id: I275739819715f1537e80d621b19a88a6fdbab95b
2014-01-28 13:54:05 +00:00
parent d31a216b1f
commit 40a8fecb58
1 changed files with 4 additions and 7 deletions
--- a/extensions/source/propctrlr/fontdialog.cxx
+++ b/extensions/source/propctrlr/fontdialog.cxx
@@ -565,13 +565,10 @@ namespace pcr
        }

        // delete the pool
-        if (_rpPool)
-        {
-            _rpPool->ReleaseDefaults(sal_True);
-                // the "true" means delete the items, too
-            SfxItemPool::Free(_rpPool);
-            _rpPool = NULL;
-        }
+        _rpPool->ReleaseDefaults(sal_True);
+            // the "true" means delete the items, too
+        SfxItemPool::Free(_rpPool);
+        _rpPool = NULL;

        // reset the defaults ptr
        _rppDefaults = NULL;