mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cid#1557980 COPY_INSTEAD_OF_MOVE

Browse Source 
and

cid#1557869 COPY_INSTEAD_OF_MOVE
cid#1557807 COPY_INSTEAD_OF_MOVE
cid#1557804 COPY_INSTEAD_OF_MOVE
cid#1557799 COPY_INSTEAD_OF_MOVE
cid#1557781 COPY_INSTEAD_OF_MOVE
cid#1557781 COPY_INSTEAD_OF_MOVE
cid#1557766 COPY_INSTEAD_OF_MOVE
cid#1557746 COPY_INSTEAD_OF_MOVE
cid#1557737 COPY_INSTEAD_OF_MOVE

Change-Id: I1866c576f525ea697c62e9e0a96890e5fdaa780f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171795
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
This commit is contained in:
Caolán McNamara
2024-08-12 13:12:05 +01:00
parent aabb5be81a
commit 437412d79b
11 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
basic/source/sbx/sbxarray.cxx
View File

@@ -346,7 +346,7 @@ bool SbxArray::LoadData( SvStream& rStrm, sal_uInt16 /*nVer*/ )
if( pVar )
{
SbxVariableRef& rRef = GetRef( nIdx );
rRef = pVar;
rRef = std::move(pVar);
}
else
{

2
binaryurp/source/writer.cxx
View File

@@ -335,7 +335,7 @@ void Writer::sendRequest(
break;
}
sendMessage(buf);
lastType_ = t;
lastType_ = std::move(t);
lastOid_ = oid;
lastTid_ = tid;
}

2
connectivity/source/drivers/postgresql/pq_connection.cxx
View File

@@ -208,7 +208,7 @@ Reference< XPreparedStatement > Connection::prepareStatement( const OUString& sq
::rtl::ByteSequence id( 16 );
rtl_createUuid( reinterpret_cast<sal_uInt8*>(id.getArray()), nullptr, false );
m_myStatements[ id ] = Reference< XCloseable > ( stmt );
stmt->queryAdapter()->addReference( new ClosableReference( id, this ) );
stmt->queryAdapter()->addReference(new ClosableReference(std::move(id), this));
return stmt;
}

2
dbaccess/source/ui/querydesign/querycontroller.cxx
View File

@@ -634,7 +634,7 @@ void OQueryController::impl_setViewMode( ::dbtools::SQLExceptionInfo* _pErrorInf
// don't pass &aError here, this would overwrite the error which the first switchView call
// returned in this location.
if ( _pErrorInfo )
*_pErrorInfo = aError;
*_pErrorInfo = std::move(aError);
else
showError( aError );
}

2
filter/source/msfilter/escherex.cxx
View File

@@ -1754,7 +1754,7 @@ bool EscherPropertyContainer::CreateGraphicProperties(const uno::Reference<beans
}
else if (pGraphicProvider && pPicOutStrm && pShapeBoundRect) // write out embedded graphic
{
GraphicObject aGraphicObject(aGraphic);
GraphicObject aGraphicObject(std::move(aGraphic));
const sal_uInt32 nBlibId(pGraphicProvider->GetBlibID(*pPicOutStrm, aGraphicObject, nullptr, pGraphicAttr.get()));
if(nBlibId)

2
oox/source/drawingml/diagram/layoutatomvisitors.cxx
View File

@@ -104,7 +104,7 @@ void ShapeCreationVisitor::visit(LayoutNode& rAtom)
xCurrParent->addChild(pShape);
xCurrParent = pShape;
rAtom.addNodeShape(pShape);
mrDgm.getLayout()->getPresPointShapeMap()[pNewNode] = pShape;
mrDgm.getLayout()->getPresPointShapeMap()[pNewNode] = std::move(pShape);
}
}
else

2
stoc/source/proxy_factory/proxyfac.cxx
View File

@@ -319,7 +319,7 @@ Any ProxyRoot::queryAggregation( Type const & rType )
UnoInterfaceReference proxy(
// ref count initially 1:
new binuno_Proxy( this, proxy_target, oid, pTypeDescr ),
new binuno_Proxy( this, std::move(proxy_target), oid, pTypeDescr ),
SAL_NO_ACQUIRE );
uno_ExtEnvironment * uno_env =
m_factory->m_uno_env.get()->pExtEnv;

2
svx/source/customshapes/EnhancedCustomShapeFontWork.cxx
View File

@@ -1082,7 +1082,7 @@ static void FitTextOutlinesToShapeOutlines(const tools::PolyPolygon& aOutlines2d
}
// write back polygon
rPolyPoly[ i ] = aLocalPoly;
rPolyPoly[i] = std::move(aLocalPoly);
}
}
}

6
svx/source/svdraw/constructhelper.cxx
View File

@@ -145,7 +145,7 @@ void ConstructHelper::SetLineEnds(SfxItemSet& rAttr, const SdrObject& rObj, sal_
case SID_LINE_SQUARE_ARROW:
{
// connector with arrow end
rAttr.Put(XLineEndItem(SvxResId(RID_SVXSTR_ARROW), aArrow));
rAttr.Put(XLineEndItem(SvxResId(RID_SVXSTR_ARROW), std::move(aArrow)));
rAttr.Put(XLineEndWidthItem(nWidth));
}
break;
@@ -165,7 +165,7 @@ void ConstructHelper::SetLineEnds(SfxItemSet& rAttr, const SdrObject& rObj, sal_
case SID_LINE_CIRCLE_ARROW:
{
// circle start
rAttr.Put(XLineStartItem(SvxResId(RID_SVXSTR_CIRCLE), aCircle));
rAttr.Put(XLineStartItem(SvxResId(RID_SVXSTR_CIRCLE), std::move(aCircle)));
rAttr.Put(XLineStartWidthItem(nWidth));
}
break;
@@ -181,7 +181,7 @@ void ConstructHelper::SetLineEnds(SfxItemSet& rAttr, const SdrObject& rObj, sal_
case SID_LINE_SQUARE_ARROW:
{
// square start
rAttr.Put(XLineStartItem(SvxResId(RID_SVXSTR_SQUARE), aSquare));
rAttr.Put(XLineStartItem(SvxResId(RID_SVXSTR_SQUARE), std::move(aSquare)));
rAttr.Put(XLineStartWidthItem(nWidth));
}
break;

2
svx/source/unodraw/unoshtxt.cxx
View File

@@ -549,7 +549,7 @@ SvxTextForwarder* SvxTextEditSourceImpl::GetBackgroundTextForwarder()
if (mpText && bTextEditActive && mpObject->IsEmptyPresObj() && pTextObj && pTextObj->IsReallyEdited())
{
mpObject->SetEmptyPresObj( false );
static_cast< SdrTextObj* >( mpObject)->NbcSetOutlinerParaObjectForText( pOutlinerParaObject, mpText );
static_cast<SdrTextObj*>(mpObject)->NbcSetOutlinerParaObjectForText(std::move(pOutlinerParaObject), mpText);
}
}
else

2
tools/source/generic/poly.cxx
View File

@@ -1070,7 +1070,7 @@ void Polygon::Optimize( PolyOptimizeFlags nOptimizeFlags )
aNewPoly.SetSize( nNewCount );
}
*this = aNewPoly;
*this = std::move(aNewPoly);
}
nSize = mpImplPolygon->mnPoints;