mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cid#1448341: perf inefficient map iterator

Browse Source 
Change-Id: I5b5ba2b6ed370765e38b51a23175c73dc0e2c8f8
Reviewed-on: https://gerrit.libreoffice.org/75061
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
This commit is contained in:
Julien Nabet
2019-07-03 22:13:59 +02:00
parent 880b0b534c
commit 4ded63a1aa
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
javaunohelper/com/sun/star/lib/uno/helper/MultiTypeInterfaceContainer.java
View File

@@ -80,10 +80,9 @@ public class MultiTypeInterfaceContainer
synchronized public InterfaceContainer getContainer(Object key) synchronized public InterfaceContainer getContainer(Object key)
{ {
InterfaceContainer retVal= null; InterfaceContainer retVal= null;
Iterator<Object> it= map.keySet().iterator(); for (Map.Entry<Object,InterfaceContainer> entry : map.entrySet())
while (it.hasNext())
{ {
Object obj= it.next(); Object obj= entry.getKey();
if (obj == null && key == null) if (obj == null && key == null)
{ {
retVal= map.get(null); retVal= map.get(null);
@@ -91,7 +90,7 @@ public class MultiTypeInterfaceContainer
} }
else if( obj != null && obj.equals(key)) else if( obj != null && obj.equals(key))
{ {
retVal= map.get(obj); retVal= entry.getValue();
break; break;
} }
} }