mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead in basegfx

Browse Source 
Change-Id: I8b3f7810eb08b5217df30b7be27aafadeeed247a
Reviewed-on: https://gerrit.libreoffice.org/79647
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-09-26 14:11:14 +02:00
parent ef98596d62
commit 664f8632b1
3 changed files with 1 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
basegfx/source/tools/systemdependentdata.cxx
View File

@@ -77,7 +77,7 @@ namespace basegfx
if(0 == mnCalculatedCycles) if(0 == mnCalculatedCycles)
{ {
const sal_Int64 nBytes(estimateUsageInBytes()); const sal_Int64 nBytes(estimateUsageInBytes());
const sal_uInt32 nSeconds(getHoldCyclesInSeconds()); const sal_uInt32 nSeconds = 60; // HoldCyclesInSeconds
// default is Seconds (minimal is one) // default is Seconds (minimal is one)
sal_uInt32 nResult(0 == nSeconds ? 1 : nSeconds); sal_uInt32 nResult(0 == nSeconds ? 1 : nSeconds);
@@ -115,12 +115,6 @@ namespace basegfx
return mnCalculatedCycles; return mnCalculatedCycles;
} }
sal_uInt32 SystemDependentData::getHoldCyclesInSeconds() const
{
// default implementation returns 60(s)
return 60;
}
sal_Int64 SystemDependentData::estimateUsageInBytes() const sal_Int64 SystemDependentData::estimateUsageInBytes() const
{ {
// default implementation has no idea // default implementation has no idea

6
compilerplugins/clang/virtualdead.results
View File

@@ -31,12 +31,6 @@ Gui/qaccessible.h:613
Gui/qaccessible.h:619 Gui/qaccessible.h:619
void QAccessibleTableInterface::modelChange(class QAccessibleTableModelChangeEvent *,) void QAccessibleTableInterface::modelChange(class QAccessibleTableModelChangeEvent *,)
empty empty
include/basegfx/utils/systemdependentdata.hxx:122
unsigned int basegfx::SystemDependentData::getHoldCyclesInSeconds()const
60
include/basegfx/utils/unopolypolygon.hxx:97
void basegfx::unotools::UnoPolyPolygon::modifying()const
empty
include/canvas/base/bitmapcanvasbase.hxx:80 include/canvas/base/bitmapcanvasbase.hxx:80
unsigned char canvas::BitmapCanvasBase::hasAlpha() unsigned char canvas::BitmapCanvasBase::hasAlpha()
1 1

6
include/basegfx/utils/systemdependentdata.hxx
View File

@@ -115,12 +115,6 @@ namespace basegfx
// mnCalculatedCycles // mnCalculatedCycles
sal_uInt32 calculateCombinedHoldCyclesInSeconds() const; sal_uInt32 calculateCombinedHoldCyclesInSeconds() const;
// Number of cycles a SystemDependentDataManager should/might
// hold this instance in seconds - does not have to be used,
// but should be. Default implementation returns 60(s). Override to
// offer useful data if you want to have better caching.
virtual sal_uInt32 getHoldCyclesInSeconds() const;
// Size estimation of the entry in bytes - does not have to // Size estimation of the entry in bytes - does not have to
// be used, but should be. Default returns zero what // be used, but should be. Default returns zero what
// means there is no size estimation available. Override to // means there is no size estimation available. Override to