mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead in chart2

Browse Source 
Change-Id: Ia24e5072cf4d16e8a437323fa7fd5ab5207e71d2
Reviewed-on: https://gerrit.libreoffice.org/79645
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-09-26 13:52:09 +02:00
parent 66e45a1ae8
commit ef98596d62
14 changed files with 1 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
chart2/source/controller/dialogs/ChartTypeDialogController.cxx
View File

@@ -339,10 +339,6 @@ bool ChartTypeDialogController::shouldShow_StackingControl() const
{
return false;
}
bool ChartTypeDialogController::shouldShow_DeepStackingControl() const
{
return false;
}
bool ChartTypeDialogController::shouldShow_SplineControl() const
{
return false;
@@ -714,10 +710,6 @@ bool LineChartDialogController::shouldShow_StackingControl() const
{
return true;
}
bool LineChartDialogController::shouldShow_DeepStackingControl() const
{
return false;
}
bool LineChartDialogController::shouldShow_SplineControl() const
{
return true;

2
chart2/source/controller/dialogs/ChartTypeDialogController.hxx
View File

@@ -96,7 +96,6 @@ public:
virtual bool shouldShow_3DLookControl() const;
virtual bool shouldShow_StackingControl() const;
virtual bool shouldShow_DeepStackingControl() const;
virtual bool shouldShow_SplineControl() const;
virtual bool shouldShow_GeometryControl() const;
virtual bool shouldShow_SortByXValuesResourceGroup() const;
@@ -192,7 +191,6 @@ public:
virtual void adjustParameterToMainType( ChartTypeParameter& rParameter ) override;
virtual bool shouldShow_StackingControl() const override;
virtual bool shouldShow_DeepStackingControl() const override;
virtual bool shouldShow_SplineControl() const override;
};

2
chart2/source/controller/dialogs/tp_ChartType.cxx
View File

@@ -830,7 +830,7 @@ void ChartTypeTabPage::showAllControls( ChartTypeDialogController& rTypeControll
bool bShow = rTypeController.shouldShow_3DLookControl();
m_pDim3DLookResourceGroup->showControls( bShow );
bShow = rTypeController.shouldShow_StackingControl();
m_pStackingResourceGroup->showControls( bShow, rTypeController.shouldShow_DeepStackingControl() );
m_pStackingResourceGroup->showControls( bShow, false );
bShow = rTypeController.shouldShow_SplineControl();
m_pSplineResourceGroup->showControls( bShow );
bShow = rTypeController.shouldShow_GeometryControl();

4
chart2/source/controller/sidebar/ChartAreaPanel.cxx
View File

@@ -503,10 +503,6 @@ void ChartAreaPanel::selectionChanged(bool bCorrectType)
updateData();
}
void ChartAreaPanel::SelectionInvalid()
{
}
void ChartAreaPanel::updateModel(
css::uno::Reference<css::frame::XModel> xModel)
{

1
chart2/source/controller/sidebar/ChartAreaPanel.hxx
View File

@@ -63,7 +63,6 @@ public:
virtual void modelInvalid() override;
virtual void selectionChanged(bool bCorrectType) override;
virtual void SelectionInvalid() override;
virtual void dispose() override;

4
chart2/source/controller/sidebar/ChartAxisPanel.cxx
View File

@@ -348,10 +348,6 @@ void ChartAxisPanel::selectionChanged(bool bCorrectType)
updateData();
}
void ChartAxisPanel::SelectionInvalid()
{
}
IMPL_LINK(ChartAxisPanel, CheckBoxHdl, Button*, pButton, void)
{
CheckBox* pCheckbox = static_cast<CheckBox*>(pButton);

1
chart2/source/controller/sidebar/ChartAxisPanel.hxx
View File

@@ -70,7 +70,6 @@ public:
virtual void modelInvalid() override;
virtual void selectionChanged(bool bCorrectType) override;
virtual void SelectionInvalid() override;
virtual void updateModel(css::uno::Reference<css::frame::XModel> xModel) override;

4
chart2/source/controller/sidebar/ChartLinePanel.cxx
View File

@@ -223,10 +223,6 @@ void ChartLinePanel::selectionChanged(bool bCorrectType)
updateData();
}
void ChartLinePanel::SelectionInvalid()
{
}
void ChartLinePanel::updateModel(
css::uno::Reference<css::frame::XModel> xModel)
{

1
chart2/source/controller/sidebar/ChartLinePanel.hxx
View File

@@ -55,7 +55,6 @@ public:
virtual void modelInvalid() override;
virtual void selectionChanged(bool bCorrectType) override;
virtual void SelectionInvalid() override;
virtual void dispose() override;

4
chart2/source/controller/sidebar/ChartSeriesPanel.cxx
View File

@@ -442,10 +442,6 @@ void ChartSeriesPanel::selectionChanged(bool bCorrectType)
updateData();
}
void ChartSeriesPanel::SelectionInvalid()
{
}
IMPL_LINK(ChartSeriesPanel, CheckBoxHdl, Button*, pButton, void)
{
CheckBox* pCheckBox = static_cast<CheckBox*>(pButton);

1
chart2/source/controller/sidebar/ChartSeriesPanel.hxx
View File

@@ -76,7 +76,6 @@ public:
virtual void modelInvalid() override;
virtual void selectionChanged(bool bCorrectType) override;
virtual void SelectionInvalid() override;
virtual void updateModel(css::uno::Reference<css::frame::XModel> xModel) override;

1
chart2/source/controller/sidebar/ChartSidebarSelectionListener.cxx
View File

@@ -66,7 +66,6 @@ void ChartSidebarSelectionListener::selectionChanged(const css::lang::EventObjec
void ChartSidebarSelectionListener::disposing(const css::lang::EventObject& /*rEvent*/)
{
mpParent->SelectionInvalid();
}
void ChartSidebarSelectionListener::setAcceptedTypes(const std::vector<ObjectType>& aTypes)

2
chart2/source/controller/sidebar/ChartSidebarSelectionListener.hxx
View File

@@ -26,8 +26,6 @@ public:
virtual ~ChartSidebarSelectionListenerParent();
virtual void selectionChanged(bool bSelected) = 0;
virtual void SelectionInvalid() = 0;
};
class ChartSidebarSelectionListener : public cppu::WeakImplHelper<css::view::XSelectionChangeListener>

6
compilerplugins/clang/virtualdead.results
View File

@@ -7,12 +7,6 @@ basic/source/comp/codegen.cxx:476
basic/source/comp/codegen.cxx:526
_Bool BufferTransformer::processParams()
1
chart2/source/controller/dialogs/ChartTypeDialogController.hxx:99
_Bool chart::ChartTypeDialogController::shouldShow_DeepStackingControl()const
0
chart2/source/controller/sidebar/ChartSidebarSelectionListener.hxx:30
void chart::sidebar::ChartSidebarSelectionListenerParent::SelectionInvalid()
empty
desktop/source/deployment/registry/inc/dp_backenddb.hxx:119
class rtl::OUString dp_registry::backend::BackendDb::getDbNSName()
"http://openoffi