loplugin: defaultparams

Change-Id: I455b200febc9939f3fb81597938b26c0e9eb5f74
This commit is contained in:
Noel Grandin
2015-08-12 15:09:57 +02:00
parent 56af9ab6bb
commit 719c55cda7
18 changed files with 33 additions and 36 deletions

View File

@@ -1087,9 +1087,7 @@ void BackendImpl::PackageImpl::exportTo(
{
// transfer every item of folder into zip:
Reference<sdbc::XResultSet> xResultSet(
sourceContent.createCursor(
Sequence<OUString>(),
::ucbhelper::INCLUDE_FOLDERS_AND_DOCUMENTS ) );
sourceContent.createCursor( Sequence<OUString>() ) );
ProgressLevel progress( xCmdEnv, OUString() );
while (xResultSet->next())
{
@@ -1590,8 +1588,7 @@ void BackendImpl::PackageImpl::scanLegacyBundle(
OUString ar [] = { OUString("Title"), OUString("IsFolder") };
Reference<sdbc::XResultSet> xResultSet(
ucbContent.createCursor(
Sequence<OUString>( ar, ARLEN(ar) ),
::ucbhelper::INCLUDE_FOLDERS_AND_DOCUMENTS ) );
Sequence<OUString>( ar, ARLEN(ar) ) ) );
while (xResultSet->next())
{
checkAborted( abortChannel );

View File

@@ -203,7 +203,7 @@ void SAL_CALL SplashScreen::start(const OUString&, sal_Int32 nRange)
_bProgressEnd = false;
SolarMutexGuard aSolarGuard;
if ( _eBitmapMode == BM_FULLSCREEN )
pWindow->ShowFullScreenMode( true );
pWindow->ShowFullScreenMode();
pWindow->Show();
pWindow->Redraw();
}
@@ -229,7 +229,7 @@ void SAL_CALL SplashScreen::reset()
if (_bVisible && !_bProgressEnd )
{
if ( _eBitmapMode == BM_FULLSCREEN )
pWindow->ShowFullScreenMode( true );
pWindow->ShowFullScreenMode();
pWindow->Show();
updateStatus();
}
@@ -246,7 +246,7 @@ void SAL_CALL SplashScreen::setText(const OUString& rText)
if (_bVisible && !_bProgressEnd)
{
if ( _eBitmapMode == BM_FULLSCREEN )
pWindow->ShowFullScreenMode( true );
pWindow->ShowFullScreenMode();
pWindow->Show();
updateStatus();
}
@@ -261,7 +261,7 @@ void SAL_CALL SplashScreen::setValue(sal_Int32 nValue)
SolarMutexGuard aSolarGuard;
if (_bVisible && !_bProgressEnd) {
if ( _eBitmapMode == BM_FULLSCREEN )
pWindow->ShowFullScreenMode( true );
pWindow->ShowFullScreenMode();
pWindow->Show();
if (nValue >= _iMax)
_iProgress = _iMax;

View File

@@ -746,7 +746,7 @@ uno::Reference< io::XStream > OleEmbeddedObject::TryToRetrieveCachedVisualRepres
#endif
}
xResult = TryToRetrieveCachedVisualRepresentation_Impl( xStream, false );
xResult = TryToRetrieveCachedVisualRepresentation_Impl( xStream );
}
}
}

View File

@@ -60,9 +60,9 @@ namespace abp
m_pName->SetModifyHdl( LINK(this, FinalPage, OnNameModified) );
m_pLocation->SetModifyHdl( LINK(this, FinalPage, OnNameModified) );
m_pRegisterName->SetClickHdl( LINK( this, FinalPage, OnRegister ) );
m_pRegisterName->Check(true);
m_pRegisterName->Check();
m_pEmbed->SetClickHdl( LINK( this, FinalPage, OnEmbed ) );
m_pEmbed->Check(true);
m_pEmbed->Check();
OnEmbed(m_pEmbed);
}

View File

@@ -107,7 +107,7 @@ void BibTBListBoxListener::statusChanged(const ::com::sun::star::frame::FeatureS
aEntry = pStringArray[i];
pToolBar->InsertSourceEntry(aEntry);
}
pToolBar->UpdateSourceList(true);
pToolBar->UpdateSourceList();
}
pToolBar->SelectSourceEntry(rEvt.FeatureDescriptor);

View File

@@ -65,7 +65,7 @@ namespace dbp
// if we do not need the data source selection page ...
if (!needDatasourceSelection())
{ // ... skip it!
skip(1);
skip();
m_bHadDataSelection = false;
}
}

View File

@@ -267,7 +267,7 @@ namespace dbp
if (bMoveLeft)
{
while (m_pExistingRadios->GetSelectEntryCount())
m_pExistingRadios->RemoveEntry(m_pExistingRadios->GetSelectEntryPos(0));
m_pExistingRadios->RemoveEntry(m_pExistingRadios->GetSelectEntryPos());
}
else
{

View File

@@ -61,7 +61,7 @@ namespace dbp
// if we do not need the data source selection page ...
if (!needDatasourceSelection())
{ // ... skip it!
skip(1);
skip();
m_bHadDataSelection = false;
}
}

View File

@@ -524,7 +524,7 @@ IMPL_LINK( PluginConnector, WorkOnNewMessageHdl, Mediator*, /*pMediator*/ )
{
MediatorMessage* pMessage;
CommandAtoms nCommand;
while( (pMessage = GetNextMessage( false )) )
while( (pMessage = GetNextMessage()) )
{
nCommand = (CommandAtoms)pMessage->GetUINT32();
SAL_INFO(

View File

@@ -94,7 +94,7 @@ IMPL_LINK( PluginConnector, WorkOnNewMessageHdl, Mediator*, /*pMediator*/ )
MediatorMessage* pMessage;
CommandAtoms nCommand;
while( (pMessage = GetNextMessage( false )) )
while( (pMessage = GetNextMessage()) )
{
nCommand = (CommandAtoms)pMessage->GetUINT32();
SAL_INFO("extensions.plugin", GetCommandName(nCommand));

View File

@@ -103,7 +103,7 @@ UnxPluginComm::UnxPluginComm(
m_nCommPID = pid;
// wait for pluginapp.bin to start up
if( ! WaitForMessage( 5000 ) )
if( ! WaitForMessage() )
{
SAL_WARN(
"extensions.plugin",

View File

@@ -1187,7 +1187,7 @@ namespace pcr
vcl::Window *pWindow = rLine.pLine->getControlWindow();
Edit* pControlWindowAsEdit = dynamic_cast<Edit*>(pWindow);
if (pControlWindowAsEdit)
pControlWindowAsEdit->SetReadOnly(true);
pControlWindowAsEdit->SetReadOnly();
else
pWindow->Enable(false);
}

View File

@@ -109,7 +109,7 @@ namespace pcr
/** checks whether the control model can be bound to any XSD data type
*/
bool canBindToAnyDataType() const { return canBindToDataType( -1 ); }
bool canBindToAnyDataType() const { return canBindToDataType(); }
/** checks whether the control model is a source for list entries, as supplied by XML data bindings
*/

View File

@@ -123,19 +123,19 @@ namespace pcr
if (m_pInitialSelection)
{
m_pControlTree->MakeVisible(m_pInitialSelection, true);
m_pControlTree->Select(m_pInitialSelection, true);
m_pControlTree->Select(m_pInitialSelection);
}
else
{
m_pControlTree->MakeVisible(m_pControlTree->First(), true);
if (m_pControlTree->FirstSelected())
m_pControlTree->Select(m_pControlTree->FirstSelected(), false);
m_pNoAssignment->Check(true);
m_pNoAssignment->Check();
}
if (!m_bHaveAssignableControl)
{ // no controls which can be assigned
m_pNoAssignment->Check(true);
m_pNoAssignment->Check();
m_pNoAssignment->Enable(false);
}

View File

@@ -693,7 +693,7 @@ namespace pcr
getTypedControlWindow()->SetDropDownLineCount( LB_DEFAULT_COUNT );
if ( ( nWinStyle & WB_READONLY ) != 0 )
{
getTypedControlWindow()->SetReadOnly( true );
getTypedControlWindow()->SetReadOnly();
getTypedControlWindow()->Enable( true );
}
}
@@ -802,7 +802,7 @@ namespace pcr
getTypedControlWindow()->SetDropDownLineCount( LB_DEFAULT_COUNT );
if ( ( nWinStyle & WB_READONLY ) != 0 )
{
getTypedControlWindow()->SetReadOnly( true );
getTypedControlWindow()->SetReadOnly();
getTypedControlWindow()->Enable( true );
}
}

View File

@@ -72,13 +72,13 @@ namespace pcr
TreatAsNumber( true );
SvNumberFormatter* pFormatter = pSupplier->GetNumberFormatter();
SetFormatter( pFormatter, true );
SetFormatter( pFormatter );
SetValue( 1234.56789 );
}
else
{
TreatAsNumber( false );
SetFormatter( NULL, true );
SetFormatter( NULL );
SetText( "" );
}
}
@@ -218,7 +218,7 @@ namespace pcr
SvNumberFormatter* pFormatter = rDesc.pSupplier->GetNumberFormatter();
if (pFormatter != getTypedControlWindow()->GetFormatter())
getTypedControlWindow()->SetFormatter(pFormatter, true);
getTypedControlWindow()->SetFormatter(pFormatter);
getTypedControlWindow()->SetFormatKey(rDesc.nKey);
const SvNumberformat* pEntry = getTypedControlWindow()->GetFormatter()->GetEntry(getTypedControlWindow()->GetFormatKey());
@@ -251,7 +251,7 @@ namespace pcr
if ( bFallback )
{
getTypedControlWindow()->TreatAsNumber(false);
getTypedControlWindow()->SetFormatter(NULL, true);
getTypedControlWindow()->SetFormatter(NULL);
getTypedControlWindow()->SetText("");
m_nLastDecimalDigits = 0;
}

View File

@@ -562,24 +562,24 @@ bool Sane::Start( BitmapTransporter& rBitmap )
double fTLx, fTLy, fResl = 0.0;
int nOption;
if( ( nOption = GetOptionByName( "tl-x" ) ) != -1 &&
GetOptionValue( nOption, fTLx, 0 ) &&
GetOptionValue( nOption, fTLx ) &&
GetOptionUnit( nOption ) == SANE_UNIT_MM )
{
double fBRx;
if( ( nOption = GetOptionByName( "br-x" ) ) != -1 &&
GetOptionValue( nOption, fBRx, 0 ) &&
GetOptionValue( nOption, fBRx ) &&
GetOptionUnit( nOption ) == SANE_UNIT_MM )
{
nWidthMM = (int)fabs(fBRx - fTLx);
}
}
if( ( nOption = GetOptionByName( "tl-y" ) ) != -1 &&
GetOptionValue( nOption, fTLy, 0 ) &&
GetOptionValue( nOption, fTLy ) &&
GetOptionUnit( nOption ) == SANE_UNIT_MM )
{
double fBRy;
if( ( nOption = GetOptionByName( "br-y" ) ) != -1 &&
GetOptionValue( nOption, fBRy, 0 ) &&
GetOptionValue( nOption, fBRy ) &&
GetOptionUnit( nOption ) == SANE_UNIT_MM )
{
nHeightMM = (int)fabs(fBRy - fTLy);

View File

@@ -471,7 +471,7 @@ void SaneDlg::InitFields()
bSuccess = false;
if( nOption != -1 )
{
bSuccess = mrSane.GetOptionValue( nOption, fValue, 0 );
bSuccess = mrSane.GetOptionValue( nOption, fValue );
if( bSuccess )
{
if( mrSane.GetOptionUnit( nOption ) == SANE_UNIT_MM )
@@ -677,7 +677,7 @@ IMPL_LINK( SaneDlg, ClickBtnHdl, Button*, pButton )
else if( pButton == mpCancelButton )
{
mrSane.Close();
EndDialog( 0 );
EndDialog();
}
return 0;
}