mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:passstuffbyref also for {css::uno,rtl}::Reference

Browse Source 
Change-Id: Ide1102f4dcc5f31de0f896b570fe453b8074454d
This commit is contained in:
Stephan Bergmann
2016-07-07 16:01:09 +02:00
parent da7259b584
commit 8c81f307ee
19 changed files with 42 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
include/xmloff/shapeexport.hxx
View File

@@ -288,7 +288,7 @@ public:
If this is a non NULL reference, the animation information from all shapes given to exportShape()
from now on are collected.
*/
void setAnimationsExporter( rtl::Reference< XMLAnimationsExporter > xAnimExport ) { mxAnimationsExporter = xAnimExport; }
void setAnimationsExporter( rtl::Reference< XMLAnimationsExporter > const & xAnimExport ) { mxAnimationsExporter = xAnimExport; }
/** returns the last set XMLAnimationExport */
const rtl::Reference< XMLAnimationsExporter >& getAnimationsExporter() const { return mxAnimationsExporter; }

6
include/xmloff/xformsimport.hxx
View File

@@ -45,7 +45,7 @@ XMLOFF_DLLPUBLIC SvXMLImportContext* createXFormsModelContext(
* @param pair<XForms binding ID, reference to control>
*/
void bindXFormsValueBinding(
css::uno::Reference<css::frame::XModel>,
css::uno::Reference<css::frame::XModel> const &,
std::pair<css::uno::Reference<css::beans::XPropertySet>,OUString> );
@@ -54,7 +54,7 @@ void bindXFormsValueBinding(
* @param pair<XForms binding ID, reference to control>
*/
void bindXFormsListBinding(
css::uno::Reference<css::frame::XModel>,
css::uno::Reference<css::frame::XModel> const &,
std::pair<css::uno::Reference<css::beans::XPropertySet>,OUString> );
/** perform the actual binding of an XForms submission with the suitable control
@@ -62,7 +62,7 @@ void bindXFormsListBinding(
* @param pair<XForms submission ID, reference to control>
*/
void bindXFormsSubmission(
css::uno::Reference<css::frame::XModel>,
css::uno::Reference<css::frame::XModel> const &,
std::pair<css::uno::Reference<css::beans::XPropertySet>,OUString> );
/** applies the given settings to the given XForms container

4
xmloff/source/chart/MultiPropertySetHandler.hxx
View File

@@ -122,7 +122,7 @@ public:
is casted later to one of the two of them.
*/
explicit MultiPropertySetHandler (css::uno::Reference<
css::uno::XInterface> xObject);
css::uno::XInterface> const & xObject);
~MultiPropertySetHandler();
/** @descr Add a property to handle. The type given implicitly by the
reference to a variable is used to create an instance of
@@ -175,7 +175,7 @@ private:
};
MultiPropertySetHandler::MultiPropertySetHandler (css::uno::Reference<
css::uno::XInterface> xObject)
css::uno::XInterface> const & xObject)
: mxObject (xObject)
{
}

2
xmloff/source/chart/SchXMLAxisContext.cxx
View File

@@ -97,7 +97,7 @@ private:
SchXMLAxisContext::SchXMLAxisContext( SchXMLImportHelper& rImpHelper,
SvXMLImport& rImport, const OUString& rLocalName,
Reference< chart::XDiagram > xDiagram,
Reference< chart::XDiagram > const & xDiagram,
std::vector< SchXMLAxis >& rAxes,
OUString & rCategoriesAddress,
bool bAddMissingXAxisForNetCharts,

2
xmloff/source/chart/SchXMLAxisContext.hxx
View File

@@ -27,7 +27,7 @@ class SchXMLAxisContext : public SvXMLImportContext
public:
SchXMLAxisContext( SchXMLImportHelper& rImpHelper,
SvXMLImport& rImport, const OUString& rLocalName,
css::uno::Reference< css::chart::XDiagram > xDiagram,
css::uno::Reference< css::chart::XDiagram > const & xDiagram,
std::vector< SchXMLAxis >& aAxes,
OUString& rCategoriesAddress,
bool bAddMissingXAxisForNetCharts,

12
xmloff/source/chart/SchXMLExport.cxx
View File

@@ -136,7 +136,7 @@ public:
// auto-styles
/// parse chart and collect all auto-styles used in current pool
void collectAutoStyles( css::uno::Reference< css::chart::XChartDocument > rChartDoc );
void collectAutoStyles( css::uno::Reference< css::chart::XChartDocument > const & rChartDoc );
/// write the styles collected into the current pool as <style:style> elements
void exportAutoStyles();
@@ -152,7 +152,7 @@ public:
which is the outer element of a chart. So these attributes can easily
be parsed again by the container
*/
void exportChart( css::uno::Reference< css::chart::XChartDocument > rChartDoc,
void exportChart( css::uno::Reference< css::chart::XChartDocument > const & rChartDoc,
bool bIncludeTable );
const rtl::Reference<XMLPropertySetMapper>& GetPropertySetMapper() const;
@@ -181,7 +181,7 @@ public:
{ return mrAutoStylePool; }
/// if bExportContent is false the auto-styles are collected
void parseDocument( css::uno::Reference< css::chart::XChartDocument >& rChartDoc,
void parseDocument( css::uno::Reference< css::chart::XChartDocument > const & rChartDoc,
bool bExportContent,
bool bIncludeTable = false );
void exportTable();
@@ -1070,12 +1070,12 @@ SchXMLExportHelper_Impl::~SchXMLExportHelper_Impl()
{
}
void SchXMLExportHelper_Impl::collectAutoStyles( Reference< chart::XChartDocument > rChartDoc )
void SchXMLExportHelper_Impl::collectAutoStyles( Reference< chart::XChartDocument > const & rChartDoc )
{
parseDocument( rChartDoc, false );
}
void SchXMLExportHelper_Impl::exportChart( Reference< chart::XChartDocument > rChartDoc,
void SchXMLExportHelper_Impl::exportChart( Reference< chart::XChartDocument > const & rChartDoc,
bool bIncludeTable )
{
parseDocument( rChartDoc, true, bIncludeTable );
@@ -1106,7 +1106,7 @@ static OUString lcl_GetStringFromNumberSequence( const css::uno::Sequence< sal_I
}
/// if bExportContent is false the auto-styles are collected
void SchXMLExportHelper_Impl::parseDocument( Reference< chart::XChartDocument >& rChartDoc,
void SchXMLExportHelper_Impl::parseDocument( Reference< chart::XChartDocument > const & rChartDoc,
bool bExportContent,
bool bIncludeTable )
{

2
xmloff/source/chart/SchXMLPropertyMappingContext.cxx
View File

@@ -65,7 +65,7 @@ SchXMLPropertyMappingContext::SchXMLPropertyMappingContext( SchXMLImportHelper&
SvXMLImport& rImport, const OUString& rLocalName,
tSchXMLLSequencesPerIndex & rLSequencesPerIndex,
uno::Reference<
chart2::XDataSeries > xSeries ):
chart2::XDataSeries > const & xSeries ):
SvXMLImportContext( rImport, XML_NAMESPACE_LO_EXT, rLocalName ),
mrImportHelper( rImpHelper ),
mxDataSeries(xSeries),

2
xmloff/source/chart/SchXMLPropertyMappingContext.hxx
View File

@@ -30,7 +30,7 @@ public:
SvXMLImport& rImport, const OUString& rLocalName,
tSchXMLLSequencesPerIndex& rLSequencesPerIndex,
css::uno::Reference<
css::chart2::XDataSeries > xSeries );
css::chart2::XDataSeries > const & xSeries );
virtual ~SchXMLPropertyMappingContext();

4
xmloff/source/core/PropertySetMerger.cxx
View File

@@ -39,7 +39,7 @@ private:
Reference< XPropertySetInfo > mxPropSet2Info;
public:
PropertySetMergerImpl( const Reference< XPropertySet > rPropSet1, const Reference< XPropertySet > rPropSet2 );
PropertySetMergerImpl( const Reference< XPropertySet > & rPropSet1, const Reference< XPropertySet > & rPropSet2 );
virtual ~PropertySetMergerImpl();
// XPropertySet
@@ -65,7 +65,7 @@ public:
// Interface implementation
PropertySetMergerImpl::PropertySetMergerImpl( Reference< XPropertySet > rPropSet1, Reference< XPropertySet > rPropSet2 )
PropertySetMergerImpl::PropertySetMergerImpl( Reference< XPropertySet > const & rPropSet1, Reference< XPropertySet > const & rPropSet2 )
: mxPropSet1( rPropSet1 )
, mxPropSet1State( rPropSet1, UNO_QUERY )
, mxPropSet1Info( rPropSet1->getPropertySetInfo() )

16
xmloff/source/draw/XMLImageMapContext.cxx
View File

@@ -126,7 +126,7 @@ public:
SvXMLImport& rImport,
sal_uInt16 nPrefix,
const OUString& rLocalName,
css::uno::Reference<css::container::XIndexContainer> xMap,
css::uno::Reference<css::container::XIndexContainer> const & xMap,
const sal_Char* pServiceName);
void StartElement(
@@ -154,7 +154,7 @@ XMLImageMapObjectContext::XMLImageMapObjectContext(
SvXMLImport& rImport,
sal_uInt16 nPrefix,
const OUString& rLocalName,
Reference<XIndexContainer> xMap,
Reference<XIndexContainer> const & xMap,
const sal_Char* pServiceName) :
SvXMLImportContext(rImport, nPrefix, rLocalName),
sBoundary("Boundary"),
@@ -309,7 +309,7 @@ public:
SvXMLImport& rImport,
sal_uInt16 nPrefix,
const OUString& rLocalName,
css::uno::Reference<css::container::XIndexContainer> xMap);
css::uno::Reference<css::container::XIndexContainer> const & xMap);
virtual ~XMLImageMapRectangleContext();
@@ -327,7 +327,7 @@ XMLImageMapRectangleContext::XMLImageMapRectangleContext(
SvXMLImport& rImport,
sal_uInt16 nPrefix,
const OUString& rLocalName,
Reference<XIndexContainer> xMap) :
Reference<XIndexContainer> const & xMap) :
XMLImageMapObjectContext(rImport, nPrefix, rLocalName, xMap,
"com.sun.star.image.ImageMapRectangleObject"),
bXOK(false),
@@ -411,7 +411,7 @@ public:
SvXMLImport& rImport,
sal_uInt16 nPrefix,
const OUString& rLocalName,
css::uno::Reference<css::container::XIndexContainer> xMap);
css::uno::Reference<css::container::XIndexContainer> const & xMap);
virtual ~XMLImageMapPolygonContext();
@@ -429,7 +429,7 @@ XMLImageMapPolygonContext::XMLImageMapPolygonContext(
SvXMLImport& rImport,
sal_uInt16 nPrefix,
const OUString& rLocalName,
Reference<XIndexContainer> xMap) :
Reference<XIndexContainer> const & xMap) :
XMLImageMapObjectContext(rImport, nPrefix, rLocalName, xMap,
"com.sun.star.image.ImageMapPolygonObject"),
bViewBoxOK(false),
@@ -500,7 +500,7 @@ public:
SvXMLImport& rImport,
sal_uInt16 nPrefix,
const OUString& rLocalName,
css::uno::Reference<css::container::XIndexContainer> xMap);
css::uno::Reference<css::container::XIndexContainer> const & xMap);
virtual ~XMLImageMapCircleContext();
@@ -518,7 +518,7 @@ XMLImageMapCircleContext::XMLImageMapCircleContext(
SvXMLImport& rImport,
sal_uInt16 nPrefix,
const OUString& rLocalName,
Reference<XIndexContainer> xMap)
Reference<XIndexContainer> const & xMap)
: XMLImageMapObjectContext(rImport, nPrefix, rLocalName, xMap,
"com.sun.star.image.ImageMapCircleObject")
, nRadius(0)

2
xmloff/source/draw/numithdl.cxx
View File

@@ -25,7 +25,7 @@ using namespace ::com::sun::star;
// class XMLNumRulePropHdl
XMLNumRulePropHdl::XMLNumRulePropHdl( css::uno::Reference< css::ucb::XAnyCompare > xNumRuleCompare )
XMLNumRulePropHdl::XMLNumRulePropHdl( css::uno::Reference< css::ucb::XAnyCompare > const & xNumRuleCompare )
: mxNumRuleCompare( xNumRuleCompare )
{
}

2
xmloff/source/draw/numithdl.hxx
View File

@@ -31,7 +31,7 @@ class XMLNumRulePropHdl : public XMLPropertyHandler
private:
css::uno::Reference< css::ucb::XAnyCompare > mxNumRuleCompare;
public:
explicit XMLNumRulePropHdl( css::uno::Reference< css::ucb::XAnyCompare > xNumRuleCompare );
explicit XMLNumRulePropHdl( css::uno::Reference< css::ucb::XAnyCompare > const & xNumRuleCompare );
virtual ~XMLNumRulePropHdl();
virtual bool equals( const css::uno::Any& r1, const css::uno::Any& r2 ) const override;

4
xmloff/source/draw/sdpropls.cxx
View File

@@ -853,12 +853,12 @@ bool XMLSdHeaderFooterVisibilityTypeHdl::exportXML(
return bRet;
}
XMLSdPropHdlFactory::XMLSdPropHdlFactory( uno::Reference< frame::XModel > xModel, SvXMLImport& rImport )
XMLSdPropHdlFactory::XMLSdPropHdlFactory( uno::Reference< frame::XModel > const & xModel, SvXMLImport& rImport )
: mxModel( xModel ), mpExport(nullptr), mpImport( &rImport )
{
}
XMLSdPropHdlFactory::XMLSdPropHdlFactory( uno::Reference< frame::XModel > xModel, SvXMLExport& rExport )
XMLSdPropHdlFactory::XMLSdPropHdlFactory( uno::Reference< frame::XModel > const & xModel, SvXMLExport& rExport )
: mxModel( xModel ), mpExport( &rExport ), mpImport(nullptr)
{
}

4
xmloff/source/draw/sdpropls.hxx
View File

@@ -60,8 +60,8 @@ private:
SvXMLImport* mpImport;
public:
XMLSdPropHdlFactory( css::uno::Reference< css::frame::XModel >, SvXMLExport& rExport );
XMLSdPropHdlFactory( css::uno::Reference< css::frame::XModel >, SvXMLImport& rImport );
XMLSdPropHdlFactory( css::uno::Reference< css::frame::XModel > const & xModel, SvXMLExport& rExport );
XMLSdPropHdlFactory( css::uno::Reference< css::frame::XModel > const & xModel, SvXMLImport& rImport );
virtual ~XMLSdPropHdlFactory();
virtual const XMLPropertyHandler* GetPropertyHandler( sal_Int32 nType ) const override;
};

2
xmloff/source/text/txtimp.cxx
View File

@@ -824,7 +824,7 @@ namespace
public:
typedef pair<OUString,OUString> field_param_t;
typedef vector<field_param_t> field_params_t;
FieldParamImporter(const field_params_t* const pInParams, Reference<XNameContainer> xOutParams)
FieldParamImporter(const field_params_t* const pInParams, Reference<XNameContainer> const & xOutParams)
: m_pInParams(pInParams)
, m_xOutParams(xOutParams)
{ };

2
xmloff/source/text/txtparae.cxx
View File

@@ -216,7 +216,7 @@ namespace
class FieldParamExporter
{
public:
FieldParamExporter(SvXMLExport* const pExport, Reference<XNameContainer> xFieldParams)
FieldParamExporter(SvXMLExport* const pExport, Reference<XNameContainer> const & xFieldParams)
: m_pExport(pExport)
, m_xFieldParams(xFieldParams)
{ };

6
xmloff/source/xforms/xformsapi.cxx
View File

@@ -95,7 +95,7 @@ void xforms_addXFormsModel(
}
static Reference<XPropertySet> lcl_findXFormsBindingOrSubmission(
Reference<frame::XModel>& xDocument,
Reference<frame::XModel> const & xDocument,
const OUString& rBindingID,
bool bBinding )
{
@@ -150,14 +150,14 @@ static Reference<XPropertySet> lcl_findXFormsBindingOrSubmission(
}
Reference<XPropertySet> xforms_findXFormsBinding(
Reference<frame::XModel>& xDocument,
Reference<frame::XModel> const & xDocument,
const OUString& rBindingID )
{
return lcl_findXFormsBindingOrSubmission( xDocument, rBindingID, true );
}
Reference<XPropertySet> xforms_findXFormsSubmission(
Reference<frame::XModel>& xDocument,
Reference<frame::XModel> const & xDocument,
const OUString& rBindingID )
{
return lcl_findXFormsBindingOrSubmission( xDocument, rBindingID, false );

4
xmloff/source/xforms/xformsapi.hxx
View File

@@ -40,9 +40,9 @@ void xforms_addXFormsModel(
const css::uno::Reference<css::frame::XModel>& xDocument,
const css::uno::Reference<css::xforms::XModel2>& xModel );
css::uno::Reference<css::beans::XPropertySet> xforms_findXFormsBinding( css::uno::Reference<css::frame::XModel>&, const OUString& );
css::uno::Reference<css::beans::XPropertySet> xforms_findXFormsBinding( css::uno::Reference<css::frame::XModel> const &, const OUString& );
css::uno::Reference<css::beans::XPropertySet> xforms_findXFormsSubmission( css::uno::Reference<css::frame::XModel>&, const OUString& );
css::uno::Reference<css::beans::XPropertySet> xforms_findXFormsSubmission( css::uno::Reference<css::frame::XModel> const &, const OUString& );
void xforms_setValue(
css::uno::Reference<css::beans::XPropertySet>& xPropSet,

6
xmloff/source/xforms/xformsimport.cxx
View File

@@ -64,7 +64,7 @@ SvXMLImportContext* createXFormsModelContext(
}
void bindXFormsValueBinding(
Reference<XModel> xModel,
Reference<XModel> const & xModel,
pair<Reference<XPropertySet>,OUString> aPair )
{
Reference<XBindableValue> xBindable(
@@ -89,7 +89,7 @@ void bindXFormsValueBinding(
}
void bindXFormsListBinding(
Reference<XModel> xModel,
Reference<XModel> const & xModel,
::pair<Reference<XPropertySet>,OUString> aPair )
{
Reference<XListEntrySink> xListEntrySink(
@@ -114,7 +114,7 @@ void bindXFormsListBinding(
}
void bindXFormsSubmission(
Reference<XModel> xModel,
Reference<XModel> const & xModel,
pair<Reference<XPropertySet>,OUString> aPair )
{
Reference<XSubmissionSupplier> xSubmissionSupp( aPair.first, UNO_QUERY );