Resolves: tdf#130548 click is sent to the other member of the group

when toggling one the other gets a click signal, but its too
early and the page size isn't set yet, making the dialog thing
the margins won't fit in the page

Change-Id: I5b51f2d91c69558d47f43b3f05eca3fd87a24125
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88383
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Caolán McNamara
2020-02-10 16:07:27 +00:00
parent 751592f927
commit 8ed176b2cc

View File

@@ -410,9 +410,17 @@ void SvxPageDescPage::Reset( const SfxItemSet* rSet )
aPaperSize.Width() > aPaperSize.Height() )
bLandscape = true;
// tdf#130548 disable callbacks on the other of a pair of the radiogroup
// when toggling its partner
m_xLandscapeBtn->connect_clicked(Link<weld::Button&, void>());
m_xPortraitBtn->connect_clicked(Link<weld::Button&, void>());
m_xLandscapeBtn->set_active(bLandscape);
m_xPortraitBtn->set_active(!bLandscape);
m_xLandscapeBtn->connect_clicked(LINK(this, SvxPageDescPage, SwapOrientation_Impl));
m_xPortraitBtn->connect_clicked(LINK(this, SvxPageDescPage, SwapOrientation_Impl));
m_aBspWin.SetSize( Size( ConvertLong_Impl( aPaperSize.Width(), eUnit ),
ConvertLong_Impl( aPaperSize.Height(), eUnit ) ) );