mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Related tdf#130428: let's add some asserts

Browse Source 
to avoid potential future wrong code

Change-Id: Ib5a10039ce95ed5d9bf6f5905bc58af5182d5c0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87995
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
This commit is contained in:
Julien Nabet
2020-02-05 07:34:16 +01:00
parent 6d9d4f94e9
commit 9811796aba
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cui/source/tabpages/align.cxx
View File

@@ -397,6 +397,7 @@ namespace
// SID_ATTR_ALIGN_LINEBREAK
// SID_ATTR_ALIGN_HYPHENATION
// SID_ATTR_ALIGN_SHRINKTOFIT
assert(false && "UNKNOWN cannot happen here");
break;
case SfxItemState::DISABLED:
case SfxItemState::READONLY:
@@ -436,6 +437,7 @@ void AlignmentTabPage::Reset(const SfxItemSet* pCoreAttrs)
{
default:
//tdf#130428 SfxItemState::UNKNOWN cannot happen here, see s_pRanges. Input is SID_ATTR_ALIGN_HOR_JUSTIFY:
assert(false && "UNKNOWN cannot happen here");
break;
case SfxItemState::DISABLED:
case SfxItemState::READONLY:
@@ -479,6 +481,7 @@ void AlignmentTabPage::Reset(const SfxItemSet* pCoreAttrs)
{
default:
//tdf#130428 SfxItemState::UNKNOWN cannot happen here, see s_pRanges. Input is SID_ATTR_ALIGN_INDENT:
assert(false && "UNKNOWN cannot happen here");
break;
case SfxItemState::DISABLED:
case SfxItemState::READONLY:
@@ -502,6 +505,7 @@ void AlignmentTabPage::Reset(const SfxItemSet* pCoreAttrs)
{
default:
//tdf#130428 SfxItemState::UNKNOWN cannot happen here, see s_pRanges. Input is SID_ATTR_ALIGN_VER_JUSTIFY:
assert(false && "UNKNOWN cannot happen here");
break;
case SfxItemState::DISABLED:
case SfxItemState::READONLY:
@@ -542,6 +546,7 @@ void AlignmentTabPage::Reset(const SfxItemSet* pCoreAttrs)
{
default:
//tdf#130428 SfxItemState::UNKNOWN cannot happen here, see s_pRanges. Input is SID_ATTR_ALIGN_DEGREES:
assert(false && "UNKNOWN cannot happen here");
break;
case SfxItemState::DISABLED:
case SfxItemState::READONLY:
@@ -566,6 +571,7 @@ void AlignmentTabPage::Reset(const SfxItemSet* pCoreAttrs)
{
default:
//tdf#130428 SfxItemState::UNKNOWN cannot happen here, see s_pRanges. Input is SID_ATTR_ALIGN_LOCKPOS:
assert(false && "UNKNOWN cannot happen here");
break;
case SfxItemState::DISABLED:
case SfxItemState::READONLY:
@@ -605,6 +611,7 @@ void AlignmentTabPage::Reset(const SfxItemSet* pCoreAttrs)
{
default:
//tdf#130428 SfxItemState::UNKNOWN cannot happen here, see s_pRanges. Input is SID_ATTR_FRAMEDIRECTION:
assert(false && "UNKNOWN cannot happen here");
break;
case SfxItemState::DISABLED:
case SfxItemState::READONLY: