mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:unusedfields

Browse Source 
Change-Id: I0bd600b59b2bc4b50eb2d32e95c9d1167fdf2eab
Reviewed-on: https://gerrit.libreoffice.org/73823
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin
2019-06-11 12:29:10 +02:00
parent 76c4ed3043
commit 9ba797aa4f
6 changed files with 43 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
compilerplugins/clang/unusedfields.only-used-in-constructor.results
View File

@@ -28,7 +28,7 @@ canvas/workben/canvasdemo.cxx:82
DemoRenderer maColorWhite uno::Sequence<double>
chart2/source/controller/accessibility/AccessibleChartShape.hxx:79
chart::AccessibleChartShape m_aShapeTreeInfo ::accessibility::AccessibleShapeTreeInfo
chart2/source/controller/inc/dlg_View3D.hxx:53
chart2/source/controller/inc/dlg_View3D.hxx:44
chart::View3DDialog m_aControllerLocker class chart::ControllerLockHelper
chart2/source/controller/inc/RangeSelectionListener.hxx:63
chart::RangeSelectionListener m_aControllerLockGuard class chart::ControllerLockGuardUNO
@@ -508,8 +508,6 @@ sc/inc/token.hxx:400
SingleDoubleRefModifier aDub struct ScComplexRefData
sc/qa/unit/ucalc_column.cxx:104
aInputs aName const char *
sc/source/core/data/column3.cxx:1333
(anonymous namespace)::CopyTextAttrsFromClipHandler mrCxt sc::CopyFromClipContext &
sc/source/core/data/document.cxx:1239
(anonymous namespace)::BroadcastRecalcOnRefMoveHandler aSwitch const sc::AutoCalcSwitch
sc/source/core/data/document.cxx:1240
@@ -584,27 +582,21 @@ sd/source/filter/ppt/pptin.hxx:81
SdPPTImport maParam struct PowerPointImportParam
sd/source/ui/inc/AccessibleDocumentViewBase.hxx:263
accessibility::AccessibleDocumentViewBase maViewForwarder class accessibility::AccessibleViewForwarder
sd/source/ui/inc/BulletAndPositionDlg.hxx:65
SvxBulletAndPositionDlg bPreset _Bool
sd/source/ui/inc/BulletAndPositionDlg.hxx:71
SvxBulletAndPositionDlg bIsSlideScope _Bool
sd/source/ui/inc/BulletAndPositionDlg.hxx:81
SvxBulletAndPositionDlg p_View ::sd::View *
sd/source/ui/remotecontrol/Receiver.hxx:35
sd::Receiver pTransmitter class sd::Transmitter *
sd/source/ui/remotecontrol/ZeroconfService.hxx:36
sd::ZeroconfService port const uint
sd/source/ui/table/TableDesignPane.hxx:100
sd::TableDesignPane aImpl const class sd::TableDesignWidget
sd/source/ui/view/DocumentRenderer.cxx:1317
sd/source/ui/view/DocumentRenderer.cxx:1319
sd::DocumentRenderer::Implementation mxObjectShell const SfxObjectShellRef
sd/source/ui/view/viewshel.cxx:1210
sd/source/ui/view/viewshel.cxx:1165
sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock const sd::slidesorter::view::class SlideSorterView::DrawLock
sd/source/ui/view/viewshel.cxx:1211
sd/source/ui/view/viewshel.cxx:1166
sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock const sd::slidesorter::controller::class SlideSorterController::ModelChangeLock
sd/source/ui/view/viewshel.cxx:1212
sd/source/ui/view/viewshel.cxx:1167
sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock const sd::slidesorter::controller::class PageSelector::UpdateLock
sd/source/ui/view/viewshel.cxx:1213
sd/source/ui/view/viewshel.cxx:1168
sd::KeepSlideSorterInSyncWithPageChanges m_aContext const sd::slidesorter::controller::class SelectionObserver::Context
sdext/source/pdfimport/pdfparse/pdfparse.cxx:262
PDFGrammar::definition comment rule<ScannerT>
@@ -646,8 +638,8 @@ sdext/source/pdfimport/pdfparse/pdfparse.cxx:265
PDFGrammar::definition trailer rule<ScannerT>
sdext/source/pdfimport/pdfparse/pdfparse.cxx:265
PDFGrammar::definition xref rule<ScannerT>
sfx2/source/dialog/tabdlg.cxx:100
TabDlg_Impl bModal _Bool
sfx2/inc/autoredactdialog.hxx:105
SfxAutoRedactDialog m_xDocShell class SfxObjectShellLock
sfx2/source/doc/doctempl.cxx:117
DocTempl::DocTempl_EntryData_Impl mxObjShell const class SfxObjectShellLock
slideshow/source/engine/animationnodes/animationbasenode.hxx:90
@@ -728,7 +720,7 @@ svx/source/stbctrls/selctrl.cxx:40
SelectionTypePopup m_aBuilder class VclBuilder
svx/source/stbctrls/zoomctrl.cxx:60
ZoomPopup_Impl m_aBuilder class VclBuilder
svx/source/svdraw/svdcrtv.cxx:51
svx/source/svdraw/svdcrtv.cxx:53
ImplConnectMarkerOverlay maObjects sdr::overlay::OverlayObjectList
svx/source/xml/xmleohlp.cxx:72
OutputStorageWrapper_Impl aTempFile class utl::TempFile
@@ -738,7 +730,7 @@ sw/qa/core/test_ToxTextGenerator.cxx:139
ToxTextGeneratorWithMockedChapterField mChapterFieldType class SwChapterFieldType
sw/qa/extras/layout/layout.cxx:2583
class SvtSysLocaleOptions &
sw/qa/extras/uiwriter/uiwriter.cxx:4077
sw/qa/extras/uiwriter/uiwriter.cxx:4078
IdleTask maIdle class Idle
sw/source/core/crsr/crbm.cxx:66
(anonymous namespace)::CursorStateHelper m_aSaveState const class SwCursorSaveState

22
compilerplugins/clang/unusedfields.readonly.results
View File

@@ -348,22 +348,10 @@ include/sfx2/msg.hxx:118
SfxType0 pType const std::type_info *
include/sfx2/sidebar/ResourceManager.hxx:110
sfx2::sidebar::ResourceManager maMiscOptions const class SvtMiscOptions
include/sfx2/templatelocalview.hxx:134
TemplateLocalView maOpenRegionHdl Link<void *, void>
include/sfx2/templatelocalview.hxx:138
TemplateLocalView maDeleteTemplateHdl Link<class ThumbnailViewItem *, void>
include/sfx2/templatelocalview.hxx:139
TemplateLocalView maDefaultTemplateHdl Link<class ThumbnailViewItem *, void>
include/sfx2/thumbnailview.hxx:315
ThumbnailView maItemStateHdl Link<const class ThumbnailViewItem *, void>
include/svl/ondemand.hxx:55
OnDemandLocaleDataWrapper aSysLocale class SvtSysLocale
include/svtools/editsyntaxhighlighter.hxx:32
MultiLineEditSyntaxHighlight m_aColorConfig const svtools::ColorConfig
include/svtools/simptabl.hxx:58
SvSimpleTable aCommandLink Link<class SvSimpleTable *, void>
include/svx/ctredlin.hxx:67
SvLBoxColorString aPrivColor class Color
include/svx/dialcontrol.hxx:112
svx::DialControl::DialControl_Impl mnLinkedFieldValueMultiplyer sal_Int32
include/svx/graphctl.hxx:53
@@ -372,13 +360,13 @@ include/svx/sdr/overlay/overlayanimatedbitmapex.hxx:51
sdr::overlay::OverlayAnimatedBitmapEx mbOverlayState _Bool
include/svx/sdr/overlay/overlaymanager.hxx:72
sdr::overlay::OverlayManager maDrawinglayerOpt const class SvtOptionsDrawinglayer
include/svx/svdmark.hxx:141
include/svx/svdmark.hxx:140
SdrMarkList maPointName class rtl::OUString
include/svx/svdmark.hxx:142
include/svx/svdmark.hxx:141
SdrMarkList maGluePointName class rtl::OUString
include/svx/svdoedge.hxx:160
SdrEdgeObj mbBoundRectCalculationRunning _Bool
include/svx/svdpntv.hxx:168
include/svx/svdpntv.hxx:167
SdrPaintView maDrawinglayerOpt const class SvtOptionsDrawinglayer
include/test/sheet/xdatapilottable.hxx:31
apitest::XDataPilotTable xCellForChange css::uno::Reference<css::table::XCell>
@@ -556,7 +544,7 @@ sd/source/ui/sidebar/MasterPageContainer.cxx:160
sd::sidebar::MasterPageContainer::Implementation maSmallPreviewNotAvailable class Image
sd/source/ui/slideshow/showwindow.hxx:99
sd::ShowWindow mbMouseCursorHidden _Bool
sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx:143
sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx:144
sd::slidesorter::cache::PageCacheManager::RecentlyUsedPageCaches maMap std::map<key_type, mapped_type>
sd/source/ui/slidesorter/inc/controller/SlsAnimator.hxx:97
sd::slidesorter::controller::Animator maElapsedTime const ::canvas::tools::ElapsedTime
@@ -658,8 +646,6 @@ sw/source/core/doc/tblrwcl.cxx:84
CpyTabFrame::(anonymous) nSize SwTwips
sw/source/core/inc/swblocks.hxx:69
SwImpBlocks m_bInPutMuchBlocks _Bool
sw/source/core/text/atrhndl.hxx:48
SwAttrHandler::SwAttrStack m_pInitialArray class SwTextAttr *[3]
sw/source/filter/inc/rtf.hxx:32
RTFSurround::(anonymous) nVal sal_uInt8
sw/source/ui/dbui/dbinsdlg.cxx:117

42
compilerplugins/clang/unusedfields.untouched.results
View File

@@ -24,6 +24,14 @@ canvas/workben/canvasdemo.cxx:82
DemoRenderer maColorWhite uno::Sequence<double>
chart2/source/controller/dialogs/res_DataLabel.hxx:86
chart::DataLabelResources m_xDC_Dial std::unique_ptr<weld::CustomWeld>
chart2/source/controller/dialogs/tp_3D_SceneAppearance.hxx:60
chart::ThreeD_SceneAppearance_TabPage m_xContainer std::unique_ptr<weld::Container>
chart2/source/controller/dialogs/tp_3D_SceneGeometry.hxx:74
chart::ThreeD_SceneGeometry_TabPage m_xContainer std::unique_ptr<weld::Container>
chart2/source/controller/dialogs/tp_3D_SceneIllumination.hxx:94
chart::ThreeD_SceneIllumination_TabPage m_xContainer std::unique_ptr<weld::Container>
chart2/source/controller/dialogs/tp_3D_SceneIllumination.hxx:111
chart::ThreeD_SceneIllumination_TabPage m_xPreviewWnd std::unique_ptr<weld::CustomWeld>
chart2/source/controller/dialogs/tp_AxisLabel.hxx:60
chart::SchAxisLabelTabPage m_xFlOrient std::unique_ptr<weld::Label>
chart2/source/controller/dialogs/tp_AxisPositions.hxx:62
@@ -152,11 +160,11 @@ include/oox/vml/vmlshapecontext.hxx:116
oox::vml::ShapeTypeContext m_pShapeType std::shared_ptr<ShapeType>
include/registry/registry.hxx:35
Registry_Api acquire void (*)(RegHandle)
include/sfx2/dinfdlg.hxx:479
include/sfx2/dinfdlg.hxx:478
CmisValue m_xFrame std::unique_ptr<weld::Frame>
include/sfx2/dinfdlg.hxx:488
include/sfx2/dinfdlg.hxx:487
CmisDateTime m_xFrame std::unique_ptr<weld::Frame>
include/sfx2/dinfdlg.hxx:498
include/sfx2/dinfdlg.hxx:497
CmisYesNo m_xFrame std::unique_ptr<weld::Frame>
include/sfx2/mgetempl.hxx:63
SfxManageStyleSheetPage m_xNameFt std::unique_ptr<weld::Label>
@@ -268,10 +276,10 @@ include/sfx2/msg.hxx:145
SfxType16 nAttribs sal_uInt16
include/sfx2/msg.hxx:145
SfxType16 pType const std::type_info *
include/sfx2/msg.hxx:146
SfxType17 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
include/sfx2/msg.hxx:146
SfxType17 pType const std::type_info *
include/sfx2/msg.hxx:146
SfxType17 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
include/sfx2/msg.hxx:146
SfxType17 nAttribs sal_uInt16
include/sfx2/msg.hxx:146
@@ -512,11 +520,9 @@ sd/source/ui/dlg/headerfooterdlg.cxx:142
sd::HeaderFooterTabPage mxCTPreviewWin std::unique_ptr<weld::CustomWeld>
sd/source/ui/dlg/PhotoAlbumDialog.hxx:51
sd::SdPhotoAlbumDialog m_xImg std::unique_ptr<weld::CustomWeld>
sd/source/ui/inc/BulletAndPositionDlg.hxx:71
SvxBulletAndPositionDlg bIsSlideScope _Bool
sd/source/ui/inc/BulletAndPositionDlg.hxx:81
SvxBulletAndPositionDlg p_View ::sd::View *
sd/source/ui/inc/BulletAndPositionDlg.hxx:111
sd/source/ui/inc/BulletAndPositionDlg.hxx:102
SvxBulletAndPositionDlg m_xPreviewWIN std::unique_ptr<weld::CustomWeld>
sd/source/ui/inc/BulletAndPositionDlg.hxx:106
SvxBulletAndPositionDlg m_xIndentFT std::unique_ptr<weld::Label>
sd/source/ui/inc/custsdlg.hxx:42
SdCustomShowDlg m_xBtnHelp std::unique_ptr<weld::Button>
@@ -532,15 +538,15 @@ sd/source/ui/slidesorter/view/SlsLayouter.cxx:64
sd::slidesorter::view::Layouter::Implementation mpTheme std::shared_ptr<view::Theme>
sd/source/ui/table/TableDesignPane.hxx:100
sd::TableDesignPane aImpl const class sd::TableDesignWidget
sd/source/ui/view/DocumentRenderer.cxx:1317
sd/source/ui/view/DocumentRenderer.cxx:1319
sd::DocumentRenderer::Implementation mxObjectShell const SfxObjectShellRef
sd/source/ui/view/viewshel.cxx:1210
sd/source/ui/view/viewshel.cxx:1165
sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock const sd::slidesorter::view::class SlideSorterView::DrawLock
sd/source/ui/view/viewshel.cxx:1211
sd/source/ui/view/viewshel.cxx:1166
sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock const sd::slidesorter::controller::class SlideSorterController::ModelChangeLock
sd/source/ui/view/viewshel.cxx:1212
sd/source/ui/view/viewshel.cxx:1167
sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock const sd::slidesorter::controller::class PageSelector::UpdateLock
sd/source/ui/view/viewshel.cxx:1213
sd/source/ui/view/viewshel.cxx:1168
sd::KeepSlideSorterInSyncWithPageChanges m_aContext const sd::slidesorter::controller::class SelectionObserver::Context
sd/source/ui/view/ViewShellBase.cxx:196
sd::ViewShellBase::Implementation mpPageCacheManager std::shared_ptr<slidesorter::cache::PageCacheManager>
@@ -548,8 +554,10 @@ sdext/source/pdfimport/pdfparse/pdfparse.cxx:263
PDFGrammar::definition array rule<ScannerT>
sdext/source/pdfimport/pdfparse/pdfparse.cxx:263
PDFGrammar::definition value rule<ScannerT>
sfx2/source/dialog/tabdlg.cxx:100
TabDlg_Impl bModal _Bool
sfx2/inc/autoredactdialog.hxx:105
SfxAutoRedactDialog m_xDocShell class SfxObjectShellLock
sfx2/inc/autoredactdialog.hxx:109
SfxAutoRedactDialog m_xRedactionTargetsLabel std::unique_ptr<weld::Label>
sfx2/source/doc/doctempl.cxx:117
DocTempl::DocTempl_EntryData_Impl mxObjShell const class SfxObjectShellLock
sfx2/source/inc/sfxpicklist.hxx:33

12
compilerplugins/clang/unusedfields.writeonly.results
View File

@@ -388,8 +388,6 @@ include/svtools/brwbox.hxx:249
BrowseBox::CursorMoveAttempt m_bScrolledToReachCell const _Bool
include/svtools/ctrltool.hxx:150
FontList mpDev2 VclPtr<class OutputDevice>
include/svtools/simptabl.hxx:59
SvSimpleTable aCEvt class CommandEvent
include/svx/bmpmask.hxx:128
SvxBmpMask aSelItem class SvxBmpMaskSelectItem
include/svx/ClassificationDialog.hxx:38
@@ -420,6 +418,8 @@ include/vcl/salnativewidgets.hxx:509
PushButtonValue mbSingleLine _Bool
include/vcl/textrectinfo.hxx:32
TextRectInfo mnLineCount sal_uInt16
include/vcl/toolbox.hxx:112
ToolBox mnKeyModifier sal_uInt16
include/vcl/vclenum.hxx:199
ItalicMatrix yy double
include/vcl/vclenum.hxx:199
@@ -534,8 +534,6 @@ sc/source/core/data/column.cxx:1397
(anonymous namespace)::CopyByCloneHandler meListenType sc::StartListeningType
sc/source/core/data/column.cxx:1398
(anonymous namespace)::CopyByCloneHandler mnFormulaCellCloneFlags const enum ScCloneFlags
sc/source/core/data/column.cxx:3398
(anonymous namespace)::TransferListenersHandler maListenerList (anonymous namespace)::TransferListenersHandler::ListenerListType
sc/source/core/data/sortparam.cxx:264
sc::(anonymous namespace)::ReorderIndex mnPos1 SCCOLROW
sc/source/core/data/table2.cxx:3590
@@ -664,8 +662,6 @@ sd/source/filter/ppt/ppt97animations.hxx:50
Ppt97AnimationInfoAtom nUnknown1 sal_uInt8
sd/source/filter/ppt/ppt97animations.hxx:51
Ppt97AnimationInfoAtom nUnknown2 sal_uInt8
sd/source/ui/inc/BulletAndPositionDlg.hxx:67
SvxBulletAndPositionDlg bHTMLMode _Bool
sd/source/ui/inc/inspagob.hxx:33
SdInsertPagesObjsDlg m_pDoc const class SdDrawDocument *
sd/source/ui/inc/unopage.hxx:277
@@ -784,7 +780,7 @@ svx/source/sidebar/line/LinePropertyPanel.hxx:105
svx::sidebar::LinePropertyPanel maEdgeStyle sfx2::sidebar::ControllerItem
svx/source/sidebar/line/LinePropertyPanel.hxx:106
svx::sidebar::LinePropertyPanel maCapStyle sfx2::sidebar::ControllerItem
svx/source/svdraw/svdibrow.cxx:94
svx/source/svdraw/svdibrow.cxx:95
ImpItemListRow pType const std::type_info *
svx/source/svdraw/svdpdf.hxx:196
ImpSdrPdfImport mdPageWidthPts double
@@ -974,7 +970,7 @@ vcl/inc/salwtype.hxx:243
SalInputContext mpFont rtl::Reference<LogicalFontInstance>
vcl/inc/salwtype.hxx:250
SalSwipeEvent mnVelocityY double
vcl/inc/sft.hxx:462
vcl/inc/sft.hxx:483
vcl::TrueTypeFont mapper sal_uInt32 (*)(const sal_uInt8 *, sal_uInt32, sal_uInt32)
vcl/inc/svdata.hxx:423
ImplSVEvent mpInstanceRef VclPtr<vcl::Window>

1
include/vcl/toolbox.hxx
View File

@@ -109,7 +109,6 @@ private:
tools::Rectangle maLowerRect;
tools::Rectangle maPaintRect;
VclPtr<FloatingWindow> mpFloatWin;
sal_uInt16 mnKeyModifier;
long mnDX;
long mnDY;
long mnMaxItemWidth; // max item width

4
vcl/source/window/toolbox.cxx
View File

@@ -1147,7 +1147,6 @@ void ToolBox::ImplInitToolBoxData()
meLayoutMode = ToolBoxLayoutMode::Normal;
meTextPosition = ToolBoxTextPosition::Right;
mnLastFocusItemId = 0;
mnKeyModifier = 0;
mnActivateCount = 0;
mnImagesRotationAngle = 0;
@@ -4456,7 +4455,6 @@ bool ToolBox::ImplOpenItem( vcl::KeyCode aKeyCode )
void ToolBox::KeyInput( const KeyEvent& rKEvt )
{
vcl::KeyCode aKeyCode = rKEvt.GetKeyCode();
mnKeyModifier = aKeyCode.GetModifier();
sal_uInt16 nCode = aKeyCode.GetCode();
vcl::Window *pParent = ImplGetParent();
@@ -4630,8 +4628,6 @@ void ToolBox::KeyInput( const KeyEvent& rKEvt )
pFocusControl->ImplControlFocus( GetFocusFlags::Init );
}
mnKeyModifier = 0;
// #107712#, leave toolbox
if( bGrabFocusToDocument )
{