mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ofz#19207 check max strlen possible

Browse Source 
Change-Id: I5fe9fde240ef375d9de097dda47953320ecc758d
Reviewed-on: https://gerrit.libreoffice.org/84219
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Caolán McNamara
2019-12-02 13:03:48 +00:00
parent 5da0f455a6
commit a322e61b51
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
filter/source/graphicfilter/icgm/class7.cxx
View File

@@ -127,9 +127,11 @@ void CGM::ImplDoClass7()
nAttributes >>= 12;
pTextEntry->nAttributes = nAttributes;
pAppData += 8;
sal_uInt32 nLen = strlen( reinterpret_cast<char*>( pAppData ) ) + 1;
pTextEntry->pText = new char[ nLen ];
auto nMaxLen = mpEndValidSource - pAppData;
sal_uInt32 nLen = strnlen(reinterpret_cast<char*>(pAppData), nMaxLen);
pTextEntry->pText = new char[nLen + 1];
memcpy( pTextEntry->pText, pAppData, nLen );
pTextEntry->pText[nLen] = 0;
pAppData += nLen;
mpChart->InsertTextEntry( std::move(pTextEntry) );