loplugin:constantparam in cui

Change-Id: I41e62f217dab471e8a8ff257516c75d4db0e7837

cui/source/dialogs/SpellDialog.cxx

@@ -976,7 +976,7 @@ IMPL_LINK_TYPED(SpellDialog, ModifyHdl, Edit&, rEd, void)
 IMPL_LINK_NOARG_TYPED(SpellDialog, CancelHdl, Button*, void)
 {
     //apply changes and ignored text parts first - if there are any
-    rParent.ApplyChangedSentence(m_pSentenceED->CreateSpellPortions(true), false);
+    rParent.ApplyChangedSentence(m_pSentenceED->CreateSpellPortions(), false);
     Close();
 }
 
@@ -1048,7 +1048,7 @@ bool SpellDialog::GetNextSentence_Impl(bool bUseSavedSentence, bool bRecheck)
     if(!bUseSavedSentence)
     {
         //apply changes and ignored text parts
-        rParent.ApplyChangedSentence(m_pSentenceED->CreateSpellPortions(true), bRecheck);
+        rParent.ApplyChangedSentence(m_pSentenceED->CreateSpellPortions(), bRecheck);
     }
     m_pSentenceED->ResetIgnoreErrorsAt();
     m_pSentenceED->ResetModified();
@@ -1852,7 +1852,7 @@ static void lcl_InsertBreakPosition_Impl(
     Returns the text in spell portions. Each portion contains text with an
     equal language and attribute. The spell alternatives are empty.
   -----------------------------------------------------------------------*/
-svx::SpellPortions SentenceEditWindow_Impl::CreateSpellPortions( bool bSetIgnoreFlag ) const
+svx::SpellPortions SentenceEditWindow_Impl::CreateSpellPortions() const
 {
     svx::SpellPortions aRet;
     ExtTextEngine* pTextEngine = GetTextEngine();
@@ -1913,7 +1913,7 @@ svx::SpellPortions SentenceEditWindow_Impl::CreateSpellPortions( bool bSetIgnore
                 aPortion1.sText = pTextEngine->GetText(
                             TextSelection(TextPaM(0, nStart), TextPaM(0, aStart->nPosition)));
                 bool bIsIgnoreError = m_aIgnoreErrorsAt.find( nStart ) != m_aIgnoreErrorsAt.end();
-                if( bSetIgnoreFlag && bIsIgnoreError )
+                if( bIsIgnoreError )
                 {
                     aPortion1.bIgnoreThisError = true;
                 }

cui/source/dialogs/hlmarkwn.cxx

@@ -217,11 +217,11 @@ void SvxHlinkDlgMarkWnd::Move ()
         mbUserMoved = true;
 }
 
-bool SvxHlinkDlgMarkWnd::ConnectToDialog( bool bDoit )
+bool SvxHlinkDlgMarkWnd::ConnectToDialog()
 {
     bool bOldStatus = mbUserMoved;
 
-    mbUserMoved = !bDoit;
+    mbUserMoved = true;
 
     return bOldStatus;
 }

cui/source/dialogs/hltpbase.cxx

@@ -214,7 +214,7 @@ bool SvxHyperlinkTabPageBase::MoveToExtraWnd( Point aNewPos, bool bDisConnectDlg
     bool bReturn =  mpMarkWnd->MoveTo ( aNewPos );
 
     if( bDisConnectDlg )
-        mpMarkWnd->ConnectToDialog( false );
+        mpMarkWnd->ConnectToDialog();
 
     return ( !bReturn && IsMarkWndVisible() );
 }
@@ -242,7 +242,7 @@ void SvxHyperlinkTabPageBase::ShowMarkWnd ()
         {
             // Pos Extrawindow anywhere
             MoveToExtraWnd( Point(10,10) );  // very unlikely
-            mpMarkWnd->ConnectToDialog( false );
+            mpMarkWnd->ConnectToDialog();
         }
         else
         {

cui/source/inc/SpellDialog.hxx

@@ -107,7 +107,7 @@ public:
     bool            IsUndoEditMode() const { return m_bIsUndoEditMode;}
     void            SetUndoEditMode(bool bSet);
 
-    svx::SpellPortions  CreateSpellPortions( bool bSetIgnoreFlag ) const;
+    svx::SpellPortions  CreateSpellPortions() const;
 
     void            ResetUndo();
     void            Undo();

cui/source/inc/hlmarkwn.hxx

@@ -99,7 +99,7 @@ public:
     void RefreshTree(const OUString& aStrURL);
     bool SelectEntry(const OUString& aStrMark);
 
-    bool ConnectToDialog( bool bDoit = true );
+    bool ConnectToDialog();
 
     sal_uInt16 SetError( sal_uInt16 nError);
 };