mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nFlags parameter to Window::Hide appears effectively unused

Browse Source 
...there was a handful of Hide(true) calls, which would happen to actually mean

  Show(false, SHOW_NOPARENTUPDATE)

but I assume those were typos rather than genuine requests for
SHOW_NOPARENTUPDATE.

Change-Id: I20310d58437bb556f95965885f82784f855b517d
This commit is contained in:
Stephan Bergmann
2014-01-14 14:56:42 +01:00
parent 8638560a8b
commit b32b45c50c
7 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cui/source/dialogs/passwdomdlg.cxx
View File

@@ -163,7 +163,7 @@ PasswordToOpenModifyDialog_Impl::PasswordToOpenModifyDialog_Impl(
m_aMoreFewerOptionsBTN.Enable( bIsPasswordToModify ); m_aMoreFewerOptionsBTN.Enable( bIsPasswordToModify );
if (!bIsPasswordToModify) if (!bIsPasswordToModify)
m_aMoreFewerOptionsBTN.Hide( sal_True ); m_aMoreFewerOptionsBTN.Hide();
} }

4
cui/source/factory/dlgfact.cxx
View File

@@ -543,9 +543,9 @@ OUString AbstractURLDlg_Impl::GetName() const
return pDlg->GetName(); return pDlg->GetName();
} }
void AbstractSvxHlinkDlgMarkWnd_Impl::Hide( sal_uInt16 nFlags ) void AbstractSvxHlinkDlgMarkWnd_Impl::Hide()
{ {
((Window*)pDlg)->Hide( nFlags ); ((Window*)pDlg)->Hide();
} }
void AbstractSvxHlinkDlgMarkWnd_Impl::SetSizePixel( const Size& rNewSize ) void AbstractSvxHlinkDlgMarkWnd_Impl::SetSizePixel( const Size& rNewSize )

2
cui/source/factory/dlgfact.hxx
View File

@@ -278,7 +278,7 @@ class SvxHlinkDlgMarkWnd;
class AbstractSvxHlinkDlgMarkWnd_Impl : public AbstractSvxHlinkDlgMarkWnd class AbstractSvxHlinkDlgMarkWnd_Impl : public AbstractSvxHlinkDlgMarkWnd
{ {
DECL_ABSTDLG_BASE(AbstractSvxHlinkDlgMarkWnd_Impl,SvxHlinkDlgMarkWnd) DECL_ABSTDLG_BASE(AbstractSvxHlinkDlgMarkWnd_Impl,SvxHlinkDlgMarkWnd)
virtual void Hide( sal_uInt16 nFlags = 0 ); virtual void Hide() SAL_OVERRIDE;
virtual sal_Bool IsVisible() const ; virtual sal_Bool IsVisible() const ;
virtual void Invalidate( sal_uInt16 nFlags = 0 ); virtual void Invalidate( sal_uInt16 nFlags = 0 );
virtual void SetSizePixel( const Size& rNewSize ); virtual void SetSizePixel( const Size& rNewSize );

2
cui/source/tabpages/autocdlg.cxx
View File

@@ -1778,7 +1778,7 @@ OfaQuoteTabPage::OfaQuoteTabPage(Window* pParent, const SfxItemSet& rSet)
sHeader += "\t"; sHeader += "\t";
m_pSwCheckLB->InsertHeaderEntry( sHeader, HEADERBAR_APPEND, m_pSwCheckLB->InsertHeaderEntry( sHeader, HEADERBAR_APPEND,
HIB_CENTER | HIB_VCENTER | HIB_FIXEDPOS | HIB_FIXED); HIB_CENTER | HIB_VCENTER | HIB_FIXEDPOS | HIB_FIXED);
m_pCheckLB->Hide(true); m_pCheckLB->Hide();
} }
else else
{ {

2
include/svx/svxdlg.hxx
View File

@@ -140,7 +140,7 @@ public:
// in class Window // in class Window
virtual void SetSizePixel( const Size& rNewSize ) = 0; virtual void SetSizePixel( const Size& rNewSize ) = 0;
virtual Size GetSizePixel() const = 0; virtual Size GetSizePixel() const = 0;
virtual void Hide( sal_uInt16 nFlags = 0 ) = 0; virtual void Hide() = 0;
virtual sal_Bool IsVisible() const = 0; virtual sal_Bool IsVisible() const = 0;
virtual void Invalidate( sal_uInt16 nFlags = 0 ) = 0; virtual void Invalidate( sal_uInt16 nFlags = 0 ) = 0;
}; };

2
include/vcl/window.hxx
View File

@@ -721,7 +721,7 @@ public:
Dialog* GetParentDialog() const; Dialog* GetParentDialog() const;
void Show( sal_Bool bVisible = sal_True, sal_uInt16 nFlags = 0 ); void Show( sal_Bool bVisible = sal_True, sal_uInt16 nFlags = 0 );
void Hide( sal_uInt16 nFlags = 0 ) { Show( sal_False, nFlags ); } void Hide() { Show( sal_False ); }
sal_Bool IsVisible() const; sal_Bool IsVisible() const;
sal_Bool IsReallyVisible() const; sal_Bool IsReallyVisible() const;
sal_Bool IsReallyShown() const; sal_Bool IsReallyShown() const;

4
sc/source/ui/miscdlgs/mvtabdlg.cxx
View File

@@ -196,7 +196,7 @@ void ScMoveTableDlg::CheckNewTabName()
} }
else else
{ {
pFtWarn->Hide(sal_True); pFtWarn->Hide();
pFtWarn->SetControlBackground(); pFtWarn->SetControlBackground();
pFtWarn->SetText(OUString()); pFtWarn->SetText(OUString());
pBtnOk->Enable(); pBtnOk->Enable();
@@ -225,7 +225,7 @@ void ScMoveTableDlg::Init()
pBtnMove->Check( true ); pBtnMove->Check( true );
pBtnCopy->Check( false ); pBtnCopy->Check( false );
pEdTabName->Enable(false); pEdTabName->Enable(false);
pFtWarn->Hide(sal_True); pFtWarn->Hide();
InitDocListBox(); InitDocListBox();
SelHdl( pLbDoc ); SelHdl( pLbDoc );
} }