mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

#i126029# Base query wizard error due to missing quoting of table and column names

Browse Source 
During the Base query design wizard,
com.sun.star.wizards.ui.FilterComponent.getFilterConditions()
calls
com.sun.star.wizards.db.SQLQueryComposer.getSelectClause()
before its
getFromClause(). However the getSelectClause() needs composedCommandNames
which is populated only by getFromClause() in order to quote table and column names.
Without this, table and column names that need quoting (spaces, special characters,
reserved words) produce errors.

(cherry picked from commit 046771cac8605e5826a150e4454eff332b65d517)
This commit is contained in:
Damjan Jovanovic
2015-11-07 18:26:04 +00:00
committed by Caolán McNamara
parent f7715e6821
commit b9042d2e46
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
wizards/com/sun/star/wizards/db/SQLQueryComposer.java
View File

@@ -68,6 +68,10 @@ public class SQLQueryComposer
public String getSelectClause(boolean _baddAliasFieldNames) throws SQLException
{
// getFromClause() must be called first to populate composedCommandNames,
// but it's idempotent, so let's call it now in case the caller didn't already:
getFromClause();
String sSelectBaseClause = "SELECT ";
String sSelectClause = sSelectBaseClause;
for (int i = 0; i < CurDBMetaData.FieldColumns.length; i++)