mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

loplugin:virtualdead unused param in ValueGetter::processValue

Browse Source 
Change-Id: Id2b514b0892f8d7cf93fe3c5884e8d89a6f0a7b1
Reviewed-on: https://gerrit.libreoffice.org/81076
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This commit is contained in:
Noel Grandin 2019-10-17 15:42:13 +02:00
parent 0d416965a6
commit b98cb40d97
3 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
compilerplugins/clang/virtualdead.unusedparams.results
View File

@ -238,9 +238,6 @@ sc/inc/formulagroup.hxx:145
sc/source/core/opencl/formulagroupcl.cxx:1059 sc/source/core/opencl/formulagroupcl.cxx:1059
void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,) void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class std::__cxx11::basic_stringstream<char> &,)
0 0
sc/source/ui/vba/vbarange.hxx:68
void ValueGetter::processValue(int,int,const class com::sun::star::uno::Any &,)
001
sdext/source/pdfimport/inc/contentsink.hxx:150 sdext/source/pdfimport/inc/contentsink.hxx:150
void pdfi::ContentSink::drawMask(const class com::sun::star::uno::Sequence<struct com::sun::star::beans::PropertyValue> &,_Bool,) void pdfi::ContentSink::drawMask(const class com::sun::star::uno::Sequence<struct com::sun::star::beans::PropertyValue> &,_Bool,)
10 10

12
sc/source/ui/vba/vbarange.cxx
View File

@ -772,17 +772,17 @@ protected:
public: public:
CellValueGetter() {} CellValueGetter() {}
virtual void visitNode( sal_Int32 x, sal_Int32 y, const uno::Reference< table::XCell >& xCell ) override; virtual void visitNode( sal_Int32 x, sal_Int32 y, const uno::Reference< table::XCell >& xCell ) override;
virtual void processValue( sal_Int32 x, sal_Int32 y, const uno::Any& aValue ) override; virtual void processValue( const uno::Any& aValue ) override;
const uno::Any& getValue() const override { return maValue; } const uno::Any& getValue() const override { return maValue; }
}; };
void void
CellValueGetter::processValue( sal_Int32 /*x*/, sal_Int32 /*y*/, const uno::Any& aValue ) CellValueGetter::processValue( const uno::Any& aValue )
{ {
maValue = aValue; maValue = aValue;
} }
void CellValueGetter::visitNode( sal_Int32 x, sal_Int32 y, const uno::Reference< table::XCell >& xCell ) void CellValueGetter::visitNode( sal_Int32 /*x*/, sal_Int32 /*y*/, const uno::Reference< table::XCell >& xCell )
{ {
uno::Any aValue; uno::Any aValue;
table::CellContentType eType = xCell->getType(); table::CellContentType eType = xCell->getType();
@ -830,7 +830,7 @@ void CellValueGetter::visitNode( sal_Int32 x, sal_Int32 y, const uno::Reference<
uno::Reference< text::XTextRange > xTextRange(xCell, ::uno::UNO_QUERY_THROW); uno::Reference< text::XTextRange > xTextRange(xCell, ::uno::UNO_QUERY_THROW);
aValue <<= xTextRange->getString(); aValue <<= xTextRange->getString();
} }
processValue( x,y,aValue ); processValue( aValue );
} }
class CellFormulaValueSetter : public CellValueSetter class CellFormulaValueSetter : public CellValueSetter
@ -889,7 +889,7 @@ private:
formula::FormulaGrammar::Grammar const m_eGrammar; formula::FormulaGrammar::Grammar const m_eGrammar;
public: public:
CellFormulaValueGetter(ScDocument* pDoc, formula::FormulaGrammar::Grammar eGram ) : CellValueGetter( ), m_pDoc( pDoc ), m_eGrammar( eGram ) {} CellFormulaValueGetter(ScDocument* pDoc, formula::FormulaGrammar::Grammar eGram ) : CellValueGetter( ), m_pDoc( pDoc ), m_eGrammar( eGram ) {}
virtual void visitNode( sal_Int32 x, sal_Int32 y, const uno::Reference< table::XCell >& xCell ) override virtual void visitNode( sal_Int32 /*x*/, sal_Int32 /*y*/, const uno::Reference< table::XCell >& xCell ) override
{ {
uno::Any aValue; uno::Any aValue;
aValue <<= xCell->getFormula(); aValue <<= xCell->getFormula();
@ -911,7 +911,7 @@ public:
aValue <<= sVal; aValue <<= sVal;
} }
processValue( x,y,aValue ); processValue( aValue );
} }
}; };

2
sc/source/ui/vba/vbarange.hxx
View File

@ -65,7 +65,7 @@ class ValueGetter : public ArrayVisitor
{ {
public: public:
virtual void processValue( sal_Int32 x, sal_Int32 y, const css::uno::Any& aValue ) = 0; virtual void processValue( const css::uno::Any& aValue ) = 0;
virtual const css::uno::Any& getValue() const = 0; virtual const css::uno::Any& getValue() const = 0;
}; };