mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lokdialog: Don't hide dialogs in case of LOK

Browse Source 
We change views (using setView) a lot in case of LOK. Changing the view,
without this patch, leads to InitShow on the dialog which means
invalidation of the whole dialog even though there is nothing to
invalidate. This decreases performance as it increases the dialog paint
traffic through the LOK API. We don't need to hide the dialog once it's
opened in case of LOK.

This patch improves the multiview dialog performance considerably
(can easily be noticed in GTV).

Change-Id: If2b4ceb945ccd86da3d90bbbb0a0b9fbade43f30
Reviewed-on: https://gerrit.libreoffice.org/57401
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
This commit is contained in:
Pranav Kant
2017-12-05 02:20:13 +05:30
committed by Jan Holesovsky
parent c1817a5b12
commit dc30fdcf72
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
sfx2/source/appl/workwin.cxx
View File

@@ -18,6 +18,7 @@
*/
#include <config_features.h>
#include <comphelper/lok.hxx>
#include <comphelper/processfactory.hxx>
#include <sfx2/docfile.hxx>
@@ -1482,6 +1483,9 @@ bool SfxWorkWindow::IsVisible_Impl()
void SfxWorkWindow::HidePopups_Impl(bool bHide, bool bParent, sal_uInt16 nId )
{
if (comphelper::LibreOfficeKit::isActive() && bHide)
return;
for (SfxChildWin_Impl* i : aChildWins)
{
SfxChildWindow *pCW = i->pWin;
@@ -1494,7 +1498,8 @@ void SfxWorkWindow::HidePopups_Impl(bool bHide, bool bParent, sal_uInt16 nId )
pChild->nVisible &= ~SfxChildVisibility::ACTIVE;
pCW->Hide();
}
else
else if ( !comphelper::LibreOfficeKit::isActive() ||
SfxChildVisibility::ACTIVE != (pChild->nVisible & SfxChildVisibility::ACTIVE) )
{
pChild->nVisible |= SfxChildVisibility::ACTIVE;
if ( SfxChildVisibility::VISIBLE == (pChild->nVisible & SfxChildVisibility::VISIBLE) )