mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

As the comment says, "news:// is nonsense" here

Browse Source 
It was introduced in the orginal commit 4d3148e0b7
"CWS-TOOLING: integrate CWS mba32issues01" but for copletely unclear reasons.
It looks like it serves as a placeholder for those "unknown-URI-scheme" cases
that shall go to RID_SVXPAGE_HYPERLINK_DOCUMENT, but for a news:// URI it would
make more sense to go to RID_SVXPAGE_HYPERLINK_MAIL anyway.  (Note that
INetURLObject only supports RFC 1738 news URIs that cannot have an authority
part, not RFC 5538 ones that allow for an optional authority part.)

Change-Id: I5db76fc2a733d0c334e24fecb9d7078bedbdbe08
This commit is contained in:
Stephan Bergmann
2014-02-04 15:06:48 +01:00
parent e0e82c6d12
commit dda9037e41
1 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
cui/source/dialogs/cuihyperdlg.cxx
View File

@@ -287,21 +287,12 @@ sal_uInt16 SvxHpLinkDlg::SetPage ( SvxHyperlinkItem* pItem )
nPageId = RID_SVXPAGE_HYPERLINK_MAIL;
break;
default :
sal_Char const sNewsSrvScheme[] = "news://";
// TODO news:// is nonsense
if (aStrURL.startsWith(sNewsSrvScheme))
if (aStrURL.startsWith("#"))
nPageId = RID_SVXPAGE_HYPERLINK_DOCUMENT;
else
{
sal_Char const sHash[] = "#";
if (aStrURL.startsWith(sHash))
nPageId = RID_SVXPAGE_HYPERLINK_DOCUMENT;
else
{
eProtocolTyp = INET_PROT_NOT_VALID;
nPageId = GetCurPageId();
}
eProtocolTyp = INET_PROT_NOT_VALID;
nPageId = GetCurPageId();
}
break;
}