loplugin:constfields in starmath

Change-Id: I5092401b4138ca15e93b36adf1b059e75d4e8f5a
Reviewed-on: https://gerrit.libreoffice.org/61514
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

starmath/inc/ElementsDockingWindow.hxx

@@ -33,8 +33,8 @@ class SmNode;
 class SmElement
 {
     std::unique_ptr<SmNode> mpNode;
-    OUString        maText;
-    OUString        maHelpText;
+    OUString const          maText;
+    OUString const          maHelpText;
 public:
     Point mBoxLocation;
     Size  mBoxSize;

starmath/inc/action.hxx

@@ -28,8 +28,8 @@ class SmDocShell;
 class SmFormatAction: public SfxUndoAction
 {
     SmDocShell  *pDoc;
-    SmFormat    aOldFormat;
-    SmFormat    aNewFormat;
+    SmFormat const    aOldFormat;
+    SmFormat const    aNewFormat;
 
 public:
     SmFormatAction(SmDocShell *pDocSh, const SmFormat& rOldFormat, const SmFormat& rNewFormat);

starmath/inc/node.hxx

@@ -98,7 +98,7 @@ class SmNode : public SmRect
     SmFace      maFace;
 
     SmToken     maNodeToken;
-    SmNodeType      meType;
+    SmNodeType const meType;
     SmScaleMode     meScaleMode;
     RectHorAlign    meRectHorAlign;
     FontChangeMask  mnFlags;
@@ -435,7 +435,7 @@ public:
  */
 class SmSpecialNode : public SmTextNode
 {
-    bool mbIsFromGreekSymbolSet;
+    bool const mbIsFromGreekSymbolSet;
 
 protected:
     SmSpecialNode(SmNodeType eNodeType, const SmToken &rNodeToken, sal_uInt16 _nFontDesc);

starmath/inc/parse.hxx

@@ -66,7 +66,7 @@ class SmParser
     std::set< OUString >   m_aUsedSymbols;
 
     // CharClass representing a locale for parsing numbers
-    CharClass m_aNumCC;
+    CharClass const m_aNumCC;
     // pointer to System locale's CharClass, which is alive inside SM_MOD()
     const CharClass* m_pSysCC;
 

starmath/inc/token.hxx

@@ -128,10 +128,10 @@ struct SmToken
 struct SmTokenTableEntry
 {
     const sal_Char* pIdent;
-    SmTokenType     eType;
-    sal_Unicode     cMathChar;
-    TG              nGroup;
-    sal_uInt16      nLevel;
+    SmTokenType const     eType;
+    sal_Unicode const     cMathChar;
+    TG const              nGroup;
+    sal_uInt16 const      nLevel;
 };
 
 #endif

starmath/inc/view.hxx

@@ -215,7 +215,7 @@ class SmViewShell: public SfxViewShell
     std::unique_ptr<SmViewShell_Impl> mpImpl;
 
     VclPtr<SmGraphicWindow> mpGraphic;
-    SmGraphicController maGraphicController;
+    SmGraphicController const maGraphicController;
     OUString maStatusText;
 
     bool mbPasteState;

starmath/inc/visitors.hxx

@@ -116,8 +116,8 @@ private:
     OutputDevice &mrDev;
     SmCaretPos maPos;
     /** Offset to draw from */
-    Point maOffset;
-    bool mbCaretVisible;
+    Point const maOffset;
+    bool const mbCaretVisible;
 protected:
     /** Default method for drawing pNodes */
     void DefaultVisit( SmNode* pNode ) override;

starmath/source/accessibility.hxx

@@ -59,7 +59,7 @@ SmGraphicAccessibleBaseClass;
 class SmGraphicAccessible final :
     public SmGraphicAccessibleBaseClass
 {
-    OUString                            aAccName;
+    OUString const                      aAccName;
     /// client id in the AccessibleEventNotifier queue
     sal_uInt32                          nClientId;
 
@@ -300,7 +300,7 @@ SmEditAccessibleBaseClass;
 class SmEditAccessible :
     public SmEditAccessibleBaseClass
 {
-    OUString                                aAccName;
+    OUString const                          aAccName;
     std::unique_ptr<::accessibility::AccessibleTextHelper> pTextHelper;
     VclPtr<SmEditWindow>                    pWin;
 

starmath/source/dialog.cxx

@@ -71,9 +71,9 @@ void lclGetSettingColors(Color& rBackgroundColor, Color& rTextColor)
 
 class SmFontStyles
 {
-    OUString aNormal;
-    OUString aBold;
-    OUString aItalic;
+    OUString const aNormal;
+    OUString const aBold;
+    OUString const aItalic;
     OUString aBoldItalic;
 
 public:

starmath/source/document.cxx

@@ -276,10 +276,10 @@ void SetEditEngineDefaultFonts(SfxItemPool &rEditEngineItemPool, const SvtLinguO
 {
     // set fonts to be used
     struct FontDta {
-        LanguageType    nFallbackLang;
+        LanguageType const    nFallbackLang;
         LanguageType    nLang;
-        DefaultFontType nFontType;
-        sal_uInt16      nFontInfoId;
+        DefaultFontType const nFontType;
+        sal_uInt16 const      nFontInfoId;
         } aTable[3] =
     {
         // info to get western font to be used

starmath/source/mathmlimport.cxx

@@ -926,7 +926,7 @@ public:
 class SmXMLRowContext_Impl : public SmXMLDocContext_Impl
 {
 protected:
-    size_t nElementCount;
+    size_t const nElementCount;
 
 public:
     SmXMLRowContext_Impl(SmXMLImport &rImport,sal_uInt16 nPrefix,

starmath/source/mathtype.hxx

@@ -151,7 +151,7 @@ private:
     void TypeFaceToString(OUString &rRet,sal_uInt8 nFace);
 
     OUStringBuffer &rRet;
-    SmNode *pTree;
+    SmNode * const pTree;
 
     sal_uInt8 nHAlign;
 

starmath/source/ooxmlexport.hxx

@@ -38,7 +38,7 @@ private:
     void HandleVerticalBrace( const SmVerticalBraceNode* pNode, int nLevel ) override;
     void HandleBlank() override;
     ::sax_fastparser::FSHelperPtr m_pSerializer;
-    oox::core::OoxmlVersion version;
+    oox::core::OoxmlVersion const version;
     /// needed to determine markup for nested run properties
     oox::drawingml::DocumentType const m_DocumentType;
 };

starmath/source/uiobject.hxx

@@ -20,7 +20,7 @@ class ElementUIObject : public UIObject
 {
 private:
     VclPtr<SmElementsControl> mxElementsSelector;
-    OUString maID;
+    OUString const maID;
 
 public:
 

starmath/source/view.cxx

@@ -853,7 +853,7 @@ struct SmViewShell_Impl
 {
     std::unique_ptr<sfx2::DocumentInserter> pDocInserter;
     std::unique_ptr<SfxRequest> pRequest;
-    SvtMiscOptions          aOpts;
+    SvtMiscOptions const        aOpts;
 };