coverity#704379 Logically dead code

bNotify is set to true in only one place, and bDone is set to true
and the only use of bNotify is inside a !bDone block so it can
only be false there

Change-Id: I05b09d5e1e1406e1268f2e97b0f50db36c391727
This commit is contained in:
Caolán McNamara
2014-03-29 16:50:24 +00:00
parent 0ca2b5d566
commit e67a148d52

View File

@@ -120,7 +120,6 @@ void SwDrawBaseShell::Execute(SfxRequest &rReq)
sal_Bool bAlignPossible = pSh->IsAlignPossible();
sal_Bool bTopParam = sal_True, bBottomParam = sal_True;
bool bNotify = false;
bool bDone = false;
SfxBindings& rBind = GetView().GetViewFrame()->GetBindings();
@@ -400,7 +399,6 @@ void SwDrawBaseShell::Execute(SfxRequest &rReq)
pSh->LeaveSelFrmMode();
// #105852# FME
}
bNotify = true;
}
break;
@@ -602,9 +600,6 @@ void SwDrawBaseShell::Execute(SfxRequest &rReq)
pSh->SetModified();
else if (bChanged)
pSdrView->GetModel()->SetChanged(true);
// 40220: After Delete from DrawObjecs over the API GPF through self-destruction
if(bNotify)
GetView().AttrChangedNotify(pSh); // Shell switch if applicable...
}
}