mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cid#1492159 Uninitialized scalar field

Browse Source 
since...

commit c2e6a068c1
Date:   Wed Sep 8 12:07:48 2021 +1000

    vcl: create FontMetric from PhysicalFontFace

where previously we had...

 FontMetric aFontMetric;
 ...
 aFontMetric.SetFamilyName( rData.GetFamilyName() );
 ...
 return aFontMetric;

so the FontMetric default ctor was called which initialized all
FontMetric's members, but afterwards with...

 return FontMetric(rData);

the new FontMetric ctor taking a const PhysicalFontFace& arg left all
the non-inherited members of FontMetric uninitialized

Change-Id: I91ee08ed1d63d15eccec44c87841884b2992eacb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122317
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
This commit is contained in:
Caolán McNamara
2021-09-19 12:46:45 +01:00
parent 6e0f3a6803
commit ecab8f30de
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
vcl/source/font/fontmetric.cxx
View File

@@ -52,6 +52,7 @@ FontMetric::FontMetric()
FontMetric::FontMetric( const FontMetric& rFontMetric ) = default;
FontMetric::FontMetric(PhysicalFontFace const& rFace)
: FontMetric()
{
SetFamilyName(rFace.GetFamilyName());
SetStyleName(rFace.GetStyleName());