sal: MSVC: pragma warning: make more specific, remove obsolete

Change-Id: Ib7ad23257a966447d627b4f73698d9298790f759
Reviewed-on: https://gerrit.libreoffice.org/49042
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

include/rtl/stringutils.hxx

@@ -78,7 +78,7 @@ struct SAL_WARN_UNUSED OUStringLiteral1_ {
 #if defined _MSC_VER && _MSC_VER <= 1900 && !defined __clang__
     // Visual Studio 2015
 using OUStringLiteral1 = OUStringLiteral1_;
-#pragma warning(disable: 4239)
+#pragma warning(disable: 4239) // nonstandard extension used: 'argument': conversion from 'rtl::OUStringLiteral1_' to 'rtl::OUStringLiteral1_ &'
 #else
 using OUStringLiteral1 = OUStringLiteral1_ const;
 #endif

include/systools/win32/comtools.hxx

@@ -22,13 +22,7 @@
 
 #include <string>
 #include <stdexcept>
-#if defined _MSC_VER
-#pragma warning(push,1)
-#endif
 #include <objbase.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 namespace sal
 {

sal/osl/w32/file_url.hxx

@@ -25,19 +25,11 @@
 #include <osl/file.h>
 #include <osl/mutex.h>
 
-#ifdef _MSC_VER
-#pragma warning(push,1)
-#endif
-
 #if !defined WIN32_LEAN_AND_MEAN
 # define WIN32_LEAN_AND_MEAN
 #endif
 #include <windows.h>
 
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
-
 #define PATHTYPE_ERROR                      0
 #define PATHTYPE_RELATIVE                   1
 #define PATHTYPE_ABSOLUTE_UNC               2

sal/osl/w32/module.cxx

@@ -197,13 +197,7 @@ osl_getAsciiFunctionSymbol( oslModule Module, const sal_Char *pSymbol )
 /* Implementation for Windows NT, 2K and XP (2K and XP could use the above method too) */
 /***************************************************************************************/
 
-#ifdef _MSC_VER
-#pragma warning(push,1) /* disable warnings within system headers */
-#endif
 #include <imagehlp.h>
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
 
 typedef BOOL (WINAPI *SymInitialize_PROC)(
     HANDLE   hProcess,

sal/osl/w32/nlsupport.cxx

@@ -18,13 +18,8 @@
  */
 
 #define WIN32_LEAN_AND_MEAN
-#ifdef _MSC_VER
-#pragma warning(push,1) /* disable warnings within system headers */
-#endif
 #include <windows.h>
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
+
 #include <wchar.h>
 
 #include "nlsupport.hxx"

sal/osl/w32/process.cxx

@@ -19,13 +19,8 @@
 
 #include "system.h"
 #include <string.h>
-#ifdef _MSC_VER
-#pragma warning(push,1) /* disable warnings within system headers */
-#endif
+
 #include <shellapi.h>
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include <cassert>
 #include <memory>
@@ -320,10 +315,6 @@ static struct CommandArgs_Impl g_command_args =
     nullptr
 };
 
-#ifdef _MSC_VER
-#pragma warning( push )
-#pragma warning( disable: 4100 )
-#endif
 static rtl_uString ** osl_createCommandArgs_Impl (int argc, char **)
 {
     rtl_uString ** ppArgs =
@@ -369,9 +360,6 @@ static rtl_uString ** osl_createCommandArgs_Impl (int argc, char **)
     return ppArgs;
 
 }
-#ifdef _MSC_VER
-#pragma warning( pop )
-#endif
 
 oslProcessError SAL_CALL osl_getExecutableFile( rtl_uString **ppustrFile )
 {

sal/osl/w32/procimpl.cxx

@@ -19,13 +19,7 @@
 
 #ifndef WIN32_LEAN_AND_MEAN
 # define WIN32_LEAN_AND_MEAN
-# ifdef _MSC_VER
-#   pragma warning(push,1) /* disable warnings within system headers */
-# endif
 # include <windows.h>
-# ifdef _MSC_VER
-#   pragma warning(pop)
-# endif
 # undef WIN32_LEAN_AND_MEAN
 #endif
 

sal/osl/w32/system.h

@@ -43,8 +43,6 @@
 #define WIN32_LEAN_AND_MEAN
 
 // winsock2.h includes windows.h
-#pragma warning(push,1) /* disable warnings within system headers */
-#pragma warning(disable:4917)
 #include <winsock2.h>
 #include <wsipx.h>
 #include <ws2tcpip.h>
@@ -52,6 +50,5 @@
 #ifndef NO_DEBUG_CRT
     #include <crtdbg.h>
 #endif
-#pragma warning(pop)
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */

sal/rtl/alloc_impl.hxx

@@ -193,13 +193,7 @@ typedef pthread_mutex_t rtl_memory_lock_type;
 #elif defined(_WIN32)
 
 #define WIN32_LEAN_AND_MEAN
-#ifdef _MSC_VER
-#pragma warning(push,1) /* disable warnings within system headers */
-#endif
 #include <windows.h>
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
 
 typedef CRITICAL_SECTION rtl_memory_lock_type;
 

sal/rtl/string.cxx

@@ -19,10 +19,6 @@
 
 #include <sal/config.h>
 
-#ifdef _MSC_VER
-#pragma warning(disable:4738) // storing 32-bit float result in memory, possible loss of performance
-#endif
-
 #include <cassert>
 #include <cstdlib>
 

sal/rtl/ustring.cxx

@@ -19,10 +19,6 @@
 
 #include <sal/config.h>
 
-#ifdef _MSC_VER
-#pragma warning(disable:4738) // storing 32-bit float result in memory, possible loss of performance
-#endif
-
 #include <cassert>
 #include <cstdlib>
 #include <limits>