loplugin:virtualdead in chart2

Change-Id: Ia24e5072cf4d16e8a437323fa7fd5ab5207e71d2
Reviewed-on: https://gerrit.libreoffice.org/79645
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

chart2/source/controller/dialogs/ChartTypeDialogController.cxx

@@ -339,10 +339,6 @@ bool ChartTypeDialogController::shouldShow_StackingControl() const
 {
     return false;
 }
-bool ChartTypeDialogController::shouldShow_DeepStackingControl() const
-{
-    return false;
-}
 bool ChartTypeDialogController::shouldShow_SplineControl() const
 {
     return false;
@@ -714,10 +710,6 @@ bool LineChartDialogController::shouldShow_StackingControl() const
 {
     return true;
 }
-bool LineChartDialogController::shouldShow_DeepStackingControl() const
-{
-    return false;
-}
 bool LineChartDialogController::shouldShow_SplineControl() const
 {
     return true;

chart2/source/controller/dialogs/ChartTypeDialogController.hxx

@@ -96,7 +96,6 @@ public:
 
     virtual bool    shouldShow_3DLookControl() const;
     virtual bool    shouldShow_StackingControl() const;
-    virtual bool    shouldShow_DeepStackingControl() const;
     virtual bool    shouldShow_SplineControl() const;
     virtual bool    shouldShow_GeometryControl() const;
     virtual bool    shouldShow_SortByXValuesResourceGroup() const;
@@ -192,7 +191,6 @@ public:
     virtual void adjustParameterToMainType( ChartTypeParameter& rParameter ) override;
 
     virtual bool    shouldShow_StackingControl() const override;
-    virtual bool    shouldShow_DeepStackingControl() const override;
     virtual bool    shouldShow_SplineControl() const override;
 };
 

chart2/source/controller/dialogs/tp_ChartType.cxx

@@ -830,7 +830,7 @@ void ChartTypeTabPage::showAllControls( ChartTypeDialogController& rTypeControll
     bool bShow = rTypeController.shouldShow_3DLookControl();
     m_pDim3DLookResourceGroup->showControls( bShow );
     bShow = rTypeController.shouldShow_StackingControl();
-    m_pStackingResourceGroup->showControls( bShow, rTypeController.shouldShow_DeepStackingControl() );
+    m_pStackingResourceGroup->showControls( bShow, false );
     bShow = rTypeController.shouldShow_SplineControl();
     m_pSplineResourceGroup->showControls( bShow );
     bShow = rTypeController.shouldShow_GeometryControl();

chart2/source/controller/sidebar/ChartAreaPanel.cxx

@@ -503,10 +503,6 @@ void ChartAreaPanel::selectionChanged(bool bCorrectType)
         updateData();
 }
 
-void ChartAreaPanel::SelectionInvalid()
-{
-}
-
 void ChartAreaPanel::updateModel(
         css::uno::Reference<css::frame::XModel> xModel)
 {

chart2/source/controller/sidebar/ChartAreaPanel.hxx

@@ -63,7 +63,6 @@ public:
     virtual void modelInvalid() override;
 
     virtual void selectionChanged(bool bCorrectType) override;
-    virtual void SelectionInvalid() override;
 
     virtual void dispose() override;
 

chart2/source/controller/sidebar/ChartAxisPanel.cxx

@@ -348,10 +348,6 @@ void ChartAxisPanel::selectionChanged(bool bCorrectType)
         updateData();
 }
 
-void ChartAxisPanel::SelectionInvalid()
-{
-}
-
 IMPL_LINK(ChartAxisPanel, CheckBoxHdl, Button*, pButton, void)
 {
     CheckBox* pCheckbox = static_cast<CheckBox*>(pButton);

chart2/source/controller/sidebar/ChartAxisPanel.hxx

@@ -70,7 +70,6 @@ public:
     virtual void modelInvalid() override;
 
     virtual void selectionChanged(bool bCorrectType) override;
-    virtual void SelectionInvalid() override;
 
     virtual void updateModel(css::uno::Reference<css::frame::XModel> xModel) override;
 

chart2/source/controller/sidebar/ChartLinePanel.cxx

@@ -223,10 +223,6 @@ void ChartLinePanel::selectionChanged(bool bCorrectType)
         updateData();
 }
 
-void ChartLinePanel::SelectionInvalid()
-{
-}
-
 void ChartLinePanel::updateModel(
         css::uno::Reference<css::frame::XModel> xModel)
 {

chart2/source/controller/sidebar/ChartLinePanel.hxx

@@ -55,7 +55,6 @@ public:
     virtual void modelInvalid() override;
 
     virtual void selectionChanged(bool bCorrectType) override;
-    virtual void SelectionInvalid() override;
 
     virtual void dispose() override;
 

chart2/source/controller/sidebar/ChartSeriesPanel.cxx

@@ -442,10 +442,6 @@ void ChartSeriesPanel::selectionChanged(bool bCorrectType)
         updateData();
 }
 
-void ChartSeriesPanel::SelectionInvalid()
-{
-}
-
 IMPL_LINK(ChartSeriesPanel, CheckBoxHdl, Button*, pButton, void)
 {
     CheckBox* pCheckBox = static_cast<CheckBox*>(pButton);

chart2/source/controller/sidebar/ChartSeriesPanel.hxx

@@ -76,7 +76,6 @@ public:
     virtual void modelInvalid() override;
 
     virtual void selectionChanged(bool bCorrectType) override;
-    virtual void SelectionInvalid() override;
 
     virtual void updateModel(css::uno::Reference<css::frame::XModel> xModel) override;
 

chart2/source/controller/sidebar/ChartSidebarSelectionListener.cxx

@@ -66,7 +66,6 @@ void ChartSidebarSelectionListener::selectionChanged(const css::lang::EventObjec
 
 void ChartSidebarSelectionListener::disposing(const css::lang::EventObject& /*rEvent*/)
 {
-    mpParent->SelectionInvalid();
 }
 
 void ChartSidebarSelectionListener::setAcceptedTypes(const std::vector<ObjectType>& aTypes)

chart2/source/controller/sidebar/ChartSidebarSelectionListener.hxx

@@ -26,8 +26,6 @@ public:
     virtual ~ChartSidebarSelectionListenerParent();
 
     virtual void selectionChanged(bool bSelected) = 0;
-
-    virtual void SelectionInvalid() = 0;
 };
 
 class ChartSidebarSelectionListener : public cppu::WeakImplHelper<css::view::XSelectionChangeListener>

compilerplugins/clang/virtualdead.results

@@ -7,12 +7,6 @@ basic/source/comp/codegen.cxx:476
 basic/source/comp/codegen.cxx:526
     _Bool BufferTransformer::processParams()
     1
-chart2/source/controller/dialogs/ChartTypeDialogController.hxx:99
-    _Bool chart::ChartTypeDialogController::shouldShow_DeepStackingControl()const
-    0
-chart2/source/controller/sidebar/ChartSidebarSelectionListener.hxx:30
-    void chart::sidebar::ChartSidebarSelectionListenerParent::SelectionInvalid()
-    empty
 desktop/source/deployment/registry/inc/dp_backenddb.hxx:119
     class rtl::OUString dp_registry::backend::BackendDb::getDbNSName()
     "http://openoffi