Stephan Bergmann
00d0a50e3b
Window::Notify should return bool, redux
...
Change-Id: Ib41ed9ace428081e1948cf109de095ea9e7c45c2
2014-01-17 18:45:17 +01:00
Stephan Bergmann
ed1878d27e
-Werror,-Wunused-function
...
Change-Id: Ia6c6d6fe484789722987cea7d8b4b4bfc1c28953
2014-01-17 18:45:17 +01:00
Stephan Bergmann
e908f69ec0
Clang plugin that flags implicit conversions from bool
...
...as they are often enough errors, like a typo in brace placement in
if (foo == (FOO || bar == BAR) && baz)
or a literal true passed as an argument to a function that rather expects an
integer bit mask, etc. The plugin is smart enough to detect interaction with
logically boolean return/parameter types of C functions that use [unsigned] int
instead, and knows the relevant boolean typedefs (sal_Bool, gboolean, etc.).
Change-Id: I5f0e4344fe86589bec35a71018c7effdedf85e3e
2014-01-17 18:45:16 +01:00
Stephan Bergmann
c963d7e642
bool improvements
...
Change-Id: I9324483db587be43238af79c2148d724397a4622
2014-01-17 18:45:16 +01:00
Stephan Bergmann
8711842d1b
bool improvements
...
Change-Id: I19b429741a2ba972bef8863008657823b9bb7f91
2014-01-17 18:45:16 +01:00
Stephan Bergmann
a2b1afaf88
bool improvements
...
Change-Id: Ib7c2e846885812b5352b06d568d62f744a3c07c4
2014-01-17 18:45:15 +01:00
Stephan Bergmann
59a5ccb952
bool improvements
...
Change-Id: I89e8351001dcdda9303473f38ece3b57c0d9e72c
2014-01-17 18:45:15 +01:00
Stephan Bergmann
03725013b6
bool improvements
...
Change-Id: Ic46fa46c200b94e2e6c5a073ba89b9aae5c14542
2014-01-17 18:45:15 +01:00
Stephan Bergmann
20223e2374
bool improvements
...
Change-Id: I9f5564100aa64ff4940dd93a81ff5a8d8edc7a07
2014-01-17 18:45:14 +01:00
Stephan Bergmann
5169abbac9
bool improvements
...
Change-Id: I7ec4f5b2e691ec03e9e2c5ca3a004f1e04efbc27
2014-01-17 18:45:14 +01:00
Stephan Bergmann
3e5ff1f8d4
Be explicit when using bool as integral value (as Link return value)
...
Change-Id: I3b345be909ed2cb93cd0d478af4b26c9909d2726
2014-01-17 18:45:14 +01:00
Stephan Bergmann
e7a99b3cde
Flag bogus "true" with a FIXME
...
Change-Id: I0ff052ca980f33aa62333a26c70ba91e21ede56a
2014-01-17 18:45:14 +01:00
Stephan Bergmann
1b33a38e32
Whatever those "true" arguments to SotStorage ctor may once have meant
...
...is lost to history, but they are effectively equivalent to pssing default
SorageMode nStorageMode = 0 today, as the only thing that is done with that
nStorageMode value (in SotStorage::CreateStorage, sot/source/sdstor/storage.cxx)
is to compare it against STORAGE_TRANSACTED (0x04) STORAGE_CREATE_UNPACKED
(0x44).
Change-Id: I6ce79c03aff941b5abb5370e52a30b2294690b3a
2014-01-17 18:45:13 +01:00
Stephan Bergmann
ecf43ac726
EndDialog takes long nResult, not bool
...
Change-Id: Id57ad91eb6f2a5f7f4801ebc3a1317bb7bf46adf
2014-01-17 18:45:13 +01:00
Stephan Bergmann
5c3eca5e84
bool improvements
...
Change-Id: Ia5ab74b8a8b367ea92f29eb6269ef0ede47f09bb
2014-01-17 18:45:13 +01:00
Caolán McNamara
dfddb1d302
need to call SetFrameSize on Resize
...
otherwise if the crop tab is not the initial tab shown then
it doesn't repaint correctly when it is shown
Change-Id: Ie61819fe3fb089b716547fa5e54352ae04fd8087
2014-01-17 17:11:16 +00:00
Andre Fischer
285d62c554
105491: Switched update of vertical flag and setting the item set to avoid infinite recursion.
...
(cherry picked from commit bb94c19d2c7df1c468d38b7744e0d34e8ac27a99)
2014-01-17 17:11:16 +00:00
Miklos Vajna
75934fc178
VML import: handle shape with text inside groupshape as TextShape
...
This matches the behavior of the WW8 import and gives us the required
text wrapping when the shape text doesn't fit in a single line.
Change-Id: I32a13516503620344d313593834be29a3dc9f726
2014-01-17 17:39:07 +01:00
Kohei Yoshida
ce8010b482
Remove warning and build error with MSVC.
...
Change-Id: I8eac2f5ff08968a885a8e413bf4db38092036957
2014-01-17 11:33:17 -05:00
Kohei Yoshida
9d2424a67c
This is a struct.
...
Change-Id: Ieee10f9acb67453ac6c3d893d29330e19d96bdef
2014-01-17 11:33:17 -05:00
Kohei Yoshida
f108efa272
Add border test file for XLSX import.
...
This is an exactly the same file as the XLS counterpart, only saved
as XLSX.
Change-Id: I05adcdf26eb031324daf810218e770bdc4dc496c
2014-01-17 11:33:17 -05:00
Kohei Yoshida
0a3544fed4
Make the same change to the xlsx import filter.
...
Change-Id: I94c97e5aa55e6b728d07e91f2527fc0c10820f24
2014-01-17 11:33:17 -05:00
Kohei Yoshida
1cb500c2aa
Remove TODO. Now these border thicknesses are permanently set.
...
Change-Id: Idbf732182eaa5a4b94c98ad4d408407f50cc299b
2014-01-17 11:33:16 -05:00
Kohei Yoshida
d4d174a675
Ensure that we display patterned lines at all zoom levels.
...
VCL doesn't draw polygons if either its width or height is 1 pixel.
Detect when the polygon is too small to display, and substitute it
with a minimum displayable rectangle.
Change-Id: I7e3174d549880d00ffa55fd2239484c2db3d7829
2014-01-17 11:33:16 -05:00
Kohei Yoshida
009b7be7c8
Revise the line patterns further. Now they look satisfactory to my eye.
...
Change-Id: I27f4e11bceac25c10de28a866bdcec9576027582
2014-01-17 11:33:16 -05:00
Kohei Yoshida
225509026f
Double line looks a bit too apart.
...
Change-Id: I14676b6e8282a76d0be9dc0cc78e01837726e494
2014-01-17 11:33:16 -05:00
Kohei Yoshida
8d140f3867
More faithful mapping of border line thicknesses.
...
This time based on how they get printed on paper, not how they look
on screen.
Change-Id: I61a217822229f843de3e89e96cf58b273f2cd8ac
2014-01-17 11:33:15 -05:00
Kohei Yoshida
5489b897bf
Distance value has been already scaled; no need to apply scaling twice.
...
Change-Id: Id3ffc253dbd50fd23e924b4e1a349ab5c2c8518b
2014-01-17 11:33:15 -05:00
Kohei Yoshida
0a8ddb61b1
Apply dashing without consulting current map unit.
...
Using scaling is sufficient.
Change-Id: If976bec3940772432d814a77681170d7c99306d2
2014-01-17 11:33:15 -05:00
Kohei Yoshida
5250a9ae8e
Use this pattern scale to scale things for better line pattern generation.
...
This works much better across different output devices.
Change-Id: Ie89e7284d9063f98fc5a31c505b64f8ce99a7ce1
2014-01-17 11:33:15 -05:00
Kohei Yoshida
f2ff3b1054
Pass scaling to borderline primitive objects.
...
This will be used when generating line patterns.
Change-Id: I2fa0298bd3e34df1cb304d9be41e471835484d83
2014-01-17 11:33:14 -05:00
Kohei Yoshida
c04cff6e12
Make thse constructors non-inline.
...
Change-Id: Iaf23a9962c9dd748247cb986ffabb1a5ba173c09
2014-01-17 11:33:14 -05:00
Kohei Yoshida
e128bf2aef
Draw double lined table border somewhat more pleasantly.
...
Still a scaling issue remains when printed.
Change-Id: I4aab8b976fefc6fd9fc5c08da8173de1326b9a4c
2014-01-17 11:33:14 -05:00
Kohei Yoshida
b7d4d28c6d
Disable these tests for now.
...
Change-Id: I4dc62a8ae0788b468dd11384025964bd9c3ea874
2014-01-17 11:33:14 -05:00
Kohei Yoshida
7b708d3006
Always disable anti-aliasing when drawing table borders.
...
Change-Id: Idede8220ac36c5bd4a88ceda33a99333f7b9fe90
2014-01-17 11:33:13 -05:00
Kohei Yoshida
c95871a04b
Map Excel's normal dashed line to our FINE_DASHED.
...
Excel's medium dashed maps better with our regular DASHED pattern.
Change-Id: I9c7161ced9592b6c6617d6edbc616e0b1c3dc1e8
2014-01-17 11:33:13 -05:00
Kohei Yoshida
ba4324917a
More fine-tuned stroke patterns.
...
Only the pixel map mode is visually inspected.
Change-Id: Ia8ac978a0d3049d7e7162f1157822b85d475dfdf
2014-01-17 11:33:13 -05:00
Kohei Yoshida
3136b39e0d
Use hairlines judiciously to draw very thin patterned strokes correctly.
...
This prevents some dashed or dotted lines from being skipped when printing
or in print preview.
Change-Id: I9d0a8ae743241d17d65935f4bf0d122e4313bff8
2014-01-17 11:33:12 -05:00
Kohei Yoshida
2c702a31f0
Fixed comment.
...
Change-Id: I48d8ed8e218508f4f2d8f377fa9052ba02e61f37
2014-01-17 11:33:11 -05:00
Kohei Yoshida
6064f984cd
Excel's hair line is not "fine dashed". It's a solid line.
...
Excel may display this line as fine dots on screen, but on paper this is
a ultra thin solid line. We need to go by what gets printed on paper.
Change-Id: I6640706ff8a16ad26330f8f609a429fb7f14faad
2014-01-17 11:33:11 -05:00
Kohei Yoshida
5cdb7a5934
Remove STYLE_* and use css::table::BorderLineStyle instead.
...
Change-Id: I187511dbf85ecdfe0c5d05c6f77cf4ac93363051
2014-01-17 11:33:11 -05:00
Kohei Yoshida
1051a7bedc
Typos etc.
...
Change-Id: I4838514bc85636df1b3f0558ce1796431bfe19f3
2014-01-17 11:33:11 -05:00
Kohei Yoshida
5a0258868c
Hide the implementation of svx::frame::Array.
...
Change-Id: Iad2d494bf7dd9f1f69e4e863aeaa514bf76c7c76
2014-01-17 11:33:10 -05:00
Kohei Yoshida
ebba1f506c
Test Excel document that contains all cell borders that Excel supports.
...
Plus some screenshots of what they look like in Excel.
2014-01-17 11:33:10 -05:00
Caolán McNamara
e44e87ae12
standardize indent between tabpages
...
Change-Id: I1a8b5e7ad1688b968ad9a91f987e14c1d75b542b
2014-01-17 16:29:21 +00:00
Caolán McNamara
12ec0a80a4
Updated core
...
Project: help 48be01cfea8e46888219d8b384031ce09c1d829d
2014-01-17 16:20:38 +00:00
Olivier Hallot
9c4032921c
Convert chart data source tab page & dialog to .ui
...
Conflicts:
chart2/source/controller/dialogs/dlg_DataSource.cxx
chart2/source/controller/inc/dlg_DataSource.hxx
Change-Id: Ic3e3adc578156161f16254862e1ca33a8ad9e1f6
Reviewed-on: https://gerrit.libreoffice.org/7255
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2014-01-17 16:09:50 +00:00
Tor Lillqvist
92bede3900
Avoid some global statics that drag in lots of code in the static linking case
...
When doing static linking, i.e. when building the single executable
for an iOS app, or the single DSO for an Android app, we list all our
libraries (which all are static archives) on the linker command
line. Static initializers in any library always get linked in, so it
is a good idea to avoid such in the cases where they drag in a large
amount of code. Which was the case here.
Change-Id: Idef9aec1c10686c86f517ad10cf540a313d9c829
2014-01-17 17:47:42 +02:00
Stephan Bergmann
04683f1488
Window::Notify should return bool
...
Change-Id: I72081b1022582c8b6f95a611e21d9c78f7581efe
2014-01-17 16:42:29 +01:00
Miklos Vajna
734cf8395d
VML import: fix height of textboxes when border distance is non-zero
...
The VML concept is that the height / width of a textbox is absolute, and
border distances only affect the position of the shape text, not the
size of it. OTOH, when we set the Text*Distance UNO properties on a
textbox, the size may change. Make sure that during VML import setting
those properties doesn't change the size.
Change-Id: I53b328b66572fc05027be344869bc1a78d855558
2014-01-17 16:35:02 +01:00