...to be able to find problems like 6e0bdf04add338b7d5b29fc7b3fc9f08cfd5e96f
"sal_Bool arg of SetUseImagesInMenus was abused to squeeze '2' through it"
earlier when converting occurrences of sal_Bool to bool.
Restricting this check to function call arguments avoids too much noise while
hopefully still catching all the relevant problems.
(This check partially overlaps the pointertobool check, so implicit conversions
from pointers to bool call arguments will now generate two loplugin warnings,
but that's harmless.)
Change-Id: I0b03b1d1615aaf8bc18e7a84c56fff3ef9903508
I create two icons for the sifr-theme (the missing saveas icons).
Hope this is correct. :-)
Change-Id: I9b9063018d6d0662e8805b6cf502262deed46d3c
Reviewed-on: https://gerrit.libreoffice.org/8191
Reviewed-by: Joren De Cuyper <jorendc@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
regression from b29c078c7f193dd7dae74baf89fe1abb9264239c because if the search
view widget is visible then its assumed that we are in search view mode
Change-Id: I8e81ffa06d5d3ac50e110105c9444707fd4c41c6
delaying the initial event prevents complaints from OSX>=10.7's "windows
restore" feature to recur infinitely. Apparently OSX cleans things up for us
just before we get the applicationDidFinishLaunching() callback.
(cherry picked from commit 0f3712ff654c740f3593b9580f34cdfe21ac3250)
Conflicts:
vcl/osx/salinst.cxx
Change-Id: I0f1d59f03ffe4efc7c9a73fa881151fa06af5424
which means that icons suddenly reappeared in the menus when the gtk
theme had disabled them
ref e8f8f24c8415898c787bbfb629247ed62e73a2b9
Change-Id: Ia9aef5ca39bda2ddf6d7c4ebc2bddc01d470d09b
Embedded spreadsheets consist on two files:
* The spreadsheet found in word/embeddings/ directory.
* A preview image found in word/media/ directory.
This patch saves these two files and writes the proper XML to the
document. It looks like this:
<w:object>
<v:shape id="ole_rId2"
style="width:362.55pt;height:145.7pt" o:ole="">
<v:imagedata r:id="rId3" />
</v:shape>
<o:OLEObject Type="Embed" ProgID="Excel.Sheet.12"
ShapeID="ole_rId2" DrawAspect="Content"
ObjectID="_227653443" r:id="rId2" />
</w:object>
Some simplifications were done in comparison with the XML generated
by Word; the lines above seem to be the minimum working code.
Similarly to drawings, charts, etc. our code postpones the actual
process of the OLE objects until the rPr tag is closed.
TODO:
* Unit tests.
* Add information about xlsx extension to [Content_Types].xml
* Without that, Word doesn't detect the OLE as an spreadsheet.
Change-Id: Ia0c797b72cd6e99ca9ad7fa11897b62ab3867a5e
