Thanks to Jurassic Pork and prrychr (tdf#99363) for the 2016 patch.
I used smtp.gmail.com as my testing server.
Port 587 is the "official" port to use for encrypted email.
I confirmed that 587 CANNOT use SMTP_SSL [SSL: UNKNOWN_PROTOCOL],
so I limited SMTP_SSL use to common TLS port 465 only.
Port 465 was temporarily recommended, but OFFICIALLY has long
since been abandoned. However, LOTS of documentation and ISPs still
recommend it as the port to use. I confirmed that 465 DOES NOT
support STARTTLS, so it is specifically excluded.
So, technically the button should say use STARTTLS instead of SSL,
but only for SMTP. IMAP/POP do use SSL, so terminology gets
rather confusing. This patch forces SSL without STARTTLS for port 465
regardless of the "use SSL" setting due to all the confusion.
Currently we don't support ANY SSL/TLS connections. With this patch
we now at least support the extremely common use case of port 465.
Change-Id: I210cc307491157c1121cfffd70cbb94347ee2856
Reviewed-on: https://gerrit.libreoffice.org/48210
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Referenced external document data can be loaded after user
permission from dialog or corresponding settings.
Change-Id: If3aec37c8bbdee4aebeb99c7807e87c26df8e592
Reviewed-on: https://gerrit.libreoffice.org/48398
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
* import static text & fields:
VALUE, SERIESNAME, COLUMNNAME
* text is formatted
* DataPointCustomLabelField with field type
(DataPointCustomLabelFieldType) was introduced.
* text can have many portions & multiple lines
* unit tests for import data labels with formatting
Not implemented: CELLREF field support which needs
importing some additional data from extLst
Shows custom text as a label for data points.
Change-Id: Iba8fd508eb16356b05586b93d7b8da32240d2b91
Reviewed-on: https://gerrit.libreoffice.org/48243
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
...after 288d694ff695ef83cbe4224db87dd65281c75a8f "LOK - Calc: Text is not
visible in cell when entering numerical input" changed EditLine::nStartPosX from
sal_uInt16 to long
Change-Id: Ib1d364015c7ab0b5f81fb740659110c66aed002a
Reviewed-on: https://gerrit.libreoffice.org/48845
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Horizontal mirror on the UNO API level, mirror on the vertical axis
internally.
Change-Id: If142274a8f81a6875059a2651af6d8470870a36a
Reviewed-on: https://gerrit.libreoffice.org/48843
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
... to already open soffice process from newly spawned one on Windows.
When an application takes user input, a timeout is started during
which other processes cannot create foreground windows that might
steal focus, and thus interrupt user input. The timeout is defined
by SPI_SETFOREGROUNDLOCKTIMEOUT (see SystemParametersInfo) and
ForegroundLockTimeout registry setting (see
https://technet.microsoft.com/en-us/library/cc957208). If an
application that currently doesn't have right to become foreground
tries to show popups in this interval, the popup will stay on
background, and only flash in taskbar.
The application that has the right to steal focus (see the list in
https://msdn.microsoft.com/en-us/library/ms632668) may transfer its
right to another process using AllowSetForegroundWindow function.
So, the intended effect is this:
1. User interacts with some foreground process (e.g., Explorer);
a timeout is started to prevent non-privileged processes from
stealing focus;
2. As the result, the process launches a new soffice process, which
has privilege to create foreground windows (as it is started by
foreground process);
3. It communicates with already started soffice process, which is
currently in background, and so doesn't have privilege to create
foreground windows until timeout expires;
4. It transfers its right to the already started soffice process,
and then issues the required commands that might lead to need to
show popup windows.
Change-Id: I4208665c2ae4106fa06e72269f4c3804af40d582
Reviewed-on: https://gerrit.libreoffice.org/48839
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
If the default value is in the SMTP port field, switching
SSL on and off will toggle between SECURE_PORT and DEFAULT_PORT
Change-Id: Ie4bdd55a3d8bbe64ce6b8761ba30971464c1db4e
Reviewed-on: https://gerrit.libreoffice.org/48211
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
nCount apparently must fit into sal_uInt16 for the cast further down when
passing it into ScAppOptions::SetLRUFuncList sal_uInt16 nCount parameter. (But
why the odd "nCount < SAL_MAX_UINT16" vs. "nCount <= SAL_MAX_UINT16" off-by-one?
Oh, my.)
Change-Id: I231f4af2ce2e6bf44db8db3fd9e965adfa17fecb
Reviewed-on: https://gerrit.libreoffice.org/48838
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
nArgCount apparently must fit into sal_uInt16 for the cast further down when
assigning it to sal_uInt16 ScFuncDesc::nArgCount
Change-Id: Ie82f864d519589553505015dc577b1e3372293b2
Reviewed-on: https://gerrit.libreoffice.org/48836
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
This is specifically necessary for named expressions that are used
in conditional format formulas, for which RPN is generated at a
later stage, not during import.
Change-Id: Ia8e1d92a3a12f6c226fec56e85f23f122f2fe902
that was introduced with 54596087e57ea533253e19eea594d9b6c06e8d26
without adjusting for Android accordingly
Change-Id: Ie6a2001ab13ecec959da9b57bb49e1bac76e8691
Project: help 64187c4328623fca6c00d2f5c9f659211ee18883
New Help: allow product version = "latest"
To enhance version migration, the most recent Help will be
named "latest" in the URL. Explicit last version X.Y will be
symbolic link to 'latest'. e.g. '6.0' -> 'latest'
*This will allow search engine to always index the same 'latest' URL
*External links always land in 'latest' pages.
Change-Id: I5ffa1d268f71b7ebe75d5d90c62bcd6304507602
Reviewed-on: https://gerrit.libreoffice.org/48848
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
just give up on it for fuzzing purposes
Change-Id: I8d91fa547d83bc2f28454812280b0a7054e05b62
Reviewed-on: https://gerrit.libreoffice.org/48835
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
but most of it is empty, so use a map instead
Change-Id: I92fe46939e5107926fd4b92167bbace63f0376d5
Reviewed-on: https://gerrit.libreoffice.org/48830
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
... based on ForceFocusAndToFront setting
Change-Id: Ic76faa082f433d5a0150e49c30d7eda3c6c24c5f
Reviewed-on: https://gerrit.libreoffice.org/48287
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
For one, this should make it more obvious what the magic constant USHRT_MAX
meant in the context of SwXMLTableContext::m_nWidth (and shows that it should
arguably have value SAL_MAX_UINT16, not USHRT_MAX).
For another, at least some Android builds are stuck with a broken C library that
defines USHRT_MAX to be of type unsigned int instead of signed int, which caused
various -Wsign-compare that are removed as a side effect.
Change-Id: If2676954f4e7159b0c0d3656b8bc0186f0771e10
Reviewed-on: https://gerrit.libreoffice.org/48661
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
...even if GetColumnCount()*MINLAY > USHRT_MAX could ever be true, in which case
it will now cap m_nWidth == USHRT_MAX.
(The original code didn't have the cast of GetColumnCount() to sal_Int32, then
7e7c8a51f05ef2c7c56b26e27328ad4b30655740 "#80552#: bug fixes for progress" added
a---presumably misplaced---C-style cast to the check (but not the assignment),
presumably to silence some signed-vs-unsigned warning.)
Change-Id: I2403ee3c5e8fe35ae2a7a7b7da9081a7fb7b59b1
Reviewed-on: https://gerrit.libreoffice.org/48654
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
the same fix as in 777bf677b38b2933. Move on, nothing to see here
Change-Id: I4b4fe9f87b25c6e04329c052c532ab4da5a30d75
Reviewed-on: https://gerrit.libreoffice.org/48820
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
Additionally, some lines are converted to a format of 110 characters
Change-Id: I7c3fe97f7ebb2530eeb62d0522cd8a8b1c7269e1
Reviewed-on: https://gerrit.libreoffice.org/47121
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
instead of "Set null" to explicit the fact that NULL is a keyword
Change-Id: Iab393ffc1af07d027ef93168c8de58f3635af11c
Reviewed-on: https://gerrit.libreoffice.org/48817
Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
Tested-by: Jenkins <ci@libreoffice.org>
