and avoid to retrieve list->begin and loop from the first element
Change-Id: I536b7a03c4033b02a7226d25f64764c10c28bdd0
Reviewed-on: https://gerrit.libreoffice.org/23126
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
all SfxFilter instances should now be hold inside of a std::shared_ptr.
This fixes a number of huge memory leaks in the test framework and
removes one huge source of memory issue in sfx2. SfxMedium contains a
pointer to the SfxFilter but does not own. Therefore it is required that
any SfxFilter belonging to a SfxMedium lives longer. However this seems
to work mostly by hoping that all SfxFilter instances are stored in a
global array. As we have seen with the tests this is not true (there are
also some cases inside of sd that seem to not follow that pattern as
well).
Change-Id: I12fd04a504cc4efc0a94967abd91c6fe2c6a8ce8
Reviewed-on: https://gerrit.libreoffice.org/23140
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
This is on my way of tracking a nasty memory leak in the change tracking
export code.
Change-Id: Ia46ef201f757dcd7f8764c3adf487de7fec58019
Reviewed-on: https://gerrit.libreoffice.org/23138
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Trying to satisfy loplugin:vclwidgets
sc/source/ui/inc/checklistmenu.hxx:199:28: error: OutputDevice subclass 'ScCheckListMenuWindow *' declared as a pointer member, should be wrapped in VclPtr [loplugin:vclwidgets]
ScCheckListMenuWindow* mpMenuWindow;
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
sc/source/ui/inc/checklistmenu.hxx:200:21: error: OutputDevice subclass 'ControlToPosMap' (aka 'unordered_map<vcl::Window *, size_t>') declared as a pointer member, should be wrapped in VclPtr [loplugin:vclwidgets]
ControlToPosMap maControlToPos;
~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
sc/source/ui/inc/checklistmenu.hxx:201:31: error: OutputDevice subclass 'std::vector<vcl::Window *>' declared as a pointer member, should be wrapped in VclPtr [loplugin:vclwidgets]
std::vector<vcl::Window*> maControls;
~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
Change-Id: I47ba432fd76899681ec0afd852c71b584629eeb9
I think
commit b2fb84499e1f75735e8fd90bc2eece3fed9af5f6
Author: Noel Grandin <noel@peralex.com>
Date: Mon Mar 7 14:19:22 2016 +0200
loplugin:write only fields
wrong wrong and took out this param along with the unused nIndex
beside it
Change-Id: Idc34e03b5d59d4b0017fff456b79c807fda2535f
It need not be due to no browser, but might also be e.g. a misspelled URL
like <htp://...>, see mail thread starting at
<http://listarchives.libreoffice.org/global/users/msg48090.html>
"[libreoffice-users] LO 5.1 Presentation can't find system browser on OSX
10.11."
Change-Id: I74ce7abb4e78d72ce9bf92424f66608c6780d2d3
