Noel Grandin
07da25064f
loplugin:constantparam in svl
...
Change-Id: If23e43beb401047825641817e09d7fdeb904f9d9
Reviewed-on: https://gerrit.libreoffice.org/23317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17 09:18:40 +00:00
Caolán McNamara
16fc620a22
too many configurations, too many platforms variants
...
Change-Id: I10a284b7c27b145b003ff01a77dc5c0d51f418ad
2016-03-17 09:02:20 +00:00
Noel Grandin
c23757066d
loplugin:constantparam in svx
...
Change-Id: I50fa7e4c7525d2f8107a11d8203957a47680eb80
Reviewed-on: https://gerrit.libreoffice.org/23303
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17 08:08:22 +00:00
Tor Lillqvist
f6a0ed20ba
Add a humble wish
...
Change-Id: Ie94f991acebda4e9074dba46d7bd65b433e0ce9b
2016-03-17 10:00:21 +02:00
Regina Henschel
f5d4a68834
tdf#98599 SVG: consider attributes of 'defs' element
...
The element 'defs' is not rendered, but children of it may
inherit the attributes. Therefore these has to be considered.
Change-Id: Ic6c21645439731db63f22adf5a5a4e2af2b74b71
Reviewed-on: https://gerrit.libreoffice.org/23309
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-17 07:43:05 +00:00
Douglas Mencken
be2c79c0fa
sdext.presenter: change OSL_TRACE -> SAL_INFO
...
Change-Id: I34724f28b96b00b8afe2b618d8d47561082987ca
Reviewed-on: https://gerrit.libreoffice.org/23311
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-17 07:40:41 +00:00
Miklos Vajna
8e0b08c305
tdf#98458 sw: make search in shape text optional
...
Instead of forcing it silently on everyone, add a new search option and
enable it only in case it's requested, as shape search is expensive for
large documents.
(Regression from commit bdc1824ea7acfa2fe9d71cdbe57882acce155577.)
Change-Id: Ibb6e76ad5c870dfd63b36429e16ef6d572f5f1fd
2016-03-17 08:34:21 +01:00
Chirag Manwani
5b3fee11f4
tdf#84938 Replaced #defined constants with enum class
...
Change-Id: I2078f15f03fbadab8a0253763d779c3eb7cdf448
Reviewed-on: https://gerrit.libreoffice.org/23302
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17 07:05:47 +00:00
Jochen Nitschke
a9a7768399
sc: remove unused member variable
...
aCmdArr is only set but never used
Change-Id: I90b2b954383122696190692890fa1fb6143486f4
Reviewed-on: https://gerrit.libreoffice.org/23306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17 07:04:20 +00:00
Douglas Mencken
f3704e5756
desktop.deployment • get rid of PLATFORM_ #define~s
...
it’s just damn double work to maintain
Change-Id: I1ea9f28024770460a575890333347cf8b8681e5c
Reviewed-on: https://gerrit.libreoffice.org/23315
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17 07:02:51 +00:00
Noel Grandin
8ca50d20c1
loplugin:constantparam in tools
...
Change-Id: I3774661799c074561c694515baba42a375d0a077
Reviewed-on: https://gerrit.libreoffice.org/23301
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17 06:09:42 +00:00
Martin Hosken
a976a19ca8
Fix bug in khmr linebreaking and update dictionary
...
Change-Id: I2b776925c2c95cb56ccd592d036823c26054e059
Reviewed-on: https://gerrit.libreoffice.org/23316
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2016-03-17 03:31:32 +00:00
Maxim Monastirsky
1caac28389
tdf#92049 NewMenuController: track icon theme changes too
...
Change-Id: I2f2c990b2cbacddf94bf74329d641d5a7e489773
2016-03-17 01:15:58 +02:00
Caolán McNamara
e7d405b74e
WaE: loplugin:nullptr
...
Change-Id: I279d0021e7cdfd7e2d73ec6542e9ba27f300606c
2016-03-16 20:52:39 +00:00
Tor Lillqvist
e3d0e8069e
tdf#97319: Give up on caching non-BMP glyphs
...
I can't figure out why successive non-BMP glyphs in the bugdoc get
drawn on top of each others. So bail out...
Change-Id: I9c6241916347ec31d616e5cbf00bf3b1869edba2
2016-03-16 19:31:33 +02:00
Michael Meeks
652e8a2b37
tdf#98607 - fix drag and drop regression.
...
regressed in: f2f1f52d8b84ac088496a4964d799bb84007fc45
Added belt and braces fix.
Thanks to Maxim for the bisect.
Change-Id: I5b263870d76f44ef8833b27f0d8d391210216459
Reviewed-on: https://gerrit.libreoffice.org/23307
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-16 17:17:50 +00:00
Armin Le Grand
d1d80806ba
tdf#98678 removed double for-loop
...
By error the for-loop was added twice, removed one
Change-Id: If098dae28857bd87a07bb828bab2c7330c5fd7f8
Reviewed-on: https://gerrit.libreoffice.org/23294
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-16 16:44:50 +00:00
Miklos Vajna
08dadbd90e
CppunitTest_xmlsecurity_signing: fix typo in testODFBroken()
...
On a system where the certificate can be validated, the expected result
is OK, not PARTIAL_OK (copy&paste problem from OOXML).
Change-Id: I1b52921498de24c9a14a780bf48b791ec1e0c706
2016-03-16 15:46:54 +01:00
Jan Holesovsky
2a5bb8f7d7
sc lok bccu#1519: Broadcast cell size changes, they affect the document size.
...
Change-Id: Icd42c0252c28a24ac9c6c535a146a2f3b3beda17
2016-03-16 15:41:43 +01:00
Caolán McNamara
7055a93318
coverity#1242658 Untrusted loop bound
...
Change-Id: Iae002c0f925772a56f56162b0e4ac63de2b50d10
2016-03-16 13:31:06 +00:00
Tor Lillqvist
6eb7cd38e3
loplugin:defaultparams
...
Change-Id: I6d973c5402317b99c1d0eed85d4bb1de83d35fe2
2016-03-16 14:45:08 +02:00
Noel Grandin
a607782cb6
more fixes for "loplugin:constantparam in unotools/"
...
Change-Id: I357164f80970958ead86cf9ff691fe6f6f73b0f1
2016-03-16 14:00:40 +02:00
Tor Lillqvist
54a679338e
Remove code that has been commented-out for long
...
Commented-out in a198aa60a9d346128043e3e65ae82bb8ff670272 in 2005.
Change-Id: Id174dae6632fa8d8e9845b06b916a8515cd6acf3
2016-03-16 13:39:06 +02:00
Noel Grandin
78f0d15893
loplugin:constantparam in xmloff/
...
Change-Id: I376f1d4ac65de584f9caa6ba8e25e43216374112
Reviewed-on: https://gerrit.libreoffice.org/23295
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16 11:35:38 +00:00
Noel Grandin
732476f2e3
fixes for "loplugin:constantparam in unotools/"
...
which only compiled because bool converts to char in C++, sigh.
Change-Id: I710bdd78bd93255635189da8e9751bff741a75a2
2016-03-16 13:21:56 +02:00
Noel Grandin
3d26445098
loplugin:constantfunction in ucbhelper
...
Change-Id: I80e00b5ac2621378801f89532ed88b377ef72b60
Reviewed-on: https://gerrit.libreoffice.org/23297
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16 10:46:03 +00:00
Caolán McNamara
125c845f40
attempt to address reported loplugin:vclwidgets warning
...
Change-Id: I6ccefa2d5d1c57cf9f1c4041d14c92d03ded1333
2016-03-16 10:35:41 +00:00
Noel Grandin
f958db475d
loplugin:constantparam in unotools/
...
Change-Id: I016cf96af3a93c8f2114657a7e59599f68446ddc
Reviewed-on: https://gerrit.libreoffice.org/23296
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16 10:27:43 +00:00
Samuel Mehrbrodt
e41d23abb0
tdf#84953 Only resize proportionally when dragging on a corner
...
Change-Id: Iec4eda867216575e058fa673788d9345da05c872
Reviewed-on: https://gerrit.libreoffice.org/23291
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-16 10:27:08 +00:00
Caolán McNamara
eca17faebd
ubsan: load of value 768, which is not a valid value for type
...
Change-Id: Ief0b70f19630d8d8cc925145848c7a2c8a2813ad
2016-03-16 10:25:41 +00:00
Caolán McNamara
c9be863a12
Resolves: tdf#98473 replace || with ‖ to avoid illegal gtk3 action names
...
again, was reverted by
commit 48c2e04bdb60429823cb8b12a14d954af544a2bf
Date: Mon Mar 14 22:10:23 2016 +0100
which I'm assuming was a merge error
Change-Id: Iad3c2149438822d1e8b1406e35372a3e2b50bfa3
2016-03-16 10:25:41 +00:00
Takeshi Abe
a57c44486a
Update URLs of Adobe Glyph List For New Fonts / Specification
...
Change-Id: I212a6167ce2c7b634d8ff47e9991fd36df7cd06a
2016-03-16 19:06:12 +09:00
Miklos Vajna
042f16a19e
vcl: fix loplugin:defaultparams
...
Change-Id: Ic947d1a4a341a778c88d1225b1a2ea66df697084
2016-03-16 10:53:50 +01:00
Caolán McNamara
e8826d814e
coverity#1355502 Dereference before null check
...
Change-Id: I2833454ca4afd9e11a6c0c4fb1386f0dbb0d13d8
2016-03-16 09:37:08 +00:00
Caolán McNamara
338b8bec48
coverity#1355503 Dereference before null check
...
Change-Id: Ie5791423546c15470d0e0aaeb80f8bc9c1c99eeb
2016-03-16 09:34:41 +00:00
Caolán McNamara
ba21f5fc6a
coverity#1355505 Uninitialized scalar field
...
Change-Id: I95d76b6c06d194b762ecd0534c51314744eb42ae
2016-03-16 09:32:41 +00:00
Caolán McNamara
8c249068fc
match types for legibility
...
Change-Id: Ifd84a9a9dc54772a56d3bf0e345782f7f77562bd
2016-03-16 09:29:52 +00:00
Caolán McNamara
5873b3643d
coverity#1356337 Resource leak
...
Change-Id: Id00ee8abd5f22bf0594ad41e3922222872d6c5ca
2016-03-16 09:29:52 +00:00
Caolán McNamara
95548f1615
coverity#1356338 inline markup didn't work
...
Change-Id: I8b1bb924afe13a034125c892205aae8167a10bd1
2016-03-16 09:29:52 +00:00
Caolán McNamara
86f504ee01
Related: tdf#98637 make this a tractable problem
...
This is just too hard, it would all be much easier if the ActionGroup existed
right from the start of the entire process. So smuggle in to the ctor the
toplevel frame that the menubar will be inserted into so we can use its
ActionGroup from the start.
That would suggest that we could then just keep the hierarchy in sync as it is
created rather than finding opportune moments to update /generate it.
Change-Id: I550f94a994210423ab9cea1986e643056cb5bd29
Reviewed-on: https://gerrit.libreoffice.org/23287
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-16 09:27:36 +00:00
Caolán McNamara
84aee1ae9d
coverity#1356339 Uninitialized pointer field
...
Change-Id: I3a99a0bcfb58c72b444c7a5596f4bfa53b306025
2016-03-16 09:11:12 +00:00
Caolán McNamara
1c122eb61d
Undo my poor mans recursion control in favour of the real thing
...
i.e. undo
commit ea441294e15b23f703f139055e9a18287745ca23
Author: Caolán McNamara <caolanm@redhat.com>
Date: Thu Apr 2 13:19:32 2015 +0100
avoid endless recursion in fdo84763-2.ods
and rely on
commit 29ee431c1cf859c3d5a5041cff5cb04b89db27a0
Author: Eike Rathke <erack@redhat.com>
Date: Tue Mar 15 17:39:03 2016 +0100
Resolves: tdf#93196 add RecursionCounter guard also to InterpretFormulaGroup()
... same as for ScFormulaCell::InterpretTail()
Change-Id: I85dc6e37d987ce9fe41a9e4c337e02a1cec4f0c8
2016-03-16 09:11:12 +00:00
Miklos Vajna
f87317c326
SwFrame::Retouche() -> Retouch() rename
...
Change-Id: I2a93358c64f831a3dd014942c900b7ae46a3836f
Reviewed-on: https://gerrit.libreoffice.org/23290
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-03-16 08:42:51 +00:00
Noel Grandin
f0f973da85
loplugin:constantparams in vcl/
...
also some improvements to the plugin
Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871
Reviewed-on: https://gerrit.libreoffice.org/23289
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16 08:42:37 +00:00
Tor Lillqvist
6eb91bdf75
loplugin:implicitboolconversion
...
Change-Id: I9edc0d2e478f83e39e93e70e6c05c77b0125aad0
2016-03-16 09:15:00 +02:00
Jochen Nitschke
f53fc22f04
sc: replace define with helper
...
Change-Id: I79915d5449e64c9eb46ff91ce3279ce27af12fec
Reviewed-on: https://gerrit.libreoffice.org/23257
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16 06:54:43 +00:00
Christian Lohmaier
53f645a9c9
fix windows build
...
34a7b51ea482d4487d4fb8e61cde18aa1ff9b8ff (for 5-1) auto → size_t made
32bit happy, but win64bit still failed with:
error C2784: ´_Ty std::min(std::initializer_list<_Elem>,_Pr)´ : could
not deduce template argument for ´std::initializer_list<_Elem>´ from
´__int64´
Change-Id: Ib44840f692f1bcdea90decfe443c6eb72806002a
2016-03-15 23:38:33 +01:00
Caolán McNamara
367f13fd58
crashtesting: Related tdf#91291 assert on indexing into empty string
...
Change-Id: I157389607d2a54349c54ebdb3e283deee126ca67
2016-03-15 21:07:01 +00:00
Chris Sherlock
89e0a84a82
sd: add license boilerplate
...
Change-Id: Iab97ad48b44d2c1bc8c6712dfe9e3d52a974f0a0
2016-03-16 06:02:01 +11:00
Samuel Mehrbrodt
4af2f26a95
tdf#97919 Also resize ole objects proportionally by default
...
Change-Id: I1c3b13aa4cb0127451353f20179f39b6eebe12ec
Reviewed-on: https://gerrit.libreoffice.org/23284
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-15 18:25:28 +00:00