This reverts commit 3ed9bba283a6a67864c0928186e277240be0d9ba. osl_Pos_Absolut
(include/osl/file.h) is part of the stable URE interface; it must not be changed.
Change-Id: I1f49923a9351e4be5aee39b10720d38b424feb9b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110435
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
80b7949016fbc6addd54bf9f6cf300c756fd0f8a enabled a bunch of previously
disabled checks, but on m1 macs osl_File::open::open_004 fails the
assert, because it doesn't fail with E_ACCES, but with E_ROFS.
(probably nothing to do with apple silicon, but rather because of Big
Sur and using apfs as filesystem)
Change-Id: Ibd2168ba5fb9d859ea339713099c9bc8a799fcc7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110431
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
The "|" is used as a separator there and it looks like it has never been
allowed in a URI, even in a fragment.
Change-Id: I1e4b9e12f5409f93c2291494fd4350431f68fe2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110388
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
It is a bit awkward that the selection is a tree item so this
changes it to be a toogle button, which when enabled, shows the
object in the right-hand side object inspector and disables the
left-hand side DOM object tree view in this case.
Change-Id: I4ebd03a39c72109f0545206354aa7dbe85e9649a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110119
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
of the users profile. make CppunitTest_desktop_lib fails for me because
I have a real profile which is autodetected but which gives a
SEC_ERROR_TOKEN_NOT_LOGGED_IN failure if used. The intent here is
clearly to avoid doing an autodetect.
before
commit 02399a217b94660efc874e589fc4140bbbabd884
Date: Mon Dec 31 12:22:39 2018 +0100
for tests MOZILLA_CERTIFICATE_FOLDER should be set to empty not 0
"0" was explicitly used
Change-Id: I0110d8e2c4c378dde75a1c8da3757bfa29f6c1b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110424
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Take the new doc setting into account and if it's true, then undo the
existing "increase left margin" logic, and do an "increase top margin"
one instead.
Change-Id: I358a34790a52e2720ec23e6841d56e66858e28b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110454
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
At least in my local Linux build, UITest_writer_tests7
UITEST_TEST_NAME=tdf139301.tdf139301.test_tdf139301, as introduced with
183c06fc02a50fb117bb6162e4d6e56cdd34fad1 "tdf#139301 fix OOXML-compatible preset
dash styles", consistently fails (for whatever reason) with
> FAIL: test_tdf139301 (tdf139301.tdf139301)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "~/lo/core/sw/qa/uitest/writer_tests7/tdf139301.py", line 40, in test_tdf139301
> self.assertEqual(style, styles[i])
> AssertionError: 'Dash Dot Dot' != 'Dot'
> - Dash Dot Dot
> + Dot
and then would hang in tearDown (presumably because the
self.ui_test.close_dialog_through_button(xOKBtn)
line would be skipped due to the AssertionError being thrown).
While this commit does not fix the failing test, it at least makes it no longer
hang.
Change-Id: I80fd88d1668b162166a971f1a7bef1b5f965c421
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110452
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
So we don't have to expose the raw search handle in the public header
anymore.
Change-Id: I410314424e5a1d3a977c8e3de6f500f7c9a0a332
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110426
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Update helpcontent2 from branch 'master'
to 5c476f480cddb8a6dd7b0020564953b22fe0660a
- tdf#140096 add Ctrl+F6 and Ctrl+Shift+F10 to shortcut keys
also clarify meaning of "subwindow" for F6
Change-Id: I050fe63a4a927a95689188234d2174cae3e40a6d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110298
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Tested-by: Jenkins
Any operator >>= does not guarantee initialization.
(code was introduced with <https://git.libreoffice.org/core/+/11e52fe2979b0947814a49b9c17ec373795cbf8e%5E!/> "introduce Degree100 strong_int type")
.../libreoffice/oox/source/export/drawingml.cxx: In member function ‘void oox::drawingml::DrawingML::WriteShapeTransformation(const com::sun:⭐:uno::Reference<com::sun:⭐:drawing::XShape>&, sal_Int32, bool, bool, bool, bool, bool)’:
...s/libreoffice/oox/source/export/drawingml.cxx:1790:79: warning: ‘nTmp’ may be used uninitialized in this function [-Wmaybe-uninitialized]
1790 | nCameraRotation = NormAngle36000(Degree100(nTmp / -600));
Change-Id: I93bee48bc050c29d831e78afcf62aef154c72fc5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110341
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
This is a follow-up to 7ab349296dac79dad3fec09f60348efcbb9ea17e.
The first problem was that tables that contain protected cells refused
to be deleted, which caused an infinite loop in
SwXTextRange::DeleteAndInsert().
This also affected SwXTextTable::dispose(), and DDE tables.
Fix this by forcibly deleting even protected cells from UNO APIs;
protection is an UI feature.
The second problem was that pasting the table SwFEShell::Paste() would
set up aCpyPam so that it selects from the start node of the table to
the last text node in the table, excluding the table cell and table end
nodes, which caused:
DocumentContentOperationsManager.cxx:3548: An insufficient number of nodes were copied!
Fix this by setting up aCpyPam over the entire body section of the
clipboard document.
Change-Id: I8c6caee5e75260dff79f106efc11f9669feddc0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110411
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Do this per-doc, rather than per-page-desc, because Word doesn't support
it per-section, so we would just create interop problems for ourselves
with supporting it per-page-desc.
Change-Id: Id3c6aac7323deb8d27bab08675ff623f90a63cd9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110423
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Here it passed "make build-nocheck" on Linux
Change-Id: I1f6ea440e54f87a90abb1b6e9983443764516e06
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110373
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Dante DM <dante19031999@gmail.com>
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Tested-by: Jenkins
Also update the preview widget and hide the new UI in Calc/Impress.
Change-Id: Ic5c0ba100f6e886651d83c04961e9f0566a4202c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110414
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
* Update helpcontent2 from branch 'master'
to 57222f5d4710b0a2fc43e4273ccad8c952dc6510
- Revert "Create Help page for the SF_String service"
This reverts commit a6f6fa2254ced7120ac0fb0075b4fd5195c334af.
Reason for revert: was not yet ready
Change-Id: Ibc95e08e2cb2a1f2220b503f3ab472518f98a047
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110365
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
* Update helpcontent2 from branch 'master'
to a6f6fa2254ced7120ac0fb0075b4fd5195c334af
- Create Help page for the SF_String service
SF_Array:
- Adds a <variable> tag
SF_Document:
- Fixes localization issues pointed out by translators on WebLate
Change-Id: Ifa0a3c7665796ea2e5464dc3f2bd9508b3f7847c
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110360
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Mouse wheel emits delta > 1 so if we see only one row
but delta is 3 we skip then 2 rows.
Change-Id: I136788d38a189c061a55cba12eef05c7a4733820
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110379
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
If IconView has only one row and there is no space for
default 100px height - scale down the entries.
Change-Id: I8b310f1274ba91872af0849e36e3a87e775c98b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110381
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
When we have only one row the page size for scrollbar is
set to 1 so delta is always 1. This prevents from invalidation
when scrolling up using a scrollbar button and results in artifacts
on the screen.
Change-Id: I92ed0133450ba459e19b575d8c52d059464b1e33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110377
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
which is a clone of cppu::BaseMutex
Change-Id: I6db266a4b67ac2d8b6c389cd27bf5bc7b9ecc754
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110402
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Regression from 3347d71b23595919e167bd49932675e77cbbdbbb
(sw: fix text position at textbox alignment) has been
fixed by this commit. Hopefully there won't not be newer
regressions.
Please note the crash only occur on GTK vcl backend so,
the py-test only with that case will show the problem.
In the other case there were no crash.
Change-Id: I3280547a6195e240e5b33e0d0931fb60d4d19fff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109669
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Custom shapes lost their contour setting, e.g. the
text was wrapped around the bounding box of a diamond
instead of the shape.
Change-Id: Ic1e276b8957751aad95cc2624e9f54dcb853ddad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108930
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
Before when the shape of the textbox moved, the anchor
and the position synched. However if the new position
of the shape required new anchor position, that was not
handled. In addition after positioning and new anchor
position the sync is necessary again, because anchor
moving can change the calculated position values and
that can change the anchor etc...
The OOXMLImport test modification was necessary because
a test failed during Jenkins tests however there was
no difference between the test document before and after the
fix. In addition I can not reproduce the fail of the test
in my local repository, and only the Linux- and Windows
builds showed the problem.
Solved also tdf#138951, tdf#139686 and tdf#139092.
Change-Id: Ibdfff89db01d75aeae74948e2ea41ce5a613b6fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109365
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
- separate error message vs corresponding message for dialogs
- more precision on form naming: form document.form name
- add new error message in SF_Exception and SF_Root messages lists
- add new message in po files
Change-Id: I1f7f2dc7b5627d12a8c5ecf238e6cbd3aa1505fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110380
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
we end up trying to process a timer message, but from inside
the vcl de-init function, which means the timer stuff has already
been de-initialised.
Change-Id: I94703219754f1ccabd3065fc5ea437f39264197b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110397
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
