Commit Graph

51 Commits

Author SHA1 Message Date
Noel Grandin
0323253a7c remove some manual ref-counting
triggered when I noticed a class doing acquire() in the
constructor and then release() in the destructor.

found mostly by
    git grep -n -B5 -e '->release()'

Change-Id: I96e43a3d30ffd9ae9a34275f24cd914d8f7b026f
Reviewed-on: https://gerrit.libreoffice.org/25806
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06 07:01:34 +00:00
Noel Grandin
95d20a3799 Revert "remove some manual ref-counting"
until I have a better understanding of the UNO reference
counting.

This reverts commit 111de438ea.
2016-05-24 11:02:42 +02:00
Noel Grandin
111de438ea remove some manual ref-counting
triggered when I noticed a class doing acquire() in the constructor and
then release() in the destructor.

found mostly by
   git grep -n -B5 -e '->release()'

Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f
Reviewed-on: https://gerrit.libreoffice.org/25363
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24 06:54:06 +00:00
Noel Grandin
337f517af6 loplugin:unuseddefaultparams comphelper
Change-Id: I78280a13fc0d82fc87041b5dad0c3f2f7d462652
Reviewed-on: https://gerrit.libreoffice.org/22853
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-03 12:06:57 +00:00
Andrea Gelmini
597e694e7e Fix typos
Change-Id: I90b04b8eda6fc3d530c9db72052720cbe9de0343
Reviewed-on: https://gerrit.libreoffice.org/21197
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-01-07 12:29:04 +00:00
Andrzej Hunt
9d0b06e9f7 new loplugin rangedforcopy - use reference in range based for
Inspired by 6e6ae98037

Change-Id: Ia0f264d3a6bbf076aa5080e3398683e50bc6ef01
Reviewed-on: https://gerrit.libreoffice.org/20190
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-05 11:06:52 +00:00
Stephan Bergmann
fb4ce444c2 loplugin:nullptr (automatic rewrite)
Change-Id: Ibd0e6ae5e3243464b2484a009f2b4781bdaac471
2015-11-10 10:31:19 +01:00
Noel Grandin
e209d115d4 remove old standalone Sun bug numbers
Sun bug numbers without any accompanying text are completely useless.

Fixed with
   git grep -lP '//\s*#\d+#\s*$'
       | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print'
And then hand-checking the result to restore places where it deleted code.
And then some more grepping and hand-editing to kill the others.

Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29
Reviewed-on: https://gerrit.libreoffice.org/19023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01 06:57:19 +00:00
Daniel Robertson
96fa0df15b comphelper: replace for_each with range-based for
Replace complex uses of ::std::for_each with a range-based for-loop.

Change-Id: I57d3d2e830e7700b793e1836777cbe72504c6825
Reviewed-on: https://gerrit.libreoffice.org/18817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-24 16:23:34 +00:00
Noel Grandin
4f87e9da41 loplugin: defaultparams
Change-Id: I29ef505ee77965df33677f8051ec39398ef0c74e
2015-08-11 09:48:17 +02:00
Andrea Gelmini
aade27554d Fix typos
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-22 12:36:21 +00:00
Caolán McNamara
a941df0f89 cppcheck: noExplicitConstructor
Change-Id: Ie2ae923ad4c1a66e779711de6ff05328ef144dac
2015-06-08 17:35:00 +01:00
Andrea Gelmini
5b1337f7b2 tdf#62475: partial handmade fixes
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4
Reviewed-on: https://gerrit.libreoffice.org/15712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-15 17:55:15 +00:00
Stephan Bergmann
da36fc8c95 No more need for PartialWeakComponentImplHelper here
...since 70626249cd "API CHANGE a11y unpublishing
and add/removeListener rename."

Change-Id: I89d81326d97712abcac94c3436a13905954c55cf
2015-04-21 22:48:02 +02:00
Noel Grandin
5139fad429 loplugin: cstylecast
Change-Id: I84873c9f84651dc8a1337f37c63020b461314e1b
2014-09-22 12:24:23 +02:00
Stephan Bergmann
9ea1bb2c1d loplugin:staticcall
Change-Id: Iae319f84028bb2468ca663afe9a82eb3cf46ae37
2014-06-13 17:54:23 +02:00
Julien Nabet
b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
2014-05-22 23:21:18 +02:00
Thomas Arnhold
6d2de44a54 fix-includes.pl: comphelper
Change-Id: I0b4cd8320881b2b1f7984c86e58915217bcd0d5f
2014-05-11 01:55:37 +02:00
Stephan Bergmann
36784563ed OAccessibleContextWrapperHelper does not implement XAccessibleContext
...but rather some (non-virtual) base functionality for use in derived classes
(that do implement XAccessibleContext)

Change-Id: Idb0023906108db22bb9696245f07b9a4c053a0d1
2014-03-14 14:29:24 +01:00
Alexander Wilms
a67c2a12bc Remove visual noise from comphelper
Change-Id: I7e5512b43240beee05404cff9d49a87d0217ea89
Reviewed-on: https://gerrit.libreoffice.org/8242
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 06:42:45 -06:00
Stephan Bergmann
5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Alexander Wilms
0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Stephan Bergmann
05f742d28b comphelper: sal_Bool -> bool
Change-Id: I6fc331ae0706f4bb193543011c8d4ae0a385fcc0
2014-02-17 17:55:19 +01:00
Luboš Luňák
1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Stephan Bergmann
048e64e71f Drop redundant typedef
Change-Id: I13f1858babb1fb2b4120bcbf0e2e04a2a1f4bf88
2013-03-28 15:35:43 +01:00
Thomas Arnhold
919e277466 loplugin: unused variables and commented code
Change-Id: I01f1f1d112767b576d7cfc6e25fe95385de2c0cf
2013-03-03 11:48:02 +01:00
Thorsten Behrens
70626249cd API CHANGE a11y unpublishing and add/removeListener rename.
The a11y API has never really been picked up by tools vendors, let's
not tie ourselves up here for no good reason.

This unpublishes all css::accessibility, and dependend API.

With that, we can change the rather unfortunately-named add/
removeEventListener to be add/removeAccessibleEventListener, thus
not conflicting with the XComponent methods of the same name.

Change-Id: I595598c3a8e46415f80b2780f333333174865fe4
2012-11-29 16:58:16 +01:00
Noel Grandin
7470cc532f fdo#46808, Adapt reflection::ProxyFactory UNO service to new style
The service is deprecated, but we still have a handful of in-tree
users, and converting it lets me thread XComponentContext through
a bunch of classes.

Change-Id: Iffdfe537ada6b9e4a89f9b3c8dd82ca85f4bfaba
2012-11-28 13:06:18 +01:00
Norbert Thiebaud
750fc20611 replace remaining InterlockedCount() with inlined version
Change-Id: Ifcfa48fc87f905a91470a5b0fd597b02f220784c
Reviewed-on: https://gerrit.libreoffice.org/671
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-25 01:55:38 +00:00
Michael Meeks
2005a34318 re-base on ALv2 code. 2012-06-29 15:51:49 +01:00
Norbert Thiebaud
b8ee1f9b5f remove include of pch header in comphelper 2011-11-27 13:00:14 -06:00
Júlio Hoffimann
52f1b2b471 left arrow comments removed // <-- 2011-04-22 14:41:19 +02:00
Júlio Hoffimann
4fc170d3e8 all bogus comments removed by regular expressions 2011-04-15 10:39:52 +02:00
Thomas Arnhold
3d874bdf40 Move OSL_ENSURE(sal_False,...) to OSL_FAIL(...) 2011-03-19 14:11:09 +01:00
Thomas Arnhold
d86e9a3906 Move OSL_ENSURE(false,...) to OSL_FAIL(...) 2011-03-12 14:19:17 +01:00
Sebastian Spaeth
4905a19032 Add vim/emacs modelines to all source files
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-14 17:02:15 +02:00
Jens-Heiner Rechtien
8764506704 changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Rüdiger Timm
6325950165 INTEGRATION: CWS changefileheader (1.14.118); FILE MERGED
2008/04/01 12:26:29 thb 1.14.118.2: #i85898# Stripping all external header guards
2008/03/31 12:19:32 rt 1.14.118.1: #i87441# Change license header to LPGL v3.
2008-04-11 10:05:31 +00:00
Oliver Bolte
74302e5d10 INTEGRATION: CWS pj73 (1.13.48); FILE MERGED
2007/02/24 16:33:47 pjanik 1.13.48.1: #i74838#: Initialize variable to prevent warnings.
2007-03-07 12:13:24 +00:00
Oliver Bolte
65fa970fca INTEGRATION: CWS pchfix02 (1.12.36); FILE MERGED
2006/09/01 17:19:40 kaib 1.12.36.1: #i68856# Added header markers and pch files
2006-09-17 16:09:16 +00:00
Jens-Heiner Rechtien
fcf09aabd5 INTEGRATION: CWS warnings01 (1.8.184); FILE MERGED
2006/05/23 22:37:09 sb 1.8.184.4: RESYNC: (1.9-1.11); FILE MERGED
2005/09/23 03:16:01 sb 1.8.184.3: RESYNC: (1.8-1.9); FILE MERGED
2005/09/08 13:16:51 sb 1.8.184.2: #i53898# Made code warning-free.
2005/09/01 13:59:58 sb 1.8.184.1: #i53898# Made code warning-free.
2006-06-19 21:47:09 +00:00
Jens-Heiner Rechtien
6ef1846e21 INTEGRATION: CWS pb13 (1.9.54); FILE MERGED
2006/03/21 10:09:31 pb 1.9.54.1: fix: #130798# translateAccessibleEvent(): handle TEXT_SELECTION_CHANGED
2006-05-08 13:56:34 +00:00
Rüdiger Timm
557add5cf5 INTEGRATION: CWS atkbridge (1.8.156); FILE MERGED
2006/03/01 12:12:20 obr 1.8.156.3: #i47890# removed debug output
2005/09/21 05:53:29 obr 1.8.156.2: RESYNC: (1.8-1.9); FILE MERGED
2005/04/21 14:56:51 mmeeks 1.8.156.1: Issue number: 47890
Submitted by: mmeeks

Don't crash if we can't return an accessible context
2006-05-05 09:48:48 +00:00
Rüdiger Timm
7114a64aa3 INTEGRATION: CWS ooo19126 (1.8.188); FILE MERGED
2005/09/05 15:23:58 rt 1.8.188.1: #i54170# Change license header: remove SISSL
2005-09-08 01:48:04 +00:00
Jens-Heiner Rechtien
8e6d0c1b27 INTEGRATION: CWS tbe9 (1.7.52); FILE MERGED
2003/11/19 12:03:26 tbe 1.7.52.1: #111089# return the proxy XAccessible instead of the inner XAccessible
2004-02-04 10:26:40 +00:00
Vladimir Glazounov
120a426f08 INTEGRATION: CWS dba05 (1.3.4); FILE MERGED
2003/05/14 15:09:29 fs 1.3.4.6: #109014# when multilexing events, care for proper call order at AccessibleChildManager
2003/05/13 10:52:08 oj 1.3.4.5: accessible type changes
2003/05/13 10:50:28 oj 1.3.4.4: accessible type changes
2003/05/13 10:39:45 oj 1.3.4.3: access state type name corrected
2003/05/13 08:17:55 oj 1.3.4.2: RESYNC: (1.3-1.6); FILE MERGED
2003/05/07 11:16:17 fs 1.3.4.1: #109014#:
- classes related to proxy aggregation moved to separate file (proxyaggregation.cxx)
- class hierarchy split up: introduced additional OAccessibleContextWrapperHelper class
  which provides the ContextWrapper functionality, but does not have refcounting and XComponent support
- AccessibleChildrenManager is _not_ disposing it's children anymore, but only the XAccessibleContexts
  as provided by these children
2003-05-19 11:57:23 +00:00
Rüdiger Timm
ee51455e83 #100000# Accessibility not in drafts any more. 2003-04-25 09:59:00 +00:00
Vladimir Glazounov
94fff11b1d INTEGRATION: CWS uaa02 (1.2.8); FILE MERGED
2003/04/17 17:16:07 mt 1.2.8.3: RESYNC: (1.2-1.3); FILE MERGED
2003/04/11 15:39:16 mt 1.2.8.2: #108656# Moved accessibility from drafts to final
2003/04/10 11:59:42 mt 1.2.8.1: #108656# Moved Accessibility module from drafts to final
2003-04-24 16:28:02 +00:00
Jens-Heiner Rechtien
f7ea887888 INTEGRATION: CWS calc07 (1.2.12); FILE MERGED
2003/04/17 12:53:00 sab 1.2.12.2: RESYNC: (1.2-1.3); FILE MERGED
2003/04/17 10:29:37 fs 1.2.12.1: #108986# AccessibleWrapper has new dispose handling / AccessibleWrapper remembers it's context weak
2003-04-23 16:24:56 +00:00
Vladimir Glazounov
698c61d1c8 INTEGRATION: CWS dbgmacros1 (1.2.6); FILE MERGED
2003/04/09 10:18:19 kso 1.2.6.1: #108413# - debug macro unification.
2003-04-15 15:45:33 +00:00