Commit Graph

399585 Commits

Author SHA1 Message Date
Justin Luth
c0baab9aa8 reset border should clear all borders
If no borders were originally defined, the reset button was failing
to clear the last-selected border line.

Eg. page border, click on two of the borders, then hit reset. One border
remains defined, and didn't reset to the starting value of non-visible.
Because one border was still "selected", it became visible again as
SelStyleHdl_Impl reinitialized.

Change-Id: I2d20ae1e02816d5b30fe126572b54e7083114fc3
Reviewed-on: https://gerrit.libreoffice.org/30365
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-10-28 18:58:49 +00:00
Stephan Bergmann
25df5f2ac7 loplugin:unnecessaryoverride
Change-Id: I70ba8d3b03c56a597785f109f0cb687bd936bc64
2016-10-28 19:48:44 +02:00
Miklos Vajna
5c33253daf xmlsecurity PDF verify: start using offsets from xref streams
This is needed (but not enough) to verify PDF 1.5 signatures. What's
missing next is support for object streams.

Change-Id: I5afec0a77839ffabe0aaa07e367064210535a1a9
2016-10-28 18:34:14 +02:00
Miklos Vajna
56cc352d82 xmlsecurity PDF verify: initial support of cross-reference streams
This adds support for cross-reference streams (which can be used instead
of plain-text cross-reference tables) + also one stream predictor.

The actual parsed data is still not used, though.

Change-Id: Ia806abd8a97636a1bd25dfdafea377b088800f00
2016-10-28 18:20:20 +02:00
Justin Luth
b41e7b817e tdf#63846 assign macros after VBA project fully loaded.
fixes regression caused by d4743045a0.

see the documentation for VbaMacroAttacherBase, which indicates that
the macros are to be attached after all objects are finished loading.

Made attachMacros() public so it could be called separately since so
many things are inter-dependent in the logic flow.

Change-Id: I11f7f4a1a75d6f77a97e12e3359d6ea8a995f518
Reviewed-on: https://gerrit.libreoffice.org/30337
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-28 16:12:27 +00:00
Zdeněk Crhonek
eef81dd68f add MAX test case
Change-Id: Ie32504b84e227cc3f33d89ec46bca1835e433844
Reviewed-on: https://gerrit.libreoffice.org/30352
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-10-28 16:08:59 +00:00
Stephan Bergmann
1ec08fe00b loplugin:unnecessaryoverride
Change-Id: Ib75f2c8c06c6219aa0f2a8b2b29d19fb95e09527
2016-10-28 18:02:32 +02:00
Tamás Zolnai
b927c1f4b3 tdf#103544: DOCX exp.: Image loss when have a frame anchored to the same para.
Regression from:
83d51e5e52

Partly revert the commit causes this regression.
I checked the related bugs (tdf#78590,tdf#80748)
intended to be fixed by this commit and reverting
this part does not bring back the corruption.
I guess something changed in frames' and text boxes'
import in the meantime, because this MergeMarks::IGNORE
is useless now.

Change-Id: If17776e8628561961c7ce2a2994e3fc609f75639
Reviewed-on: https://gerrit.libreoffice.org/30351
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-10-28 14:10:41 +00:00
Noel Grandin
8a22bc93e0 update unnecessaryoverride plugin to find pure forwarding methods
which can be replaced with using declarations.

Is there a more efficient way to code the search? Seems to slow the
build down a little.

Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f
Reviewed-on: https://gerrit.libreoffice.org/30157
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28 12:56:17 +00:00
Rohan Kumar
99fbcffa3d tdf#89329: use unique_ptr for pImpl in fpicker/
Change-Id: I4a5db5ceafe509bffc32a8800ab3d678f41244f7
Reviewed-on: https://gerrit.libreoffice.org/30309
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28 12:26:09 +00:00
Caolán McNamara
03c7cfb6a6 note yet another color selector
Change-Id: I781da1ec218148dcb723db04dfe6ef3eacffe293
2016-10-28 13:15:34 +01:00
Caolán McNamara
d3e33f7ba8 ImplInitMenuButtonData can be folded into ctor now
because theres no ResId loader anymore

Change-Id: Id90786d710fe75e47c162fd00ad7fd672b9cee30
2016-10-28 13:03:45 +01:00
Caolán McNamara
624ff6633c only draw menubutton separator when two sides do something different
Change-Id: If6e3b72eacef2325f9f30770bbed32c627bc035c
2016-10-28 12:37:05 +01:00
Caolán McNamara
b1271fc9ba the case without a separator is as a Toolbox item
Change-Id: I948a63ab9741aa89738b5e44b0ec0e078d0faaa0
2016-10-28 12:26:12 +01:00
Caolán McNamara
94af3da7e1 rename and explain the MENUBUTTON_MENUMODE_TIMED stuff
Change-Id: Ifc6ddfb0cc249e537c01f28bab84b42c6b1577d9
2016-10-28 12:22:52 +01:00
Caolán McNamara
6dc8f25ecf these need to be VclPtrs
Change-Id: I83616728289e398c97e50f33b5dd1de404deaa27
2016-10-28 10:56:20 +01:00
Caolán McNamara
ec06f95d91 fix leak
Change-Id: I5bc8efa8a9de6d7a2be99f6c816e3dfca4f2b390
2016-10-28 10:56:20 +01:00
Caolán McNamara
cd3edd369b can do this in one step
Change-Id: Iab4798b34018a272a68d3d1a206dfbeef6ff19ca
2016-10-28 10:56:20 +01:00
Caolán McNamara
77d5d9f9af these usings are unnecessary
Change-Id: Ieeb753b700631958ad101354406b13863b3bab03
2016-10-28 10:56:20 +01:00
Stephan Bergmann
36f637f7f2 tdf#103507 quickfix: Automatic selection of Oracle Java runtime on Windows
...which had been broken since 5e9a2e9b0f "Check
each potential JRE location only once", as jfw_findAndSelectJRE calls
jfw_plugin_getAllJavaInfos on each vendor in turn, but that now only operates on
any items newly added by addAllJREInfos, so the first call to
jfw_plugin_getAllJavaInfos (with sVendor being "Sun Microsystems Inc."
unsuccesfully operated on all items, and the next call (with sVendor being
"Oracle Corporation") didn't see any further items to operate on.

So the quickfix (at least for any Java runtimes by Oracle) is to reorder the
vendors in javavendors_wnt.xml.  The proper fix will be to reorder the code so
it obtains the list of all Java runtimes only once, and then matches that list
against the known vendors.

(Other plaforms appear not to be affected by this issue.  Some
jvmfwk/distributions/OpenOfficeorg/javavendors_*.xml already sort Oracle first,
anyway.  And e.g. on Linux, jfw_findAndSelectJRE typically already succeeds with
calling jfw_plugin_getJavaInfosFromPath and so doesn't reach the problematic
code.

Change-Id: Ied571ae1d4745d53ce0c8697d0f1b268e1aac407
2016-10-28 11:17:10 +02:00
Miklos Vajna
ddb4600cd0 sd: fix loplugin:cppunitassertequals warnings
Change-Id: Id2dc5762668b7c3f78f0a0a1ede97d4ac63fab5d
2016-10-28 11:14:07 +02:00
Caolán McNamara
807151aa13 coverity#1371275 Missing move assignment operator
Change-Id: I6c47c797d2654506bdc95c35b2558ce812f4070d
2016-10-28 10:09:32 +01:00
Caolán McNamara
5aa43c380a coverity#1371262 Missing move assignment operator
Change-Id: Ibb430a683f818add50facc23ac2893b558bff70c
2016-10-28 10:09:32 +01:00
Caolán McNamara
117fc49c97 ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivatives
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2
Reviewed-on: https://gerrit.libreoffice.org/30344
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-28 09:08:50 +00:00
Khaled Hosny
8f0f5e0c70 tdf#103514: Always ignore bitmap fonts on Windows
We should never see any bitmap fonts now, so all the Courier stuff can
go away.

Since we never list the bitmap fonts in the first place, the old code
for replacing some of them with scalable equivalents never kicks in. We
instead implement PreMatchFontSubstitution hook for the same effect.

Change-Id: I54f3c068bcd64554ed3498f4ba5b0f76bbd38589
Reviewed-on: https://gerrit.libreoffice.org/30345
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-10-28 08:40:20 +00:00
Ulrich Gemkow
7a2a29d0b8 tdf#98587 Inconsistency menu/shortcut for layer visibility
Changed author, patch was received by htietze.

Change-Id: I1962930c5c9c6eea4731a83147a7705d24c20b8e
Reviewed-on: https://gerrit.libreoffice.org/30322
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-28 08:28:38 +00:00
Noel Grandin
09cb920969 convert std::unique_ptr<VclAbstractDialog> to VclPtr
Change-Id: Ifdd2a0599efd701def02b4a4d2a1c489cb1b27fa
2016-10-28 09:12:27 +02:00
Noel Grandin
89687d651e loplugin:expandablemethods in sd
Change-Id: I87a537928bdf42285448bba7cb50c497f2637c3c
Reviewed-on: https://gerrit.libreoffice.org/30330
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28 07:08:47 +00:00
Noel Grandin
24360897c0 loplugin:expandablemethods in scaddins..scripting
Change-Id: I6a39184e526c9a41155565e798a7f1f2542985f2
Reviewed-on: https://gerrit.libreoffice.org/30331
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28 06:59:41 +00:00
Stephan Bergmann
c0b3531919 Use SAL_DLLPRIVATE instead of extra TUBES_DLLPRIVATE
Change-Id: I188bf325e6eb6db0250a58d9354860733950e887
2016-10-28 08:52:47 +02:00
Stephan Bergmann
226383e690 loplugin:reservedid
Change-Id: I49e0e53b4ff17170e8aa8247b5428b6f1209d93c
2016-10-28 08:52:47 +02:00
Stephan Bergmann
f479e6878e Move internal include files from include/tubes/ to tubes/source/
Change-Id: I2fa9334721c203d4d977f0638a9030e8e74efc06
2016-10-28 08:52:46 +02:00
Stephan Bergmann
97c28ad74f Various loplugin warnings in --enable-telepathy
Change-Id: I4c437491466c3029f2a9c93fb630c7b5a8d2ff21
2016-10-28 08:52:46 +02:00
Stephan Bergmann
0274bc0569 Missing dependency (--enable-telepathy)
Change-Id: I13578505fc0d5de164d0dacbbf31821ea79233ab
2016-10-28 08:52:45 +02:00
Stephan Bergmann
3b4a32972e Use OUString ctor instead of rtl_uString_newFromAscii
Change-Id: I84ea23c4de5c631fe7d0104944b0b8f0f13abb26
2016-10-28 08:52:45 +02:00
Stephan Bergmann
954699acbd cppu/source/uno/EnvDcp.c -> cppu/source/uno/EnvDcp.cxx
Change-Id: Ic02d217efef970a365a584f2558c41561e4c6e3d
2016-10-28 08:52:45 +02:00
Tor Lillqvist
e333d386ce Bin one more pointless TAG_ macro
Change-Id: I78e85923e2c5da366c0bec0812c8fe0240310b67
2016-10-28 08:40:01 +03:00
Tor Lillqvist
d111186383 Bin unnecessary TAG_ and ATTR_ macros and expand in-place
They just make grepping harder, and don't really avoid a risk of
mistyping. For instance, there were both TAG_TRANSFORM and
TAG_TRANSFORMS (with values "Transform" and "Transforms"), so if you
think you are likely to misspell "Transforms" as "Transform", you are
as likely to misspell TAG_TRANSFORMS as TAG_TRANSFORM. Typos affecting
generated XML should be catched by unit tests anyway.

Some of the (newer) code here is already in this style, using string
literals directly for tags and attributes, so this change just makes
the style more uniform.

I did not touch the macros that have long URIs as value. For them
there is some usefulness in having the shorter macros in the
code. (But the names of the ALGO_* macros are not consistently
constructed from the URIs.)

Change-Id: I9130395f45fafc13fb2a6ac47e98177647e27cf9
2016-10-28 08:27:43 +03:00
Adolfo Jayme Barrientos
c55cc87280 Updated core
Project: help  005b4a65cdb91fe7566207b9e4c0b4125bf0e133

tdf#103540 Explicitly say the button affects all levels

Props to Regina.

Change-Id: I99d0bc807b1e777e0920bcfbab91f15a408c2a4a
2016-10-28 04:12:00 +00:00
Maxim Monastirsky
eb07ae8fc5 Don't crash under gen
In gtk there is apparently GtkSalMenu which increases
the refcount.

Change-Id: I5c52c7b40d0a854e0007362a32a55f0ffed668c1
2016-10-28 01:22:11 +03:00
Maxim Monastirsky
03d6174919 Reduce scope
Change-Id: I06695b310d016751ec80f1aacbba8567a70088a5
2016-10-28 01:21:29 +03:00
Maxim Monastirsky
89c23b4aae Sub menus no longer need manual disposing
after:

commit ee79a2dd7e
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Fri Jul 29 14:33:22 2016 +0100

    Resolves: tdf#101169 crash using column menu in base

Change-Id: I7c6e54dd5574c61cffd5884d1cf1b63075073001
Reviewed-on: https://gerrit.libreoffice.org/30343
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-10-27 22:11:07 +00:00
Caolán McNamara
798c107a1a coverity#1374310 Uncaught exception
Change-Id: Ie0ae4412d42d15e2c6c52a8cb0b7b3893405a16b
2016-10-27 21:47:03 +01:00
Caolán McNamara
f20a45808f coverity#1374311 Uncaught exception
Change-Id: I3f0e2fdfbf3c0517593ef87bc7bcbfe2ee693eef
2016-10-27 21:46:19 +01:00
Caolán McNamara
7580c5e5bd coverity#1374312 Uncaught exception
Change-Id: I901c5399cdc33d55c4d3bdfa7a566adc74340405
2016-10-27 21:45:06 +01:00
Caolán McNamara
3cc1a10c7b coverity#1374313 Uncaught exception
Change-Id: I9562deb23324f44b16735b0d376b4c37e20c58c1
2016-10-27 21:41:47 +01:00
Caolán McNamara
2d96f3a582 coverity#1374314 Uncaught exception
Change-Id: I07a39774a1372ea26e8d66376c27d3b98229892e
2016-10-27 21:39:32 +01:00
Caolán McNamara
db337150cd coverity#1374315 Uncaught exception
Change-Id: Id7a01c652d1d11675b87ee732ff40ddd76de6236
2016-10-27 21:37:42 +01:00
Caolán McNamara
6e14070332 coverity#1374316 Uncaught exception
Change-Id: I32f872d74f167604de006f1d77a9219a37011bfa
2016-10-27 21:34:57 +01:00
Caolán McNamara
d164f7e93e coverity#1374317 Uncaught exception
Change-Id: I37a7b2f12cec522e116ccf4b1aa550ad2cba14ea
2016-10-27 21:32:18 +01:00