Commit Graph

399585 Commits

Author SHA1 Message Date
Caolán McNamara
c484c353ef rework to avoid coverity#1371205 Missing move assignment operator
Change-Id: I117fa0891e8cd1bf339bded93a7ee19d799caf9f
2016-10-26 21:34:33 +01:00
Caolán McNamara
424c7fb6ca we don't need ree after the loop here
Change-Id: Ib288ab3a7abf8f45c1175c36dcd4349dc4ad019f
2016-10-26 21:24:01 +01:00
Michael Stahl
aa70294ffc normalize existing emacs/vim mode-lines in python files
Bunch of these were setting C++ or Make modes and icky tabs...

Also, reportedly Emacs can figure out to enable python-mode
automatically.

Change-Id: I50072488fb92cb4d27aa3f74f717a28ae3967543
2016-10-26 22:16:08 +02:00
Michael Stahl
22d0970e69 gbuild: missing emacs mode-lines
Change-Id: Id767a98be85a7f3f4abb28891d0a5cac2057b0e0
2016-10-26 22:16:08 +02:00
Caolán McNamara
ad5a6b4d58 fix leak in HeaderFooterTabPage seen examining coverity#1371205
In the case that the field data is not a SvxDateTimeField or SvxDateField
then the old "aFieldInfo.pFieldItem = nullptr" call will mean that
the pFieldItem is leaked for that element.

The only thing needed later is the existance of a date field, and the field's
position, so encode those two facts as a bool and EPosition and
stop abusing aFieldInfo.pFieldItem to serve as a flag

Change-Id: I6a1c46d32406dbd6865cfcf6d23a3863bada6810
2016-10-26 21:17:20 +01:00
Michael Stahl
dad2f1440c fix "TabError: inconsistent use of tabs and spaces in indentation"
Change-Id: Iff27ff4a01dc8c20b01a6247554b6cc7195a2306
2016-10-26 21:08:31 +02:00
Miklos Vajna
3803460589 solenv: fix Windows build
Traceback (most recent call last):
File "C:cygwinhometdflodejenkinsworkspacelo_gerritConfigwindows_msc_dbgutil_32solenvqapythongbuildtoide.py", line 32, in test_gbuildtoide
del(os.environ['LD_LIBRARY_PATH']) # built with ASAN; prevent that
File "C:cygwinhometdflodejenkinsworkspacelo_gerritConfigwindows_msc_dbgutil_32instdirprogram\python-core-3.3.0libos.py", line 692, in __delitem__
raise KeyError(key) from None
KeyError: 'LD_LIBRARY_PATH'

Change-Id: I1575caf90cafffd71dd28fedc46b5e3570848be8
Reviewed-on: https://gerrit.libreoffice.org/30304
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Michael Stahl <mstahl@redhat.com>
2016-10-26 18:53:00 +00:00
Miklos Vajna
b6f98b7115 xmlsecurity PDF verify: support SHA-256
And various other minor fixes.

Change-Id: Ifcccebf48aac8ad526406f2d7a402a840d3c91cd
2016-10-26 20:09:38 +02:00
Miklos Vajna
fc56d31c09 xmlsecurity PDF verify: fix handling of non-imported certs
Previously we only managed to verify a signature in case the certificate
was already imported in the local NSS db. Don't depend on that by
(temporarily) importing certificates from the PDF signature.

Also adjust a test file that failed previously (the test DB has only an
"Alice" cert imported, intentionally sign the file as "Bob" as well).

Change-Id: Id8440acc31915f5a1718ea48129b950bb67e7486
2016-10-26 20:09:38 +02:00
Miklos Vajna
23ca39a7c2 xmlsecurity PDF sign: fix removing non-last signatures
PDF signatures are always chained, so when removing a signature not only
the item at a given position should be removed on the UI, but the whole
position-last range.

Change-Id: I76b14308885267cdac994fa957218a8b7df6b3cf
2016-10-26 20:09:38 +02:00
Miklos Vajna
f45ace2897 xmlsecurity PDF signing: fix byte range check for multiple signatures
We can mandate that the byte range end is the end of the file for the
last signature only.

With this, signing a previously unsigned file multiple times works, so
add a matching testcase for that as well.

Change-Id: I8fe5482890fca4dab8da6305aa7fc7f60df612d8
2016-10-26 20:09:38 +02:00
Stephan Bergmann
0b7bc00ae3 Revert "clang plugin for push_back after using sized constructor"
This reverts commit e2fa592c77, sould no longer be
necessary after 3be8c4c2bb "The badvectorinit
plug-in probably can be retired".

Change-Id: I26fadaf002e8e21144a7e888a80bb40eb017a64b
Reviewed-on: https://gerrit.libreoffice.org/30296
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-26 17:51:45 +00:00
Eike Rathke
0ebe9fab18 init ScUndoRemoveMerge with range, tdf#92117 follow-up
So the original selection is restored after Undo.

Change-Id: Ie549a0b62da469ee38270ae089ea5abf9a6868e3
2016-10-26 16:19:40 +02:00
Michael Stahl
5ac920be30 solenv: don't run make with LD_LIBRARY_PATH set
In a build with -fsanitize=address, this fails with:

Change-Id: Ida0d4445d7f829545b493e9dd4c2c4ef33960850
make: symbol lookup error: instdir/program/libfreebl3.so: undefined symbol: __asan_option_detect_stack_use_after_return
2016-10-26 15:23:06 +02:00
Stephan Bergmann
87c28ddabc i18nlangtag must presumably be dropped from Library_merged.mk
...after 475e4b477c "Move i18nlangtag lib to
URELIB"?

Change-Id: I45c5d997ed30757157109c67f30b91c4073c6b0a
2016-10-26 15:20:27 +02:00
Eike Rathke
647e860435 Resolves: tdf#92117 create only one Undo for all UnmergeCells() calls
... during DeleteCells() and InsertCells(), instead of one Undo per
UnmergeCells() call. And actually create Undo only if bRecord requested.

Change-Id: I4f1747c3f42f36e16be81f989f0af5d048ba9d9f
2016-10-26 14:55:23 +02:00
Caolán McNamara
0d3e45608a SfxSlotInfo is unused
Change-Id: I8d5438ca338868c77dcf489609a4e007cfe925fd
Reviewed-on: https://gerrit.libreoffice.org/30290
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-26 12:44:31 +00:00
Miklos Vajna
a324099538 xmlsecurity PDF signing: only write incremental xref in an incremental update
We used to just dump all the object offsets in the xref of the
incremental update, but Adobe Acrobat doesn't like that, and considers
that a second signature invalidates the first. If we properly only
mention new and changed objects in the xref, then this doesn't happen.

This requires actually parsing incremental updates, the previous code
depended on LO writing not-really-incremental xrefs at the end of
incremental updates.

Change-Id: Icdd73fe0a3eab16f8c5a62f1355edbb49f6e73de
Reviewed-on: https://gerrit.libreoffice.org/30288
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-10-26 12:20:26 +00:00
Giuseppe Castagno
da5d205624 Linux: Build NSS in debug mode only in '--enable-dbgutil' mode.
With this commit, NSS debug mode is enabled only if you compile
with --enable-dbgutil using ./autogen.sh command.

Only for the Linux platform builds.

Change-Id: Ia8626f36692fd38e8b1dbd774e4bc0ccedc59072
Reviewed-on: https://gerrit.libreoffice.org/29781
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-10-26 12:14:05 +00:00
Stephan Bergmann
95cfef300e const-ness fixes
Change-Id: I83858c0cbca0fc493ac506e2b839e43310f3bb2f
2016-10-26 13:57:05 +02:00
Miklos Vajna
36c4fd5c33 svl: the compiler can generate the same SfxGrabBagItem copy ctor itself
Change-Id: I54f94e8ec710ca117ecdf33ebe97a0e5f07c59ec
Reviewed-on: https://gerrit.libreoffice.org/30283
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-10-26 11:21:04 +00:00
Winfried Donkers
1276e95193 tdf#103088, improve interoperability with Excel for LOGNORMDIST().
Change-Id: I5f4ccbb54b212247a3ff8b13ff012c930d18a86c
Reviewed-on: https://gerrit.libreoffice.org/30020
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-10-26 11:13:09 +00:00
Stephan Bergmann
532847746f Better way to silence loplugin:staticmethods
...in this !ENABLE_FORMULA_LOGGER dummy implementation

Change-Id: Ifaf3356ada68d70164644f89fc6dc6d66f22024b
2016-10-26 13:03:40 +02:00
Caolán McNamara
8efdf567de drop now unused SfxStyleItem, etc.
Change-Id: I61227079c376299d17250970b19acb0c415034fb
2016-10-26 12:02:40 +01:00
Caolán McNamara
c14b9d036a assemble SfxStyleFamilies from more generic resource components
Change-Id: I25aa0d8bca1f16f5fc27d3b299709479a1635ea3
2016-10-26 12:02:40 +01:00
Noel Grandin
88ec5de1c9 expand SvMetaType::ReadNamesSvIdl
it just forwards to ReadNameSvIdl

Change-Id: I803edb7a5977cf309e2cedaa3b4764bcbd933597
2016-10-26 11:56:21 +02:00
Takeshi Abe
406798f8aa tdf#96948 Change color of the area behind Impress slide immediately
after saving Options > Application colours > Application background.

This fixes a regression from 1c481fe652.

Change-Id: I8dc0caf9e351c0b1bf2a10e9097d8f3e895f1471
Reviewed-on: https://gerrit.libreoffice.org/29957
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-26 09:20:52 +00:00
Caolán McNamara
0b4be27b14 try and silence coverity#1374267 Out-of-bounds access
Change-Id: Ib7a8866dc4acdc243e7bfa975e760afde3bb43a6
2016-10-26 09:56:30 +01:00
Caolán McNamara
2574d76059 coverity#1374287 Uncaught exception
Change-Id: Ieed911b33fe4a5358855b3960b9d4c77c66ceff9
2016-10-26 09:56:30 +01:00
Caolán McNamara
95af8bfcdf coverity#1374286 Uncaught exception
Change-Id: Ied3abcd1f2bd7754e3861905f441c46f828f7f5d
2016-10-26 09:56:30 +01:00
Caolán McNamara
8ee0932466 coverity#1374285 Uncaught exception
Change-Id: I0a3790607fe7db6a8b8093a67e4dbf3548c800bb
2016-10-26 09:56:30 +01:00
Caolán McNamara
521e5dd379 coverity#1374284 Uncaught exception
Change-Id: Ie43165d3f6abd420b951a80e0101d8e77946d4a3
2016-10-26 09:56:30 +01:00
Caolán McNamara
b9d0b57b17 coverity#1374283 Uncaught exception
Change-Id: I658a12da4d30f360f207ca06dcf3650ba18cc7a2
2016-10-26 09:56:30 +01:00
Caolán McNamara
5d5564fa7a coverity#1374282 Uncaught exception
Change-Id: I1b31825ec27d2395ca030ca79b6c932b7814d901
2016-10-26 09:56:30 +01:00
Caolán McNamara
b23e979157 coverity#1374281 Uncaught exception
Change-Id: Iaffb4b67c67b5877a5a53d9ae81927b28883fc56
2016-10-26 09:56:30 +01:00
Caolán McNamara
77c3b365c6 coverity#1374280 Uncaught exception
Change-Id: I18f7f006256ac7df575d9235e7121b45fbd05370
2016-10-26 09:56:30 +01:00
Caolán McNamara
f96f2adc28 coverity#1374279 Uncaught exception
Change-Id: I5818bb0a2fe64fd808de5ca7f6d8393f92ab55e2
2016-10-26 09:56:30 +01:00
Caolán McNamara
b1de670d6a coverity#1374278 Uncaught exception
Change-Id: Ide557d1a3237c36067107d357ac2df6186994e10
2016-10-26 09:56:30 +01:00
Caolán McNamara
1ae7f7fcae coverity#1374277 Uncaught exception
Change-Id: I2475056682252111af78a7594c04d15a93fda47f
2016-10-26 09:56:30 +01:00
Caolán McNamara
487738732b coverity#1374276 Uncaught exception
Change-Id: I0572e4365831cf0be2b73c5255812aaf4516ccb0
2016-10-26 09:56:30 +01:00
Caolán McNamara
9b6cb97e43 coverity#1374275 Uncaught exception
Change-Id: I6fcc5d75d8a4b131dc4e3b2e294761b152763a1b
2016-10-26 09:56:30 +01:00
Caolán McNamara
adf3ec2032 coverity#1374274 Uncaught exception
Change-Id: I9e3cee79dfdc06c751d1e5b3d0806c49a7e30da7
2016-10-26 09:56:30 +01:00
Caolán McNamara
0aa597d063 coverity#1374273 Uncaught exception
Change-Id: Ia2738aeb9d1092dd0738801022c5a729b9081f26
2016-10-26 09:56:30 +01:00
Caolán McNamara
0b069a35d3 coverity#1374272 Uncaught exception
Change-Id: Iea7cb5d35e78b89398e8aca7bbdbd17015cb7120
2016-10-26 09:56:30 +01:00
Caolán McNamara
759c585e0c coverity#1374271 Uncaught exception
Change-Id: I043cd76ae0da65cac09130f0e761266fd8730be6
2016-10-26 09:56:30 +01:00
Caolán McNamara
07385355db coverity#1374270 Uncaught exception
Change-Id: Ia29b644748f00aa7dc31af9ccc510976d8646241
2016-10-26 09:56:30 +01:00
Caolán McNamara
ae68c27457 coverity#1374269 Uncaught exception
Change-Id: Ib3a876ea6463396784062bd53bfedff177818498
2016-10-26 09:56:30 +01:00
Caolán McNamara
6920de0e1f coverity#1374268 Uncaught exception
Change-Id: Ife6e9897c12a9754afd5f4754c7de41eef7f00eb
2016-10-26 09:56:30 +01:00
Giuseppe Castagno
80cd32f78d WebDAV: Small cosmetic to unit checks.
Change server name in URI test strings.
Pass by const lvalue reference [loplugin:passstuffbyref].

Change-Id: Ic0134f0690a8e6b9abb7d0764efaeeaf3a167bcf
Reviewed-on: https://gerrit.libreoffice.org/30284
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Giuseppe Castagno <giuseppe.castagno@acca-esse.eu>
2016-10-26 08:49:53 +00:00
Takeshi Abe
c498c97f74 The default std::less<sal_uInt16> is fine
Change-Id: I29cd62ef0b687613ed9bda5170511dcae2fc6e7e
Reviewed-on: https://gerrit.libreoffice.org/30282
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-26 08:39:09 +00:00