399585 Commits

Author SHA1 Message Date
Tomaž Vajngerl
d115a235bf tdf#103804 reduced register areaScale shader and detection for intel
Some intel drivers crash when areaScale shader with "large" array
is used. This adds a "reduced register" version of the areaScale
shader. We still use the first version of the shader for other
drivers and switch between the 2 implementations with a runtime
detection.

Change-Id: I1860f898c03b40a600eb1b41f7262719382a7171
Reviewed-on: https://gerrit.libreoffice.org/30571
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-11-09 09:56:59 +00:00
Caolán McNamara
e21ef810e1 crashtesting: unexpected exception on novell403458-1.pptx
since

commit 4bcf1872bbe9db1388769485a7e4c0cbcce3d53c
Date:   Thu Oct 13 23:43:41 2016 +0200

    chartx: fix sparse chart import

because

- Matrix< Any > aMatrix( rDataSeq.maData.size(), 1 );
+ Matrix< Any > aMatrix( rDataSeq.mnPointCount, 1 );

where rDataSeq.mnPointCount is -1

Change-Id: I4bb4805dd81a342d4c0ce24e3240154daf53b452
2016-11-09 09:36:19 +00:00
Stephan Bergmann
80af87b0de Revert "Mark Scheduler as non-copyable"
This reverts commit 81e3f5f2fdc9c573c83a37009080e4bb974c7955; had failed to
notice that there are already (Scheduler const & overloads of) copy member
functions (which MSVC complains about, but Clang didn't).
2016-11-09 09:58:33 +01:00
Noel Grandin
3a54589302 convert Primitive2DContainer to std::deque
since we only care about appending to this container, and then
traversing it (normally once). So reduce the re-allocations that
std::vector requires

Change-Id: I206a7b82d9eefc1fa3762c4a03e7b5e21136951f
Reviewed-on: https://gerrit.libreoffice.org/30706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09 08:54:01 +00:00
Stephan Bergmann
81e3f5f2fd Mark Scheduler as non-copyable
Change-Id: Iaabc92061a1a49720f473d35251d892dd4b4f756
2016-11-09 09:50:12 +01:00
Noel Grandin
389999abdb make comphelper::containerToSequence a little smarter
So we don't have to specify the source and destination type as often.

Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624
Reviewed-on: https://gerrit.libreoffice.org/30700
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09 07:48:18 +00:00
Noel Grandin
57998f642d some small simplifications to decompose methods
Change-Id: I9ad8c68c1f0c72d0f985d6c0a3167a775d481a2c
Reviewed-on: https://gerrit.libreoffice.org/30696
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09 06:20:39 +00:00
Maxim Monastirsky
85102b0fe4 Restore the color picker icon in colorwindow.ui
Caused by a bug in Glade.

Change-Id: I8acc923093f7ef1e8a2a5831bc96c63e4c7f0341
2016-11-09 00:46:19 +02:00
Stephan Bergmann
d5cb614270 Use the larger stack size for ASan/UBSan builds on macOS, too
At least on my macOS 10.12.1, PTHREAD_STACK_MIN is 8192 (so stacksize was
substantially smaller than 12MB), and without this change there were randomly
looking failures in e.g. JunitTest_chart2_unoapi with a -fsanitize=address
build.

Change-Id: Icfe989a0e5097a9a0ae76c6e0f6ffcca18271245
2016-11-08 23:33:52 +01:00
Andras Timar
79f6d01eb1 Updated core
Project: help  0119d6fd483709ee783da89d961e93e71ba41eb6

fix invalid xml

Change-Id: I15ed980578006e5ef55e0983d1683b001baa39f2
2016-11-08 21:51:31 +00:00
Caolán McNamara
13203033fb Resolves: tdf#103783 do consider parent of WB_DIALOGCONTROL widgets...
for tab cycling, given the problem of tdf#103783

regression from...

commit fd40e3ea09a481a2e97452d2244ecdfd6c3508c1
Author: Caolán McNamara <caolanm@redhat.com>
Date:   Tue Nov 1 16:34:22 2016 +0000

    lock tab-cycling inside the WB_DIALOGCONTROL widget

    activate the color selector in the toolbar in the sidebar panel, press tab
    to cycle between its widgets, when it hits the bottom it will
    not return to the first widget, but escape out of the floating
    window into the next sibling of the toolbar

but only check the Parent, not RealParent

Change-Id: I9577a0a9f3a622373c195e77ca43d17511b4154d
2016-11-08 21:17:53 +00:00
Joel Madero
006884d792 Updated core
Project: help  578e1e320daaa82b2d3b8c0eeea84bf704967939

tdf#103397 - added example for Transpose function

Added a simple example to the help for transpose() function

Added tablehead style to example rows/columns

Change-Id: I464983d480cb237a53e033005057a1faef0b9193
Reviewed-on: https://gerrit.libreoffice.org/30334
Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br>
Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-11-08 19:00:21 +00:00
Gabor Kelemen
bd93f1a5dd Remove obsolete OxygenOffice strings
These belonged to extra galleries, introduced in
49d5bdcf4d516b21721f1ed6d313ea4a170d39eb
I missed to remove these in
8dc38d9ded92960eda46343b67da8a8b95404b5a

Change-Id: I32c649d56053b32f2c2993aeda51425d7586c9b7
Reviewed-on: https://gerrit.libreoffice.org/30698
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-08 16:55:49 +00:00
Miklos Vajna
5d34de5f27 xmlsecurity PDF verify: fix handling of xref stream free objects
In case our xref table doesn't have an entry for "free" object types,
then the table size won't provide a valid id for a next object. That
resulted in creating all new objects with the same ID.

With this, our verifier at least can see the new signature when
appending one to a signed PDF 1.6 file.

Change-Id: Iac39a400706cfcd23dd814d2b81cb8b950c69fc6
Reviewed-on: https://gerrit.libreoffice.org/30704
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-08 16:47:58 +00:00
Miklos Vajna
3f213154e2 xmlsecurity PDF sign: handle xref stream when reading trailer
Don't give up signing just because PDF 1.4 trailer is missing, provided
that PDF 1.5 xref stream is available.

Change-Id: I03360d428346537583a4398aa3a94b195b428713
Reviewed-on: https://gerrit.libreoffice.org/30703
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-08 16:47:32 +00:00
Miklos Vajna
62401ba3c9 xmlsecurity PDF sign: don't crash on missing trailer
This will need cross-reference stream write support, just don't crash
for now.

Change-Id: Id48c131b22d4ed96174693f3e96b14c273d596a8
Reviewed-on: https://gerrit.libreoffice.org/30702
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-08 16:46:51 +00:00
Stephan Bergmann
5d80555938 Return early from double ToolBarManager::dispose
...if that should ever happen.  Also means that
ToolBarManager::RemoveControllers will now only be called with m_bDispose being
false.

Change-Id: If17d60f291cc8dad19d6f6e33d39e08c7f8ad7aa
2016-11-08 17:18:44 +01:00
Stephan Bergmann
991dad0a93 Clean up (calls to) ToolBarManager::RemoveControllers
...which turns out to be only called with SolarMutex locked

Change-Id: I3264b0a043da7111b8ca12c59ee7a590f1a43b8e
2016-11-08 16:53:57 +01:00
Gabor Kelemen
6c946f3dd8 Remove license information of dropped extensions
No need to mention licensing info of OxygenOffice-related
extensions that were dropped in
8dc38d9ded92960eda46343b67da8a8b95404b5a

Change-Id: I12b862433b62154078d88f6debac8ecae749a751
Reviewed-on: https://gerrit.libreoffice.org/30699
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-11-08 15:45:57 +00:00
Stephan Bergmann
cb34498395 Clean up (calls to) StatusBarManger::RemoveControllers
...which turns out to be only called with SolarMutex locked and m_bDisposed
being false

Change-Id: I454e7951ea579fb6d9dc71d0aabebd373380b3e4
2016-11-08 16:14:32 +01:00
Gabor Kelemen
16efafc27a Drop more OxygenOffice bits
Follow up to 8dc38d9ded92960eda46343b67da8a8b95404b5a
Here we drop some --help descriptions and the rest of
removed extensions from the Jenkins config file

Change-Id: Ie1520adf2c48c2dc714b00c53ba0055f1deb3c62
Reviewed-on: https://gerrit.libreoffice.org/30697
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-08 14:56:41 +00:00
Stephan Bergmann
c0da11fb1c There's no derivations from StatusBarManager
Change-Id: Ifa2970cf838209b72e286109f14b98e77f389c0b
2016-11-08 15:52:40 +01:00
Miklos Vajna
a69873d212 xmlsecurity: move the sec context from the format helpers to the sign manager
The signature manager always creates an XML helper, and optionally creates a
PDF helper as well. Both of them initialize xmlsec, and when the signature
manager is deleted, there are two de-inits, leading to an assertion failure in
xmlsec.

Fix the problem by moving the duplicated xmlsec init to the signature manager.
This has the additional benefit that general security-related code no longer
has to talk to the XML helper, it can use the signature manager, which feels
more natural. (What viewing a certificate had to do with XML?)

Change-Id: If6a6bc433636445f3782849a367d4a7ac0be7688
Reviewed-on: https://gerrit.libreoffice.org/30695
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-11-08 14:50:56 +00:00
Kohei Yoshida
2573f6bba6 Ensure that the string array is null when no strings present.
It was intended this way from day one, but the implementation
didn't live up to that promise...

Change-Id: I231ddc8923fdd8a205127c6a3214dd93f13378b9
Reviewed-on: https://gerrit.libreoffice.org/30678
Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-08 14:25:03 +00:00
Tor Lillqvist
51663ac544 Fallout from previous commit 248dbe1de5eeea9e9173e53a0b1891f63ff73d68
Remove SignatureInformation::nSecurityEnvironmentIndex as it was
always -1.

Change-Id: I39247e5c40ce36e394c30b450626eca533f46267
2016-11-08 15:46:30 +02:00
Tor Lillqvist
248dbe1de5 Bin pointless (overloaded) member function
The XSecController::setX509Certificate() overload that took a
sal_Int32 nSecurityEnvironmentIndex was called in just one place, and
-1 was always passed for the nSecurityEnvironmentIndex.

Change-Id: Ic37b7053c90a6fbb8b4e5b6485483d34c605b965
2016-11-08 15:43:47 +02:00
Tor Lillqvist
f75cd22118 Add fill-column: 100 to the Emacs mode line
Vim users: No reason to panic. This does not mean that Emacs users
would suddenly start to split existing (or new) code lines always
before column 100. The default value for fill-column is 70, and that
hasn't forced code lines edited in Emacs to be shorter than that
earlier either.

The primary intent of using a fill-column of 100 (instead of the
default 70) is that when you edit some long (multi-line) comment
block, and you want to reformat ("fill", "reflow") that comment (using
the fill-paragraph command, bound to Meta-Q), lines will be filled up
to column 100, and not just 70, which in most cases would look quite
short.

Unless I am strongly advised not to, I will start adding this to the
mode lines in source files if I remember, as I happen to edit some
comment block in them.

Change-Id: Icfb93dbb22b2db7190fdc9c8ee9518d08e73c7a8
2016-11-08 14:59:30 +02:00
Miklos Vajna
b58e3de0cd sfx2: let .uno:SignPDF add a matching button to the infobar
When the user uses .uno:SignPDF to open a PDF file in read-only mode,
then the infobar now has a "Sign Document" button, which is a shortcut
for the File -> Digital Signatures -> Digital Signatures menu item.

Change-Id: I2953a5cb1252c5ff1c395d45c54db1a97b39433e
2016-11-08 13:40:34 +01:00
Tor Lillqvist
b2318479c8 Work in progress on supporting XAdES-compliant signatures for ODF
xmlsecurity is such a mess. Too many different classes that actually
have more or less identical life-time, with names that smell of
delusions of grandeur. "Manager", "security framework controller" etc
for stuff that actually exist only during the execution of a simple
dialog. And then a "helper" class that actually in on a higher level
than a "framework controller". But oh well.

Change-Id: I86e461b1bc91a0d8f5b7fb9f13a5be201729df1e
2016-11-08 14:31:46 +02:00
Andras Timar
29ddf52adf typo fix: ressource -> resource
Change-Id: Id8d1c01b17e711a057a9f3f20e1d0f955b2ea6c8
Reviewed-on: https://gerrit.libreoffice.org/30690
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-08 12:21:31 +00:00
Katarina Behrens
cc2d27ea1e Change new colour only, keep active one on the initial value
Change-Id: Icfda455d275d0449725867fd7bf4ea3060e7dc26
Reviewed-on: https://gerrit.libreoffice.org/30691
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-11-08 11:48:08 +00:00
Caolán McNamara
8bff616ae6 simplify mark points and gluepoints management
Change-Id: I52070cfe4909a13189d9c130114d98565ced9089
2016-11-08 11:22:58 +00:00
Noel Grandin
1b277a37c5 loplugin:expandablemethods in extensions
Change-Id: I93a770933de86146de1d25db9d596615916c3e28
Reviewed-on: https://gerrit.libreoffice.org/30689
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 11:11:52 +00:00
Noel Grandin
f2beebbfe7 reduce copying when decomposing drawinglayer primitives
instead of returning a Primitive2DContainer from each method which we
are then going to immediately append to another container, pass down a
single container by reference which we can append to

Change-Id: I0f28a499d2ec54f7111a7044c30099767aa079e1
Reviewed-on: https://gerrit.libreoffice.org/30258
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 10:40:57 +00:00
Noel Grandin
ab731b192f no need to use endsWithAsciiL like this anymore
Change-Id: Ie59d001816661ac19ce19ddae36efd8d880a987f
2016-11-08 12:22:20 +02:00
Noel Grandin
4948daa16d loplugin:expandablemethods in reportdesign
which led to discovering some unused parameters

Change-Id: Ie8f67a47aa9ec409637da32ef9bc457952397772
Reviewed-on: https://gerrit.libreoffice.org/30681
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 10:03:48 +00:00
Miklos Vajna
c1eebcdac9 tdf#79329 DOCX import: fix missing outer table with floattable at cell start
The bug document has a normal table, then its C1 cell starts with a
nested table, which is floating. The problem is that converting the
nested table to a textframe invalidates the start text range of the C1
cell in the outer table we store, so the conversion of the outer table
from text to table fails.

This never worked, so to avoid the regression just don't convert inner
floating tables to textframes when they're anchored at the cell start.
A more general fix in the future can be addressing the actual
invalidation of the cell start/end text ranges, and then this specific
fix will not be necessary anymore.

Change-Id: I12cefa41977cf719b07b0fb3ef9ec423c17ef3b1
Reviewed-on: https://gerrit.libreoffice.org/30685
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-08 09:51:42 +00:00
Noel Grandin
bbf6c51717 loplugin:expandablemethods in forms..formula
Change-Id: Idc948ad06913def28cb642c3a4e5ea9322b9fb3b
Reviewed-on: https://gerrit.libreoffice.org/30688
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 09:49:48 +00:00
Caolán McNamara
bca707d0ec coverity#1394269 Uncaught exception
and

coverity#1394270 Uncaught exception

Change-Id: I91e62c595ed923e44eea4c4fa1ac77444e34a9d9
2016-11-08 09:31:07 +00:00
Noel Grandin
dca61b588a loplugin:expandablemethods in lotuswordpro..package
Change-Id: Ic9827c998f4f78775fdf5c1eaf9d4749d4986102
Reviewed-on: https://gerrit.libreoffice.org/30682
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 09:21:06 +00:00
Caolán McNamara
6aa8e86f3a try and auto-silence coverity#1394273 Use after free
and

coverity#1394272 Use after free

Change-Id: Id2340bccc6fbaeb917cb397890875bd0849ffe85
2016-11-08 09:11:18 +00:00
Caolán McNamara
19fc36293c coverity#1394268 Resource leak
Change-Id: I8f4a76d4f7e5cb2429ed5911c6026535590c681e
2016-11-08 09:06:57 +00:00
Noel Grandin
f606a6b248 loplugin:unnecessaryvirtual in basctl..chart2
Change-Id: Id4eeb12792c3a66b68a907cb459ab437e3d64e4c
Reviewed-on: https://gerrit.libreoffice.org/30680
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 08:57:05 +00:00
Noel Grandin
98460e7a50 loplugin:expandablemethods in framework
Change-Id: I444f31f06d2445392a59879c2d7fb1f8ad1c24c6
Reviewed-on: https://gerrit.libreoffice.org/30684
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 08:53:09 +00:00
Noel Grandin
1a743fd8a2 loplugin:expandablemethods in hwpfilter..linguistic
Change-Id: I62ae20ab4a47b3b7e2b0d503cedcad3319cc9c85
Reviewed-on: https://gerrit.libreoffice.org/30683
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 08:41:38 +00:00
Mike Kaganski
bc57a3e319 tdf#88023: Only warn about unavailable JRE once
The underlying design is that there's a single JavaInteractionHandler
instance owned by a JavaContext, and that JavaContext installed in
Desktop::Main (desktop/source/app/app.cxx).

This patch ensures that no additional JavaContext is created in
SfxOfficeDispatch::dispatch*() functions unless they are used without
preinstalled JavaContext.

Thanks to Stephan Bergmann for guidance!

Change-Id: I2569df221067a5b9bf1f6cd5d8f69b561316a170
Reviewed-on: https://gerrit.libreoffice.org/30529
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-08 07:52:14 +00:00
Noel Grandin
c123c528bf loplugin:unnecessaryvirtual in comphelper..forms
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd
Reviewed-on: https://gerrit.libreoffice.org/30679
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 06:57:57 +00:00
melikeyurtoglu
62e5010e5d tdf#91222 VclBuilder constructor cleanup
Change-Id: I2f7e2fd8b9ae45e1aa45cf97750a6107ed9f3036
Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/30673
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 06:15:05 +00:00
Noel Grandin
8955c3fde6 loplugin:oncevar
Change-Id: I44fb6858eeff14fcbd9fdfbbb0aabd1433b6a27d
Reviewed-on: https://gerrit.libreoffice.org/30668
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 06:11:51 +00:00
Noel Grandin
525a45f22f loplugin:unnecessaryvirtual in framework
Change-Id: I893bf955e45e661e3ec440dbd530fca22931c23b
Reviewed-on: https://gerrit.libreoffice.org/30666
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08 06:11:28 +00:00