mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
399,585 Commits 1 Branch 0 Tags
Commit Graph

399585 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Noel Grandin
990102be61 loplugin:unnecessaryvirtual in hwpfilter..rsc 
Change-Id: I2e9df8223d503b813b4c458747e8c44bb8ef8868
Reviewed-on: https://gerrit.libreoffice.org/30661
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-08 06:10:25 +00:00
Noel Grandin
dda87c6a46 loplugin:unnecessaryvirtual in sc..scaddins 
Change-Id: I4a2d333984827f363ea76580993438d704f9738f
Reviewed-on: https://gerrit.libreoffice.org/30660
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-08 06:10:13 +00:00
Eike Rathke
05d2a66955 Resolves: tdf#103701 bulk-broadcast the correct hint ID for formula groups 
BulkBroadcastGroupAreas() and BulkDataHint and thus
FormulaGroupAreaListener::Notify() omitted to transport the actual hint
and assumed SC_HINT_DATACHANGED, but SC_HINT_TABLEOPDIRTY needs to be
handled as well.

Change-Id: I765f7c95f7aeab295f35dcf6949a3b1926cbe248
 2016-11-08 00:03:45 +01:00
Caolán McNamara
64a708cba9 Revert "Reverts a commit series that cripple windows ci." 
with addition of...

- svxlo-SvxColorListBox
+ svxcorelo-SvxColorListBox

This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601.

Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128
Reviewed-on: https://gerrit.libreoffice.org/30598
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-11-07 21:04:50 +00:00
Jochen Nitschke
f01c49c4a8 style fix for cppcheck duplicateBreak 
Change-Id: I42d4763db5a87741baa6b6d5ec58ea136394bf7a
Reviewed-on: https://gerrit.libreoffice.org/30670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 18:56:30 +00:00
Jochen Nitschke
14301589d7 style fix for cppcheck redundantCondition 
Change-Id: I5d02c6f4c6b411c23a6de43374884a76e1c408fe
Reviewed-on: https://gerrit.libreoffice.org/30667
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 18:55:52 +00:00
Michael Stahl
f9028f1945 vcl: improve accounting of SVG images in graphics cache 
The problem is that the graphics cache only counts the size of the SVG
text, which is stored in SvgData::maSvgDataArray.  However the
SvgData::maSequence may use a lot more memory, as it may contain
de-compressed bitmaps that are stored as base64-encoded PNGs in the SVG
text.

For example icon-themes/galaxy/brand/flat_logo.svg is 812 Ko but contains
60 Mo of bitmaps.

This may cause excessive memory usage and failure to export documents
due to OOM; according to valgrind massif, the bitmap buffers use 90% of
the heap.

Add a new interface com::sun:⭐:util::XAccounting, and implement
it in drawinglayer BasePrimitive2D.  VCL SvgData can't access
drawinglayer via C++ directly so this looks like the best approach.

Change-Id: I5a7c3147733e23473c1decabed24c1f79d951c7d
Reviewed-on: https://gerrit.libreoffice.org/30669
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-11-07 18:52:22 +00:00
Andras Timar
04644956e5 typo: modul -> module 
Change-Id: I2839bb336358c4653b018c383440fb91b0b4e0ca
Reviewed-on: https://gerrit.libreoffice.org/30657
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
 2016-11-07 18:15:35 +00:00
Caolán McNamara
e6157763e9 google docs can generate a pptx with an empty cmLst 
Change-Id: I2a3dcae5361929c6880b2da1b3107cb2c8141f32
 2016-11-07 17:07:49 +00:00
Stanislav Horacek
d9c43a1d54 Updated core 
Project: dictionaries  23948938f710096e17cfd2466e8b7563e3934608

Czech thesaurus: regenerate from updated source

changed location and authors of the source
sorting for source was applied -> thesaurus sorting also changed

Change-Id: I009688bb1aeaac20dbe0884f1b43b523a2a3eb7b
Reviewed-on: https://gerrit.libreoffice.org/30612
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com>
 2016-11-07 16:49:23 +00:00
Miklos Vajna
6f7016a9df officecfg: add .uno:SignPDF label 
And replace the existing .uno:Signature in the File menus with a submenu
that contains .uno:Signature and the new .uno:SignPDF.

Change-Id: I801b9332c697985446c64dd208c25dea2494350e
 2016-11-07 17:28:22 +01:00
Caolán McNamara
15b524a9a8 gtk3: focus jumping around the place under wayland + popovers 
in impress slide sorter panel

do the "oops!, frame moved" callback before the "pointer was
moved" callback

Change-Id: I12f3c66ba15fea04d8dc74d0325582967ea93afe
 2016-11-07 16:16:32 +00:00
Andras Timar
5d0aca576a fix description of 'ooofonts' package 
Change-Id: I918505c42bab14cf0ab94574893e064ddea85b66
Reviewed-on: https://gerrit.libreoffice.org/30656
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2016-11-07 15:50:38 +00:00
Andrea Gelmini
b9b03c7383 Fix typos (also in the code) 
Change-Id: I45d45513b102f4fdcb55e8de20b95b37f66ea463
Reviewed-on: https://gerrit.libreoffice.org/30658
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2016-11-07 15:44:24 +00:00
Michael Stahl
8f232026f0 soffice.sh: can't hurt to force system allocator for massif 
Change-Id: Ib999ed36befae52894c04eaa95be76f2a7cfdd3b
 2016-11-07 16:34:42 +01:00
Caolán McNamara
fc64c335be ensure checkForUniqueItem on inserting a new slide 
On copying slides from another presentation into one, we end up
with two XBitmapItems with the same name and different properties.

because the names are supposed to be unique, only one gets exported
so the presentation looses graphics on export

there is a bunch of places which use checkForUniqueItem to block
this from happening, add another at the point where we insert
the new page into the model

Change-Id: If708b1997c7e83e4787d9d54f84c8b0516e6cf6b
Reviewed-on: https://gerrit.libreoffice.org/30664
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2016-11-07 15:32:43 +00:00
Michael Meeks
ba68e6dd7a tdf#92160 - sc: limit search results to 1000 entries. 
Very large replace results give huge space consumption in the
display widget, and are of dubious usefulness.

Change-Id: Ib8ad01a673ea52976befaf958f8f695aca2190ae
Reviewed-on: https://gerrit.libreoffice.org/30574
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2016-11-07 13:37:41 +00:00
Noel Grandin
0a3eaf9f67 loplugin:unnecessaryvirtual in sd..sdext 
Change-Id: Id0bc82210fadc138b55d1abe4e06b1d2ed564df3
Reviewed-on: https://gerrit.libreoffice.org/30659
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 13:00:53 +00:00
Tomaž Vajngerl
19dc288ce4 opengl: use shared_ptr for ImplOpenGLTexture 
Change-Id: I755e312e3e0a69b99a8f02f7d05561b7289845ce
Reviewed-on: https://gerrit.libreoffice.org/30597
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Tomaž Vajngerl <quikee@gmail.com>
 2016-11-07 12:59:38 +00:00
Miklos Vajna
055be3f4be sfx2: introduce a new .uno:SignPDF 
It's similar to File -> Open, but the file picker only offers PDF files
in this case, and the import is read-only -- i.e. it's the import
equivalent of .uno:ExportToPDF.

Change-Id: I7be9d6711e0ea93643e538575c0604d41cff9b26
 2016-11-07 13:46:57 +01:00
Noel Grandin
e53168c687 improve indentation 
Change-Id: I1ca7f386cbd85d64e86fe293b2a4a4cbb205edef
 2016-11-07 14:21:04 +02:00
Jan Holesovsky
5c3ea5d9aa Updated core 
Project: help  433c4c0477c6dfcde68ed5b1eb98f1811095f050

Change '/text' to just 'text' on many places.

With this, the pages start appearing even locally with just pointing the
browser to file:///.../help_git_repo/source/index.html
 2016-11-07 12:20:18 +00:00
Mark Hung
f2bccf3685 oox: exporting the block arc as its corresponding drawingml preset shape. 
block arcs were exported as paths, stretching it to the whole
viewport. Exporting it as a preset shape to prevents distortion.

Change-Id: I68bac6ee273d89c0a4333d4d6a4816c6a7f802a0
Reviewed-on: https://gerrit.libreoffice.org/29679
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Hung <marklh9@gmail.com>
 2016-11-07 12:19:47 +00:00
Noel Grandin
d4f78fa3b6 loplugin:unnecessaryvirtual in svx..sw 
Change-Id: I4ae8de558550e6577c28b95e0aaed74f00d79c29
Reviewed-on: https://gerrit.libreoffice.org/30650
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 12:06:35 +00:00
Noel Grandin
b7914a9a56 loplugin:oncevar in chart2 
Change-Id: Id9308f9265c2453075971c8105b4d161bd145da7
Reviewed-on: https://gerrit.libreoffice.org/30654
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 11:54:20 +00:00
David Tardon
65aafb5071 only cond. build stuff that is really new in ICU 58 
Change-Id: I59598329a7051374177b4d16aa061367b6043982
 2016-11-07 12:38:21 +01:00
Noel Grandin
febde9d61d wrap some more dialog pointers in VclPtr 
and fix a couple of memory leaks in the process, some of them were
not being deleted at all

Change-Id: Icb5c948662ad3ba878eadfbc807f93cc35cfb228
Reviewed-on: https://gerrit.libreoffice.org/30651
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 11:02:06 +00:00
Noel Grandin
fae35e535d loplugin:oncevar in cui..connectivity 
Change-Id: Ibe9d04932b0a57040db4fee11886dc1701f6ea17
Reviewed-on: https://gerrit.libreoffice.org/30653
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 11:00:47 +00:00
Noel Grandin
0f96b3f33f loplugin:unnecessaryvirtual in test..vbahelper 
Change-Id: I0e110af6eab798e11f96d0f7d282d59440d91965
Reviewed-on: https://gerrit.libreoffice.org/30649
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 10:11:33 +00:00
Noel Grandin
41ea741cd8 loplugin:unnecessaryvirtual in sfx2..svtools 
Change-Id: Ib34e14806f7cc9a97ecfd68687ab17ee5c1f022b
Reviewed-on: https://gerrit.libreoffice.org/30652
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 09:39:55 +00:00
Damjan Jovanovic
028cc38a16 Resolves: #i119892# Missing "by" in description 
Fixes spelling errors in some Base messages.

Reported by: Dwayne Henderson
Patch by: me

(cherry picked from commit 8df1c30b7f5e79c2757e7224677f9a487b1bed0a)

Change-Id: I18dcf20e51e941ca8ccb47315ea453399ca0d88a
 2016-11-07 09:36:05 +00:00
Miklos Vajna
90625922e5 sw: prefix members of WW8ScannerBase 
Change-Id: I8e0235a8701e0cc0e8ca707b8f3ff2581f2bfcbd
Reviewed-on: https://gerrit.libreoffice.org/30648
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2016-11-07 09:23:41 +00:00
Justin Luth
d9c7b0a011 tdf#62625 - reopen temp stream to readBasic .xls VBA 
InputStream was closed, but an InStream was still open,
so InputStream was not being re-created.
Apparently either most web protocols aren't properly closed,
or else a second stream is needed for these kinds of protocols.

Required on Linux for INetProtocol::Http, Generic, Smb, Sftp
and perhaps more.  Required on Windows/Mac for Remote WebDAV
(although http://xx/xx.xls worked)

Change-Id: Icb732518fb8185168c5ed1cb9e32c84c9d8d71bb
Reviewed-on: https://gerrit.libreoffice.org/30303
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-11-07 08:47:51 +00:00
David Tardon
01ff03e154 fix build with ICU < 58 
Change-Id: I84027f0812e672519ed314639deeb5c0d1069624
 2016-11-07 09:28:38 +01:00
Stephan Bergmann
02cf121aab -Werror,-Wdeprecated-declarations 
Change-Id: Ia54f11b799fefcddcbf3b9f49e806bfc0895773f
 2016-11-07 09:09:38 +01:00
Stephan Bergmann
3f7fc4e5d2 Postpone menu destruction 
...to avoid use-after-free, as e.g. happens on macOS with -fsanitize=address in
CppunitTest_sw_mailmerge:

> ==29010==ERROR: AddressSanitizer: heap-use-after-free on address 0x60800088faf8 at pc 0x000118ebc153 bp 0x7fff52f81a40 sp 0x7fff52f81a38
> READ of size 8 at 0x60800088faf8 thread T0
> WARNING: failed decoding unknown ioctl 0x20007454
> WARNING: failed decoding unknown ioctl 0x20007452
>     #0 0x118ebc152 in AquaSalMenu::SetSubMenu(SalMenuItem*, SalMenu*, unsigned int) salmenu.cxx:597
>     #1 0x1177bbefc in Menu::SetPopupMenu(unsigned short, PopupMenu*) menu.cxx:803
>     #2 0x138dccb5a in framework::MenuBarManager::RemoveListener() menubarmanager.cxx:552
>     #3 0x138dcb452 in framework::MenuBarManager::Destroy() menubarmanager.cxx:237
>     #4 0x138dcd6d7 in framework::MenuBarManager::dispose() menubarmanager.cxx:267
>     #5 0x138dccfa2 in framework::MenuBarManager::RemoveListener() menubarmanager.cxx:587
>     #6 0x138dcb452 in framework::MenuBarManager::Destroy() menubarmanager.cxx:237
>     #7 0x138dcd6d7 in framework::MenuBarManager::dispose() menubarmanager.cxx:267
>     #8 0x138e06acf in framework::MenuBarWrapper::dispose() menubarwrapper.cxx:103
>     #9 0x1389c0f67 in framework::LayoutManager::impl_clearUpMenuBar() layoutmanager.cxx:226
>     #10 0x1389c497b in framework::LayoutManager::implts_destroyElements() layoutmanager.cxx:447
>     #11 0x1389c3777 in framework::LayoutManager::implts_reset(bool) layoutmanager.cxx:413
>     #12 0x1389edf4b in framework::LayoutManager::frameAction(com::sun:⭐:frame::FrameActionEvent const&) layoutmanager.cxx:2811
>     #13 0x138b9e1a8 in (anonymous namespace)::Frame::implts_sendFrameActionEvent(com::sun:⭐:frame::FrameAction const&) frame.cxx:3110
>     #14 0x138b8219b in (anonymous namespace)::Frame::setComponent(com::sun:⭐:uno::Reference<com::sun:⭐:awt::XWindow> const&, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XController> const&) frame.cxx:1557
>     #15 0x138b88545 in (anonymous namespace)::Frame::close(unsigned char) frame.cxx:1801
>     #16 0x12078429a in SfxFrame::DoClose() frame.cxx:127
>     #17 0x120812990 in SfxViewFrame::Notify(SfxBroadcaster&, SfxHint const&) viewfrm.cxx:1234
>     #18 0x11ab542d5 in SfxBroadcaster::Broadcast(SfxHint const&) SfxBroadcaster.cxx:50
>     #19 0x1203a0682 in SfxModelListener_Impl::notifyClosing(com::sun:⭐:lang::EventObject const&) objxtor.cxx:171
>     #20 0x1204453d2 in SfxBaseModel::close(unsigned char) sfxbasemodel.cxx:1372
>     #21 0x1245130d5 in SwXTextDocument::close(unsigned char) unotxdoc.cxx:621
>     #22 0x1247af99b in CloseModelAndDocSh(com::sun:⭐:uno::Reference<com::sun:⭐:frame::XModel>&, tools::SvRef<SfxObjectShell>&) unomailmerge.cxx:115
>     #23 0x1247af4bf in DeleteTmpFile_Impl(com::sun:⭐:uno::Reference<com::sun:⭐:frame::XModel>&, tools::SvRef<SfxObjectShell>&, rtl::OUString const&) unomailmerge.cxx:342
>     #24 0x1247b6ad6 in SwXMailMerge::execute(com::sun:⭐:uno::Sequence<com::sun:⭐🫘:NamedValue> const&) unomailmerge.cxx:814
>     #25 0x1247b9c62 in non-virtual thunk to SwXMailMerge::execute(com::sun:⭐:uno::Sequence<com::sun:⭐🫘:NamedValue> const&) unomailmerge.cxx:434
>     #26 0x11eeab4fd in MMTest::executeMailMerge() mailmerge.cxx:179
>     #27 0x11eea2470 in testMultiPageAnchoredDraws::verify() mailmerge.cxx:336
>     #28 0x11ef3be50 in MMTest::executeMailMergeTest(char const*, char const*, char const*, bool, int, char const*) mailmerge.cxx:87
>     #29 0x11ef38af3 in testMultiPageAnchoredDraws::MailMerge() mailmerge.cxx:334
>     #30 0x11ef557b9 in CppUnit::TestCaller<testMultiPageAnchoredDraws>::runTest() TestCaller.h:166
>     #31 0x10cfff749 in CppUnit::TestCaseMethodFunctor::operator()() const TestCase.cpp:32
>     #32 0x110736b67 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) vclbootstrapprotector.cxx:36
>     #33 0x10cfc9c20 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const ProtectorChain.cpp:20
>     #34 0x110498fa7 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unobootstrapprotector.cxx:89
>     #35 0x10cfc9c20 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const ProtectorChain.cpp:20
>     #36 0x10f776880 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) unoexceptionprotector.cxx:65
>     #37 0x10cfc9c20 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const ProtectorChain.cpp:20
>     #38 0x10cf64042 in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) DefaultProtector.cpp:15
>     #39 0x10cfc9c20 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const ProtectorChain.cpp:20
>     #40 0x10cfc7200 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) ProtectorChain.cpp:77
>     #41 0x10d06f15a in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) TestResult.cpp:181
>     #42 0x10cffd8cd in CppUnit::TestCase::run(CppUnit::TestResult*) TestCase.cpp:91
>     #43 0x10d00097a in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) TestComposite.cpp:64
>     #44 0x10d00045e in CppUnit::TestComposite::run(CppUnit::TestResult*) TestComposite.cpp:23
>     #45 0x10d00097a in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) TestComposite.cpp:64
>     #46 0x10d00045e in CppUnit::TestComposite::run(CppUnit::TestResult*) TestComposite.cpp:23
>     #47 0x10d0990ac in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) TestRunner.cpp:47
>     #48 0x10d06da55 in CppUnit::TestResult::runTest(CppUnit::Test*) TestResult.cpp:148
>     #49 0x10d099ebd in CppUnit::TestRunner::run(CppUnit::TestResult&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) TestRunner.cpp:96
>     #50 0x10cc6f509 in (anonymous namespace)::ProtectedFixtureFunctor::run() const cppunittester.cxx:305
>     #51 0x10cc6a0ac in sal_main() cppunittester.cxx:455
>     #52 0x10cc687a6 in main cppunittester.cxx:362
>     #53 0x7fffc9f36254 in start (libdyld.dylib+0x5254)
>
> 0x60800088faf8 is located 88 bytes inside of 96-byte region [0x60800088faa0,0x60800088fb00)
> freed by thread T0 here:
>     #0 0x10d327b6b in wrap__ZdlPv asan_new_delete.cc:179
>     #1 0x118eb3011 in AquaSalMenu::~AquaSalMenu() salmenu.cxx:279
>     #2 0x118eb10de in AquaSalInstance::DestroyMenu(SalMenu*) salmenu.cxx:238
>     #3 0x1177acd1d in Menu::ImplSetSalMenu(SalMenu*) menu.cxx:2342
>     #4 0x1177ab046 in Menu::dispose() menu.cxx:183
>     #5 0x1177d86f5 in PopupMenu::dispose() menu.cxx:2764
>     #6 0x117f99ee2 in VclReferenceBase::disposeOnce() vclreferencebase.cxx:42
>     #7 0x1177bf7d8 in VclPtr<Menu>::disposeAndClear() vclptr.hxx:208
>     #8 0x1177bbbd5 in Menu::SetPopupMenu(unsigned short, PopupMenu*) menu.cxx:788
>     #9 0x138dccb5a in framework::MenuBarManager::RemoveListener() menubarmanager.cxx:552
>     #10 0x138dcb452 in framework::MenuBarManager::Destroy() menubarmanager.cxx:237
>     #11 0x138dcd6d7 in framework::MenuBarManager::dispose() menubarmanager.cxx:267
>     #12 0x138dccfa2 in framework::MenuBarManager::RemoveListener() menubarmanager.cxx:587
>     #13 0x138dcb452 in framework::MenuBarManager::Destroy() menubarmanager.cxx:237
>     #14 0x138dcd6d7 in framework::MenuBarManager::dispose() menubarmanager.cxx:267
>     #15 0x138e06acf in framework::MenuBarWrapper::dispose() menubarwrapper.cxx:103
>     #16 0x1389c0f67 in framework::LayoutManager::impl_clearUpMenuBar() layoutmanager.cxx:226
>     #17 0x1389c497b in framework::LayoutManager::implts_destroyElements() layoutmanager.cxx:447
>     #18 0x1389c3777 in framework::LayoutManager::implts_reset(bool) layoutmanager.cxx:413
>     #19 0x1389edf4b in framework::LayoutManager::frameAction(com::sun:⭐:frame::FrameActionEvent const&) layoutmanager.cxx:2811
>     #20 0x138b9e1a8 in (anonymous namespace)::Frame::implts_sendFrameActionEvent(com::sun:⭐:frame::FrameAction const&) frame.cxx:3110
>     #21 0x138b8219b in (anonymous namespace)::Frame::setComponent(com::sun:⭐:uno::Reference<com::sun:⭐:awt::XWindow> const&, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XController> const&) frame.cxx:1557
>     #22 0x138b88545 in (anonymous namespace)::Frame::close(unsigned char) frame.cxx:1801
>     #23 0x12078429a in SfxFrame::DoClose() frame.cxx:127
>     #24 0x120812990 in SfxViewFrame::Notify(SfxBroadcaster&, SfxHint const&) viewfrm.cxx:1234
>     #25 0x11ab542d5 in SfxBroadcaster::Broadcast(SfxHint const&) SfxBroadcaster.cxx:50
>     #26 0x1203a0682 in SfxModelListener_Impl::notifyClosing(com::sun:⭐:lang::EventObject const&) objxtor.cxx:171
>     #27 0x1204453d2 in SfxBaseModel::close(unsigned char) sfxbasemodel.cxx:1372
>     #28 0x1245130d5 in SwXTextDocument::close(unsigned char) unotxdoc.cxx:621
>     #29 0x1247af99b in CloseModelAndDocSh(com::sun:⭐:uno::Reference<com::sun:⭐:frame::XModel>&, tools::SvRef<SfxObjectShell>&) unomailmerge.cxx:115
>
> previously allocated by thread T0 here:
>     #0 0x10d32752b in wrap__Znwm asan_new_delete.cc:106
>     #1 0x118eafa18 in AquaSalInstance::CreateMenu(bool, Menu*) salmenu.cxx:230
>     #2 0x1177d75e0 in PopupMenu::PopupMenu() menu.cxx:2711
>     #3 0x1177d7664 in PopupMenu::PopupMenu() menu.cxx:2710
>     #4 0x129136557 in VclPtr<PopupMenu> VclPtr<PopupMenu>::Create<>() vclptr.hxx:131
>     #5 0x1291362de in VCLXMenu::ImplCreateMenu(bool) vclxmenu.cxx:73
>     #6 0x1291463ca in VCLXPopupMenu::VCLXPopupMenu() vclxmenu.cxx:901
>     #7 0x129146414 in VCLXPopupMenu::VCLXPopupMenu() vclxmenu.cxx:900
>     #8 0x138dc5e83 in framework::MenuBarManager::FillMenuManager(Menu*, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XFrame> const&, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XDispatchProvider> const&, rtl::OUString const&, bool) menubarmanager.cxx:1354
>     #9 0x138dc2316 in framework::MenuBarManager::MenuBarManager(com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XFrame> const&, com::sun:⭐:uno::Reference<com::sun:⭐:util::XURLTransformer> const&, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XDispatchProvider> const&, rtl::OUString const&, Menu*, bool, bool) menubarmanager.cxx:140
>     #10 0x138dc72bd in framework::MenuBarManager::MenuBarManager(com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XFrame> const&, com::sun:⭐:uno::Reference<com::sun:⭐:util::XURLTransformer> const&, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XDispatchProvider> const&, rtl::OUString const&, Menu*, bool, bool) menubarmanager.cxx:138
>     #11 0x138dc57bc in framework::MenuBarManager::FillMenuManager(Menu*, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XFrame> const&, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XDispatchProvider> const&, rtl::OUString const&, bool) menubarmanager.cxx:1304
>     #12 0x138dc2316 in framework::MenuBarManager::MenuBarManager(com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XFrame> const&, com::sun:⭐:uno::Reference<com::sun:⭐:util::XURLTransformer> const&, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XDispatchProvider> const&, rtl::OUString const&, Menu*, bool, bool) menubarmanager.cxx:140
>     #13 0x138dc72bd in framework::MenuBarManager::MenuBarManager(com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XFrame> const&, com::sun:⭐:uno::Reference<com::sun:⭐:util::XURLTransformer> const&, com::sun:⭐:uno::Reference<com::sun:⭐:frame::XDispatchProvider> const&, rtl::OUString const&, Menu*, bool, bool) menubarmanager.cxx:138
>     #14 0x138e07ba5 in framework::MenuBarWrapper::initialize(com::sun:⭐:uno::Sequence<com::sun:⭐:uno::Any> const&) menubarwrapper.cxx:181
>     #15 0x138f32e6d in framework::MenuBarFactory::CreateUIElement(rtl::OUString const&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&, char const*, rtl::OUString const&, com::sun:⭐:uno::Reference<com::sun:⭐:ui::XUIElement> const&, com::sun:⭐:uno::Reference<com::sun:⭐:uno::XComponentContext> const&) menubarfactory.cxx:154
>     #16 0x138f31848 in framework::MenuBarFactory::createUIElement(rtl::OUString const&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) menubarfactory.cxx:63
>     #17 0x138f3313a in non-virtual thunk to framework::MenuBarFactory::createUIElement(rtl::OUString const&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) menubarfactory.cxx:56
>     #18 0x138f56f6e in (anonymous namespace)::UIElementFactoryManager::createUIElement(rtl::OUString const&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) uielementfactorymanager.cxx:450
>     #19 0x138f5a94a in non-virtual thunk to (anonymous namespace)::UIElementFactoryManager::createUIElement(rtl::OUString const&, com::sun:⭐:uno::Sequence<com::sun:⭐🫘:PropertyValue> const&) uielementfactorymanager.cxx:408
>     #20 0x1389ca5da in framework::LayoutManager::implts_createElement(rtl::OUString const&) layoutmanager.cxx:731
>     #21 0x1389d6fb4 in framework::LayoutManager::createElement(rtl::OUString const&) layoutmanager.cxx:1482
>     #22 0x11fbd36f1 in SfxDispatcher::SetMenu_Impl() dispatch.cxx:1216
>     #23 0x11fbc36dc in SfxDispatcher::Update_Impl(bool) dispatch.cxx:1290
>     #24 0x11fb7556d in SfxBindings::NextJob_Impl(Timer*) bindings.cxx:1459
>     #25 0x11fb8ad4c in SfxBindings::NextJob(Timer*) bindings.cxx:1441
>     #26 0x11fb61177 in SfxBindings::LinkStubNextJob(void*, Timer*) bindings.cxx:1439
>     #27 0x11898aea1 in Link<Timer*, void>::Call(Timer*) const link.hxx:84
>     #28 0x11898add6 in Timer::Invoke() timer.cxx:88
>     #29 0x1188dae6d in ImplSchedulerData::Invoke() scheduler.cxx:47

Change-Id: I16d5b11710ee46dbaa77afd94a09ba5f07a311b0
 2016-11-07 08:59:16 +01:00
Stephan Bergmann
4e3e87e88d Adapt jurt staticsalhack to MACOSX 
Change-Id: I0525b68cdb097edd3241809ae0dc9c22e1ad9814
 2016-11-07 08:57:33 +01:00
Stephan Bergmann
9ec4c4ab05 Don't rely on __builtin_alloca when creating a call stack 
same as 3f7c8ce1dca7eacb511def7799691be2e3d9a4a6 for gcc_linux_x86-64 (see there
for a more detailed commit message; plus trivial follow-up
5e04886917abad0541eb3ef6d51cd5dc0395af21 "Remove spurious vertical whitespace").
Except use labels 'Lpush', 'Lpushed' not starting with a dot ('.Lpush',
'.Lpushed'), as otherwise at least macOS 10.12.1 linker (ld64-274.1), when
building libgcc3_uno.dylib's __TEXT,__unwind_info section, would use
callvirtualmethod.o's __LD,__compact_unwind entry---covering the complete
callVirtualMethod function---only for the first part of the function up to the
.Lpush label, and would mark the remainder as having no unwind information (a
compact_unwind_encoding_t value of 0; see the inline comments in the
libunwind-35.3 source code,
<http://opensource.apple.com/source/libunwind/libunwind-35.3/>).  So if an
exception shall pass through that latter part it would lead to std::terminate.

Change-Id: Ib1e8a5e4534b11ebe96c3ce774f8e5e8d45476cf
 2016-11-07 08:54:58 +01:00
Stephan Bergmann
c01e02425e Drop unnecessary nFPR parameter 
same as 8a85f9f29f13805af449943990af8af8399ab7b5 for gcc_linux_x86-64 (see there
for a more detailed commit message)

Change-Id: Ic2765c21834aabf8f7690c0bdab4d6efe6d34585
 2016-11-07 08:54:58 +01:00
Stephan Bergmann
6daac9adb4 Drop unused nGPR parameter 
same as aa04177e7c43d75bc87875a9d8ce2393d7263822 for gcc_linux_x86-64

Change-Id: I2c1e203271aa0038b83c3c55a37eab59411a6857
 2016-11-07 08:54:58 +01:00
Miklos Vajna
f996a5a153 basic: fix Android build 
rtl::math::round() is fine here, I guess.

Change-Id: I4d92bc191182ff531e11d20ef87c69dc99da2b32
 2016-11-07 08:03:34 +01:00
Noel Grandin
c0c69ccd2a convert sdr::animation::EventList to o3tl::sorted_vector 
instead of home-grown linked list

Change-Id: I7cf24692e7b9919ac83e404e2d0167c3015b97de
Reviewed-on: https://gerrit.libreoffice.org/30569
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 06:39:41 +00:00
Noel Grandin
496c0de160 inherit from ScXMLImportContext 
and drop a bunch of redundant code

Change-Id: I187273ad9eebeaf2446e09b2e3442e963d8ae4f4
Reviewed-on: https://gerrit.libreoffice.org/30568
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 06:39:21 +00:00
Noel Grandin
27513d4df5 loplugin:expandablemethods in sc 
Change-Id: Ib417c5e978fca563f8c0ef0dbe6b9d50fead9828
Reviewed-on: https://gerrit.libreoffice.org/30566
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 06:39:05 +00:00
Noel Grandin
7f509501e9 loplugin:oncevar in framework 
Change-Id: I7528a4afd59a19b069bcad2106ca80f429ef12e0
Reviewed-on: https://gerrit.libreoffice.org/30525
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 06:38:52 +00:00
Takeshi Abe
12ca2d6d32 Avoid crash when calling a Worksheet's ShowDataForm() 
in VBA, e.g.:
Option VBASupport 1
Sub Main
    Worksheets(1).ShowDataForm()
End Sub

Change-Id: Ice6cfccc4fc15a4d0044d6464c7d6c04243e86ae
Reviewed-on: https://gerrit.libreoffice.org/30619
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-07 06:38:02 +00:00
Khaled Hosny
8285af5e56 Disable VCL_FLOAT_DEVICE_PIXEL on macOS for now 
Causes subtle and surprising differences, and it was only needed for the
Core Text-based layout engine, which is not the default now. We want to
use floats for our text layout everywhere at some point, though, so lets
keep the code around.

Change-Id: Iac4d0f58992646b9357a9f32c5eea8ff2729a5c0
 2016-11-07 07:59:49 +02:00
Khaled Hosny
bd2ff93142 Set Kashida width also on macOS 
Otherwise we might not get any Kashida justification at all.

Change-Id: I6521d5a267392314d5d0da84b93fcd80c7b7cc57
 2016-11-07 07:52:21 +02:00
Khaled Hosny
639735edaf Fix thinkos in my previous commit 
Change-Id: I8f912f5a02933bdfb318dc4f946d4ad7471eb261
 2016-11-07 06:53:38 +02:00
Justin Luth
8eff1decd9 tdf#41542 MSWordExport: accommodate image's borderless padding 
Honor the padding value even if the border is not visible.
Previously the padding information was just thrown out, and
the image scaled to fill the entire image size.

The unit test for tdf#77454 needed to be tweaked because surprisingly
it has border padding of 1 - which this patch turns into a negative crop.

Change-Id: I866d26e00f27221239d3291404f70fb57ac0896d
Reviewed-on: https://gerrit.libreoffice.org/30578
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Justin Luth <justin_luth@sil.org>
 2016-11-07 04:09:41 +00:00