danielt998
2b31daf74e
tdf#95857 Sort out German plurals ...
...
Made a start in removing the incorrect 'Infos' German plural
Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60
Reviewed-on: https://gerrit.libreoffice.org/22301
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-12 15:29:25 +00:00
Chris Sherlock
a238b1f8d3
Remove excess newlines
...
A ridiculously fast way of doing this is:
for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
--exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
perl -0777 -i -pe 's/^
{3,}/
/gm' $i
done
Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09 08:18:05 +00:00
Andrea Gelmini
534b2a4b58
Fix typos
...
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3
Reviewed-on: https://gerrit.libreoffice.org/21797
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-05 06:48:38 +00:00
Chris Sherlock
697d445ed0
vcl: take into account the font width is the average font width
...
I'm changing the Font class function names:
- SetSize -> SetFontSize
- GetSize -> GetFontSize
- SetHeight -> SetFontHeight
- GetHeight -> GetFontHeight
- SetWidth -> SetAverageFontWidth
- GetWidth -> GetAverageFontWidth
That's because it really makes no sense to say that there is a
single constant font width because obviously proportional fonts
don't have one - the best we can do is an average font width,
which is what folks like Microsoft sort of do already. On a fixed
font, the average is still accurate, for obvious reasons :-)
I'm also not a fan of GetSize/SetSize as I find it a might too
generic.
Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70
Reviewed-on: https://gerrit.libreoffice.org/22069
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-04 03:17:26 +00:00
Noel Grandin
83b9c51803
sequence->vector in PrinterOptionsHelper
...
Change-Id: I643519397a4e714e3407ec0c3a10d329654b9f7d
Reviewed-on: https://gerrit.libreoffice.org/21887
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-31 07:09:41 +00:00
Chris Sherlock
d1a49df683
vcl: add text alignment functions to ImplFont and FontAttributes
...
ImplFont and FontAttributes now have GetAlignment and SetAlignment,
and I have renamed Font::GetAlign to Font::GetAlignment, and
Font::SetAlign to Font::SetAlignment.
See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor
and mutator for font scaling in FontMetric") for reasoning behind
patch.
Unit test added to vcl/qa/cppunit/font.cxx to test text alignment.
Change-Id: I6272c84fc9416c90616d957d1897eba9469fe7ba
Reviewed-on: https://gerrit.libreoffice.org/21876
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-29 01:59:55 +00:00
Stephan Bergmann
cd5431c071
Unwind trivial AccessibleExtendedComponentHelper_BASE typedefs
...
Change-Id: I74b30cba1359045873a3d7a3f0e72f857ffa0ed0
2016-01-27 10:23:48 +01:00
Samuel Mehrbrodt
867af25bd8
tdf#96683 Move tabs in Basic IDE to an own row
...
So that the tab height does not depend on the scrollbar height (which is subject to the desktop theme)
Change-Id: Ie2d787528152aed92c9943fe76955bf499d7d2a9
Reviewed-on: https://gerrit.libreoffice.org/21707
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-01-22 17:18:28 +00:00
Noel Grandin
a7f6efc68b
loplugin: unused return values
...
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af
Reviewed-on: https://gerrit.libreoffice.org/21571
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-18 12:50:09 +00:00
Chris Sherlock
28c96fc255
vcl: rename Font::GetName to Font::GetFamilyName
...
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f
Reviewed-on: https://gerrit.libreoffice.org/21529
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-17 23:35:37 +00:00
Norbert Thiebaud
45654a1d4d
revert vcl patch series that brok Mac and Windows
...
revert:
9bc2f3de8672e812f3a67541c6d7069b434a7e42
vcl: add comment about ImplFontMetric::{Get|Set}LineHeight()
26371f105bc44e04469ec03fc5bb12505e651c6b
vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic()
2dd0b4317372b8022efe3911b38b4fa02956d8b9
vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual
5ab13bf3ead3539e4ad847656da81e7eb6029652
vcl: tabify font.hxx
f99550dae55e40e49bf9c9875053fe2abb4c71ca
vcl: change Font::SetName() to Font::SetFamilyName()
2b297116cb6bb1061c43e5714e2609c8ee9f57d2
vcl: rename Font::GetName to Font::GetFamilyName
Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
2016-01-16 12:20:45 -06:00
Arnaud Versini
1ae5ceccb8
BASIC : Remove useless methods in StarBasic
...
Change-Id: I9e8ce92b967ee9c9485b7af15280f6a212ff599d
Reviewed-on: https://gerrit.libreoffice.org/21498
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-16 17:06:26 +00:00
Chris Sherlock
2b297116cb
vcl: rename Font::GetName to Font::GetFamilyName
...
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5
Reviewed-on: https://gerrit.libreoffice.org/21509
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16 16:11:28 +00:00
Stephan Bergmann
9ff5abf2e1
loplugin:privatebase: Make derivation from noncopyable explicitly private
...
Change-Id: Ia410950353aec0106ea82d025ed3ee89c79ca127
2016-01-11 13:17:07 +01:00
Noel Grandin
1b26a4eb4b
loplugin:unusedmethods unused return value in basctl
...
Change-Id: I23590020acbb9a6760edd755affa121a572aaea5
2016-01-11 10:49:24 +02:00
Andrea Gelmini
64d624b651
Fix typos
...
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
Arnaud Versini
5e0d36adc3
BASIC : use std::vector instead of SbArray for Modules.
...
Change-Id: I9594efb13b3dccc637ccd61eea4b42255c2a775c
Reviewed-on: https://gerrit.libreoffice.org/20817
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-07 12:18:40 +00:00
Matúš Kukan
5b22663e37
Make SotFactory private to sot/ and clean a bit
...
Change-Id: Ia683280a3e95eee995e036db6bde5d28852f92ff
2016-01-05 20:41:11 +01:00
Andrea Gelmini
fbec6ac089
Fix typos
...
Change-Id: I3fba2c76c83381eb398c80947ef4849bccf7ab27
Reviewed-on: https://gerrit.libreoffice.org/21078
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-05 13:40:54 +00:00
Matteo Casalin
cb98c423bb
sal_uLong/sal_uIntPtr/sal_uInt16 to sal_uInt32
...
also avoid some explicit temporaries and group some checks.
Change-Id: I7795b208dde53fd383b8c75f72dd9f56429aea2b
2015-12-27 16:51:27 +01:00
Noel Grandin
472388fda8
loplugin:unusedfields in basctl
...
Change-Id: I565bd86167c93ece1d65ce8a3b148144f5a7107a
2015-12-23 09:51:38 +02:00
Stephan Bergmann
fb8a3fac5d
loplugin:nullptr: More NULL -> nullptr automatic rewrite
...
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
2015-12-10 08:06:06 +01:00
Noel Grandin
a4af308d90
loplugin:unusedfields in include/svx
...
Change-Id: I946c64d103f3666e5bbff16d95a5c8e65a3750dc
2015-11-25 08:25:10 +02:00
Noel Grandin
ad278c2b3a
loplugin:unusedfields in basctl
...
and improve the plugin to search for only WARN_UNUSED and fundamental
types
Change-Id: Ic06207758e28d44d64d76d8119fd76b5b098bb05
2015-11-20 11:48:48 +02:00
Stephan Bergmann
b0339005b8
loplugin:sallogareas
...
Change-Id: I2220ab194384fb397716bf3227d38716ba54f537
2015-11-19 16:05:35 +01:00
Noel Grandin
8569c6d0ad
use initialiser list for Sequence<OUString>
...
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02
Reviewed-on: https://gerrit.libreoffice.org/19978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-16 08:35:42 +00:00
Noel Grandin
96c26b0d9d
use initialiser for Sequence<OUString>
...
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"
Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 12:20:39 +00:00
Caolán McNamara
0943adb2f7
Resolves: tdf#95021 crash on closing macro dialog editor
...
VclPtr related, dialog dtor is never called, so timer
is never stopped and timer refers to deleted parent
data
Change-Id: I804ba082817802c0017e61c6b86c5d3694995ea8
2015-11-12 12:27:10 +00:00
Stephan Bergmann
e7ab3554f5
loplugin:nullptr
...
Change-Id: If35c6033938f69d1a557828eacbad99968d25547
2015-11-11 16:15:29 +01:00
Oliver Specht
fa91dd31f3
5th step to remove tools/rtti.hxx
...
tools/rtti.hxx removed
completed the interface of some Sdr.* Items
and removed pseudo items
Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a
Reviewed-on: https://gerrit.libreoffice.org/19837
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-11 10:49:30 +00:00
Stephan Bergmann
4b0a3da4c5
loplugin:nullptr (automatic rewrite)
...
Change-Id: I27f1d5ee55338372b1c24187b63d23ae39e0a8b3
2015-11-10 10:31:16 +01:00
Noel Grandin
6c80a8fe89
new loplugin: oncevar
...
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09 08:34:40 +00:00
Stephan Bergmann
f508637ae3
loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
...
Change-Id: Ica41a359a75e2e7ad0402cb52cc6f2107f4fa002
2015-11-06 09:34:30 +01:00
Noel Grandin
59b072e22b
yyyyy
...
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-04 14:10:44 +02:00
Noel Grandin
065c8b48a6
use uno::Reference::set method instead of assignment
...
Change-Id: I58410209f32f988f258a588364e0b037c2790211
2015-10-30 08:10:22 +02:00
Tor Lillqvist
5eb7692ab8
tdf#95416: Get rid of #include "../foo/bar.hxx" style includes
...
Sample commit of what should be done, for the basctl module.
Change-Id: Ied47ea3129844179f2624c6870c05e48540fd0f6
2015-10-29 17:19:33 +02:00
Stephan Bergmann
2da77f3e13
loplugin:defaultparams
...
Change-Id: I8485bec1c31597e5a27db706a907eda788a053bf
2015-10-20 11:44:40 +02:00
Stephan Bergmann
1f0b89b5d2
loplugin:defaultparams
...
Change-Id: If39ad8e936b3a46de00770993a4a7c3676c676d2
2015-10-19 17:49:07 +02:00
Noel Grandin
c8479bdc5b
convert DBG_ASSERTWARNING to SAL_WARN_IF
...
I know the comment in debug.hxx said to use SAL_INFO, but SAL_WARN makes
much more sense.
Change-Id: I3d81f9db89ef8cebe1e4f2983941d69b4c7e6b7d
2015-10-19 13:08:29 +02:00
Noel Grandin
39e63bfac5
convert remaing DBG_WARNING to SAL_INFO
...
and drop the macro
Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-19 13:08:29 +02:00
Jan Holesovsky
e5be07f516
sfx items: Kill the unreadable SFX_REQUEST_ARG, use a template param instead.
...
Change-Id: I7130f7a84077a63cdc0ca1e131a4d90469eac90d
2015-10-16 12:12:27 +02:00
Jan Holesovsky
427c5dc6e0
sfx items: The bDeep parameter of SFX_REQUEST_ARG is always false.
...
Change-Id: I6d4f4cd09c83f94b26dd90577bdc6bc3226f58ab
2015-10-16 12:12:27 +02:00
Noel Grandin
6f1313b3d4
convert Link<> to typed
...
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6
Reviewed-on: https://gerrit.libreoffice.org/19405
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-16 09:11:29 +00:00
Noel Grandin
99b21cc9f3
convert Link<> to typed
...
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-15 09:58:34 +02:00
Stephan Bergmann
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Stephan Bergmann
bff4c13475
Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
...
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
Noel Grandin
3c99f8500f
convert Link<> to typed
...
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb
Reviewed-on: https://gerrit.libreoffice.org/19305
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12 10:48:13 +00:00
Julien Nabet
912268d49c
Prefer getSelectedFiles to getFiles (basctl)
...
Change-Id: I09cdad8770eba515c36220fbfb355220c9fa3bef
Reviewed-on: https://gerrit.libreoffice.org/19217
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-10-06 20:34:36 +00:00
Caolán McNamara
27728cc59f
Called C++ object pointer is null DBG_ASSERT->assert
...
Change-Id: I3094fc1728135fb9e8b229826cd2e30925e89b11
2015-10-05 14:51:50 +01:00
Stephan Bergmann
366d6ec035
clang-analyzer-deadcode.DeadStores
...
Change-Id: I886253de9980082186c41d361eb5a30e5f3923bc
2015-10-05 10:10:35 +02:00