Stephan Bergmann
ce92e1e518
clang-analyzer-deadcode.DeadStores
...
Change-Id: I039fa6b7fb666b4108b37d5aa17b2dcd42d2af53
2015-10-05 10:07:18 +02:00
Stephan Bergmann
ca69f1606e
Remove some unused includes
...
Change-Id: I4701ecd6be7dae64994397007fe13f30b6d7f64f
2015-10-02 21:19:29 +02:00
bureken
86a8c08a3f
tdf#94205 Use o3tl::make_unique instead of new + std::move
...
Change-Id: I27ed3c3fb826e7ce63b0bc12f7d17e18b21c9949
Reviewed-on: https://gerrit.libreoffice.org/19071
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-10-02 15:25:10 +00:00
Noel Grandin
e209d115d4
remove old standalone Sun bug numbers
...
Sun bug numbers without any accompanying text are completely useless.
Fixed with
git grep -lP '//\s*#\d+#\s*$'
| xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print'
And then hand-checking the result to restore places where it deleted code.
And then some more grepping and hand-editing to kill the others.
Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29
Reviewed-on: https://gerrit.libreoffice.org/19023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01 06:57:19 +00:00
Andrea Gelmini
9e4c87be31
Fix typos
...
Change-Id: Ie0e941d48457d758525353d6c5cf858652f86fd3
Reviewed-on: https://gerrit.libreoffice.org/18938
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 05:53:57 +00:00
Stefan Heinemann
c50eb68af3
Renamed wrongly prefixed boolean variables
...
Fixed tdf#94269
Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29 18:33:40 +00:00
Oliver Specht
d3c7c9ea81
tdf#94559: first step to remove rtti.hxx
...
replaced use of PTR_CAST, IS_TYPE, ISA in
avmedia, basctl, basic, cui, dbaccess, vcl,xmloff
Change-Id: If4496762e82e896b6fbc362e6626502703c245f5
Reviewed-on: https://gerrit.libreoffice.org/18905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-29 12:26:20 +00:00
Noel Grandin
e85b2333bc
convert Link<> to typed
...
Change-Id: I59d325c3b051690303a5841907317122fa1ec98b
Reviewed-on: https://gerrit.libreoffice.org/18825
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-24 16:19:37 +00:00
Caolán McNamara
599fab44ad
hide ScopedPtr::reset and add disposeAndClear
...
Change-Id: I55d6e789abd408b8478a2b9ae141d8899af2c309
Reviewed-on: https://gerrit.libreoffice.org/18745
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-21 19:34:16 +00:00
Noel Grandin
99bfc363a6
convert Link<> to typed
...
Change-Id: I10b050dc4aae45e646761a82520caa96969bc511
Reviewed-on: https://gerrit.libreoffice.org/18700
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-20 06:37:36 +00:00
Caolán McNamara
3a00aaef2a
boost->std
...
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-18 07:59:14 +00:00
Noel Grandin
1e2119fd02
convert Link<> to typed
...
Change-Id: I3d35a0bb75b6989dd13371543d1bdf3ef5f47641
2015-09-17 08:19:34 +02:00
Caolán McNamara
22b80ac8e2
boost->std
...
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c
Reviewed-on: https://gerrit.libreoffice.org/18564
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-14 12:54:25 +00:00
Stephan Bergmann
d8160fa834
Revert overly aggressive removal of include statements
...
...from 4758ab313de3cb2c8cb9ea5792425a808e94b7df "Removed useless includes in
basctl/source/basicide/ tree"
Change-Id: I754b964baf4c8a48f6ca79d6a214bab1f3325b6d
2015-09-13 22:17:46 +02:00
Stephan Bergmann
9aeac1b2dd
Use move semantics
...
Change-Id: I9ba8265044d0f83afe44b6965b78cc733cace653
2015-09-13 22:17:45 +02:00
Matteo Casalin
c5909e2518
Update many ListBox users to its sal_Int32 interface
...
Change-Id: I6469ac5e2d17406bee9bc434930e2471cb3bae9f
2015-09-12 14:18:50 +02:00
Noel Grandin
cf0c04a428
convert Link<> to typed
...
Change-Id: I85658fa35b9b85106a3b9c8ef303584cad6f39b0
2015-09-11 08:48:54 +02:00
Markus Mohrhard
5958c94274
no need to warn anymore as we can save VBA now
...
Well we will be able when this feature hits master.
Change-Id: I5547863e9002bfe16119a26059fa5281bd9e9070
2015-09-10 04:14:46 +02:00
Noel Grandin
78b124143a
convert Link<> to typed
...
Change-Id: I2f36a123662488ef5534f7bf0845d61e497fb0ec
2015-09-09 10:06:12 +02:00
Noel Grandin
6f4e11a95b
convert Link<> to typed
...
Change-Id: I2aeda615e39db5a3cd39e168db34425e2912be8b
2015-09-09 10:06:12 +02:00
Noel Grandin
5906a2a638
convert Link<> to typed
...
Change-Id: I184d836e944d6dcfd17233a7a83680f1c1bff9bf
2015-09-09 10:06:11 +02:00
Noel Grandin
2b30479d56
convert Link<> to typed
...
Change-Id: I4cbb32b6801386f0bef61f9f5c7cde7306c8b9f2
2015-09-08 08:16:48 +02:00
Noel Grandin
61623d5b90
convert Link<> to typed
...
Change-Id: I365a81a0a960f5da736c9a97aa056da16c99452f
2015-09-08 08:16:46 +02:00
Noel Grandin
2ec2247773
convert Link<> to typed
...
Change-Id: I743c74b134552eefb14d35e54491494160f1ffbd
2015-09-04 13:08:30 +02:00
Noel Grandin
4ea70f87f7
convert Link<> to typed
...
Change-Id: I2136c3db2742afcb4722f69297276bea1e0119f4
Reviewed-on: https://gerrit.libreoffice.org/18306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-04 06:31:30 +00:00
Noel Grandin
411e32244c
convert Link<> to typed
...
Change-Id: Ic15d0539aa00b46694a1715b6dda9d78bb1c00d8
Reviewed-on: https://gerrit.libreoffice.org/18269
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-03 07:21:26 +00:00
Noel Grandin
5beffcf3f1
convert Link<> to typed
...
Change-Id: Ic0482dc5ed26eb2fc6ccde73022eff8b4786de83
Reviewed-on: https://gerrit.libreoffice.org/18258
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-03 07:20:27 +00:00
Noel Grandin
5e7cf50756
SetXXX(bool) with a default value of false are just wrong
...
Change-Id: I4888d0474199bb10ca81d1ad03118a150f574671
Reviewed-on: https://gerrit.libreoffice.org/18235
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-02 07:14:20 +00:00
Noel Grandin
68ddda0f3f
convert Link<> to typed
...
Change-Id: I53b0a7a9875a3ebcca915c8f2d8c53face6f9509
2015-08-31 09:50:10 +02:00
Daniel Robertson
6900bf41e2
o3tl/cow_wrapper: remove boost dependency
...
Remove boost dependencies from ::o3tl::cow_wrapper, and add
the necessary includes to files including checked_delete and
noncopyable that do not already include the necessary files.
Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686
Reviewed-on: https://gerrit.libreoffice.org/18125
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-29 22:51:36 +00:00
Noel Grandin
bd8b93fdff
make PostUserEvent Link<> typed
...
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-28 09:49:56 +02:00
Stephan Bergmann
43c00bc489
Clean up aEmptyStr
...
Change-Id: I5befe9deac917a28e80ed193b67ff29b5ba35149
2015-08-26 21:24:29 +02:00
Noel Grandin
167bc621ef
Convert vcl Button Link<> click handler to typed Link<Button*,void>
...
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
2015-08-26 11:15:35 +02:00
Noel Grandin
3f02a38cfb
simplify, IsEmpty() checks both Right and Bottom already
...
Change-Id: I81fa9f80593bdea5098215f71c44b35e0087a6fc
2015-08-25 09:58:31 +02:00
Michael Meeks
f2f97ec5bf
tdf#93077 - basic dialog localization issues.
...
Don't remove non-existent languages to clean the dialog.
Avoid crashing when adding languages to a non-localized dialog.
Change-Id: Ie356177e00e56c214727d513ae0ce6d62d32591c
Reviewed-on: https://gerrit.libreoffice.org/17929
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-22 19:10:46 +00:00
Laurent Godard
47d1cb09e6
avoid autocorrection misreplacing
...
takes the last token in case of chained "." instead of the first one
to avoid
aa.b.
autocorrects (wrongly) to
aaaa.
Change-Id: Ibca68850282a0d3aec67ca518bdcbf1da676e155
Reviewed-on: https://gerrit.libreoffice.org/17858
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-20 09:24:15 +00:00
Laurent Godard
ddb43837ca
avoid basic ide crash in code autocompletion
...
due to code completion and user defined types
type MyType
a as string
b as string
end type
dim aa as MyType
typing
aa.b.
the last point led to crash
remaining problem
code autocorrection now shows wrong behaviour as
aa.b.
autocorrects (wrongly) to
aaaa.
Change-Id: I3e05680cd9d82f7dc124c5923f9858e22961896e
Reviewed-on: https://gerrit.libreoffice.org/17824
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-18 09:27:18 +00:00
Thorsten Behrens
ad1f0d1f1a
o3tl: rename compat_functional header
...
After the cleanup, the stuff there really stands on its own (and the
remaining usage of select1st/2nd is more descriptive than lambdas).
Change-Id: I0aba131d5dc550189f8130d167dc94167e404540
Reviewed-on: https://gerrit.libreoffice.org/17806
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-17 16:38:30 +00:00
Matteo Casalin
98244c3cb4
sal_uLong to sal_Int32/long
...
Change-Id: Ia4ae190da37351b8c2b7ee9fc953508c5b1ab062
2015-08-16 09:10:21 +02:00
Matteo Casalin
6917ebc39f
sal_uLong to sal_uInt32
...
Change-Id: Ifcde090747127680a9e4b810ff062d024663632c
2015-08-16 09:10:21 +02:00
Matteo Casalin
8353793c94
Use constants instead of (possibly wrong) magic numbers
...
Change-Id: I0829d271337b9fe77341c62a1c2ef4d6ae62c727
2015-08-16 09:10:20 +02:00
Matteo Casalin
9d0f86326c
Rework loops so to have exit condition on correct unsigned value
...
Change-Id: I91e647d6b1aebe8342f95c88fc81bd2c5a43ce71
2015-08-16 09:10:20 +02:00
Matteo Casalin
866e287ade
sal_uLong to sal_uInt32 as TextPaM paragraph number
...
Applied also to related functions.
Also fix a couple of minor issues while at it.
Change-Id: I615094d047c87a0f4854054e720492d3ab25c575
2015-08-16 09:10:19 +02:00
Noel Grandin
9045d0bf35
loplugin: defaultparams
...
Change-Id: I89796134a0cce33279ba7f02492857a656e8aee3
2015-08-14 10:52:46 +02:00
Caolán McNamara
e8620d35f7
Resolves: tdf#92896 wrong delete language dialog path
...
Change-Id: I720e95c6c5e8b613ef880aa65f5e8cdb85143b58
Reviewed-on: https://gerrit.libreoffice.org/17565
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-07 08:12:22 +00:00
Noel Grandin
50097a8bb2
basic,basctl: inline some use-once typedefs
...
Change-Id: I60619a5bfe9507fb5ed24123f62f6b5c2f2c8712
2015-08-04 08:55:56 +02:00
Matteo Casalin
44cd9ef88b
sal_uInt16 to sal_Int32, constify, minor optimizations
...
Change-Id: Icc41bbe09e495454ca27e9281eca6f4731a135c8
2015-08-01 19:33:22 +02:00
Matteo Casalin
2a57ea7a67
sal_uInt16 to sal_Int32
...
Change-Id: I723d7c187ec186ccc68f061ba2357712a5f31869
2015-08-01 19:33:20 +02:00
Noel Grandin
01075a7274
inline the "old" SbxErr constants
...
Change-Id: I1c54c792e0397d61c97d5067963b343f912275fc
2015-07-28 08:35:34 +02:00
Noel Grandin
9072c5c855
convert SbxFlagsBits to scoped enum
...
Change-Id: I3dd699ca675be2ff4a8bfb7938bd5d43719b304c
2015-07-28 08:35:34 +02:00