2933 Commits

Author SHA1 Message Date
Noel Grandin
472388fda8 loplugin:unusedfields in basctl
Change-Id: I565bd86167c93ece1d65ce8a3b148144f5a7107a
2015-12-23 09:51:38 +02:00
Tor Lillqvist
d2df0adad4 No need for a separate <vcl/lstbox.h>
Change-Id: Ib8d0e3d240e693c678d575b4791f69ca760919ec
2015-12-12 09:26:29 +02:00
Tor Lillqvist
a643222794 No need for a separate <vcl/graph.h>
Change-Id: I962544005b5d408f7c044a02eefe09b87d8a81fe
2015-12-11 19:11:01 +02:00
Tor Lillqvist
c95a6adceb No need for a separate <vcl/combobox.h>
Change-Id: Iebf7b44e78fc28c20bdf0cbea84dbfd730b04016
2015-12-11 15:53:35 +02:00
Stephan Bergmann
fb8a3fac5d loplugin:nullptr: More NULL -> nullptr automatic rewrite
Change-Id: Ie83819e2bcdc5fa160b39296b005ca9a5ff74b1d
2015-12-10 08:06:06 +01:00
Noel Grandin
a4af308d90 loplugin:unusedfields in include/svx
Change-Id: I946c64d103f3666e5bbff16d95a5c8e65a3750dc
2015-11-25 08:25:10 +02:00
Samuel Mehrbrodt
4a27c2c778 Remove last redundant toolbar:style properties
Change-Id: I42fa834464fd4cd7f0c1f11e310c1145fb1f071b
2015-11-20 11:42:50 +01:00
Noel Grandin
ad278c2b3a loplugin:unusedfields in basctl
and improve the plugin to search for only WARN_UNUSED and fundamental
types

Change-Id: Ic06207758e28d44d64d76d8119fd76b5b098bb05
2015-11-20 11:48:48 +02:00
Samuel Mehrbrodt
b60e464cb6 Remove redundant toolbar:style="radio" property
Change-Id: I56969839a93af975466ab6c28f2f87557e4d7f1b
Reviewed-on: https://gerrit.libreoffice.org/20074
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-11-20 09:37:55 +00:00
Samuel Mehrbrodt
42a950178c Remove redundant toolbar:style attributes
These have been defined in the widgets

Change-Id: If46a6862872286a454804846128bd8658f60af9b
2015-11-19 17:29:51 +01:00
Stephan Bergmann
b0339005b8 loplugin:sallogareas
Change-Id: I2220ab194384fb397716bf3227d38716ba54f537
2015-11-19 16:05:35 +01:00
Noel Grandin
8569c6d0ad use initialiser list for Sequence<OUString>
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02
Reviewed-on: https://gerrit.libreoffice.org/19978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-16 08:35:42 +00:00
Ashod Nakashian
06116bd15b Fast PCH generator and optimized PCH files
Ported update_pch.sh to Python with improved performance
and features. The new script is invoked from the same
update_pch.sh which calls it for each library in
parallel, although it can be invoked directly.

The ported script (update_pch) updates all PCH files
in ~15 seconds where the old script took ~4500 seconds.
In addition, the new script supports 3-tiered headers
(system, module, and local) and is very flexible to
support other improvement. It has a per-library
optimal configuration settings that can be updated
using another new scripts (update_pch_autotune.sh)
which finds optimal per-PCH settings.

PCH files have been generated using the new scripts
which builds significantly faster (2-3x, depending
on module and configuration) and the intermediate
binaries are noticably smaller (by several GBs).

The new script stamps each generated PCH file with
the command that generated it to make it trivial
for users to update them, and also adds the command
to invoke another script (update_pch_bisect) that
helps find missing headers or conflicting headers
that may break the build after updating the PCH.

Finally update_pch has built-in unit-tests for
makefile parsing and other core functionality.

Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa
Reviewed-on: https://gerrit.libreoffice.org/19965
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-15 20:31:35 +00:00
Noel Grandin
96c26b0d9d use initialiser for Sequence<OUString>
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"

Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 12:20:39 +00:00
Caolán McNamara
0943adb2f7 Resolves: tdf#95021 crash on closing macro dialog editor
VclPtr related, dialog dtor is never called, so timer
is never stopped and timer refers to deleted parent
data

Change-Id: I804ba082817802c0017e61c6b86c5d3694995ea8
2015-11-12 12:27:10 +00:00
Stephan Bergmann
e7ab3554f5 loplugin:nullptr
Change-Id: If35c6033938f69d1a557828eacbad99968d25547
2015-11-11 16:15:29 +01:00
Oliver Specht
fa91dd31f3 5th step to remove tools/rtti.hxx
tools/rtti.hxx removed
completed the interface of some Sdr.*  Items
and removed pseudo items

Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a
Reviewed-on: https://gerrit.libreoffice.org/19837
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-11 10:49:30 +00:00
Stephan Bergmann
4b0a3da4c5 loplugin:nullptr (automatic rewrite)
Change-Id: I27f1d5ee55338372b1c24187b63d23ae39e0a8b3
2015-11-10 10:31:16 +01:00
Noel Grandin
6c80a8fe89 new loplugin: oncevar
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09 08:34:40 +00:00
Stephan Bergmann
f508637ae3 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
Change-Id: Ica41a359a75e2e7ad0402cb52cc6f2107f4fa002
2015-11-06 09:34:30 +01:00
Noel Grandin
59b072e22b yyyyy
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-04 14:10:44 +02:00
Noel Grandin
065c8b48a6 use uno::Reference::set method instead of assignment
Change-Id: I58410209f32f988f258a588364e0b037c2790211
2015-10-30 08:10:22 +02:00
Tor Lillqvist
5eb7692ab8 tdf#95416: Get rid of #include "../foo/bar.hxx" style includes
Sample commit of what should be done, for the basctl module.

Change-Id: Ied47ea3129844179f2624c6870c05e48540fd0f6
2015-10-29 17:19:33 +02:00
Stephan Bergmann
2da77f3e13 loplugin:defaultparams
Change-Id: I8485bec1c31597e5a27db706a907eda788a053bf
2015-10-20 11:44:40 +02:00
Stephan Bergmann
1f0b89b5d2 loplugin:defaultparams
Change-Id: If39ad8e936b3a46de00770993a4a7c3676c676d2
2015-10-19 17:49:07 +02:00
Noel Grandin
c8479bdc5b convert DBG_ASSERTWARNING to SAL_WARN_IF
I know the comment in debug.hxx said to use SAL_INFO, but SAL_WARN makes
much more sense.

Change-Id: I3d81f9db89ef8cebe1e4f2983941d69b4c7e6b7d
2015-10-19 13:08:29 +02:00
Noel Grandin
39e63bfac5 convert remaing DBG_WARNING to SAL_INFO
and drop the macro

Change-Id: I452ca373d0c277166e94928c1bce78bf37e39d7c
2015-10-19 13:08:29 +02:00
Jan Holesovsky
e5be07f516 sfx items: Kill the unreadable SFX_REQUEST_ARG, use a template param instead.
Change-Id: I7130f7a84077a63cdc0ca1e131a4d90469eac90d
2015-10-16 12:12:27 +02:00
Jan Holesovsky
427c5dc6e0 sfx items: The bDeep parameter of SFX_REQUEST_ARG is always false.
Change-Id: I6d4f4cd09c83f94b26dd90577bdc6bc3226f58ab
2015-10-16 12:12:27 +02:00
Noel Grandin
6f1313b3d4 convert Link<> to typed
Change-Id: Icbba339dac0be31e30dff021bba06a219f8aecd6
Reviewed-on: https://gerrit.libreoffice.org/19405
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-16 09:11:29 +00:00
Noel Grandin
99b21cc9f3 convert Link<> to typed
Change-Id: I6c55c74d47b13149c2fa210bb9de4e8c430c57cc
2015-10-15 09:58:34 +02:00
Stephan Bergmann
b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Stephan Bergmann
bff4c13475 Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
Noel Grandin
3c99f8500f convert Link<> to typed
Change-Id: Iec15042138e0715459b2c9e872a7464d75a6b1eb
Reviewed-on: https://gerrit.libreoffice.org/19305
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12 10:48:13 +00:00
Julien Nabet
912268d49c Prefer getSelectedFiles to getFiles (basctl)
Change-Id: I09cdad8770eba515c36220fbfb355220c9fa3bef
Reviewed-on: https://gerrit.libreoffice.org/19217
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-10-06 20:34:36 +00:00
Caolán McNamara
27728cc59f Called C++ object pointer is null DBG_ASSERT->assert
Change-Id: I3094fc1728135fb9e8b229826cd2e30925e89b11
2015-10-05 14:51:50 +01:00
Stephan Bergmann
366d6ec035 clang-analyzer-deadcode.DeadStores
Change-Id: I886253de9980082186c41d361eb5a30e5f3923bc
2015-10-05 10:10:35 +02:00
Stephan Bergmann
ce92e1e518 clang-analyzer-deadcode.DeadStores
Change-Id: I039fa6b7fb666b4108b37d5aa17b2dcd42d2af53
2015-10-05 10:07:18 +02:00
Stephan Bergmann
ca69f1606e Remove some unused includes
Change-Id: I4701ecd6be7dae64994397007fe13f30b6d7f64f
2015-10-02 21:19:29 +02:00
bureken
86a8c08a3f tdf#94205 Use o3tl::make_unique instead of new + std::move
Change-Id: I27ed3c3fb826e7ce63b0bc12f7d17e18b21c9949
Reviewed-on: https://gerrit.libreoffice.org/19071
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-10-02 15:25:10 +00:00
Noel Grandin
e209d115d4 remove old standalone Sun bug numbers
Sun bug numbers without any accompanying text are completely useless.

Fixed with
   git grep -lP '//\s*#\d+#\s*$'
       | xargs perl -i -ne'/\/\/\s*#\d+#\s*$/d or print'
And then hand-checking the result to restore places where it deleted code.
And then some more grepping and hand-editing to kill the others.

Change-Id: Ia96ce4466db8bb8da363ebf41f0ae7f45f28bf29
Reviewed-on: https://gerrit.libreoffice.org/19023
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01 06:57:19 +00:00
Andrea Gelmini
9e4c87be31 Fix typos
Change-Id: Ie0e941d48457d758525353d6c5cf858652f86fd3
Reviewed-on: https://gerrit.libreoffice.org/18938
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 05:53:57 +00:00
Stefan Heinemann
c50eb68af3 Renamed wrongly prefixed boolean variables
Fixed tdf#94269

Change-Id: I63109cc4e095bad680d7637a065080ea368860ae
Reviewed-on: https://gerrit.libreoffice.org/18851
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-29 18:33:40 +00:00
Oliver Specht
d3c7c9ea81 tdf#94559: first step to remove rtti.hxx
replaced use of PTR_CAST, IS_TYPE, ISA in
avmedia, basctl, basic, cui, dbaccess, vcl,xmloff

Change-Id: If4496762e82e896b6fbc362e6626502703c245f5
Reviewed-on: https://gerrit.libreoffice.org/18905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-29 12:26:20 +00:00
Cor Nouws
421b17a602 tdf#94497 UI: Object catalog not available in menu > View in BasicIDE
Change-Id: I996723cf3af8365d078103bb54d469f7a2c735fe
Reviewed-on: https://gerrit.libreoffice.org/18838
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-25 10:15:19 +00:00
Noel Grandin
e85b2333bc convert Link<> to typed
Change-Id: I59d325c3b051690303a5841907317122fa1ec98b
Reviewed-on: https://gerrit.libreoffice.org/18825
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-24 16:19:37 +00:00
Caolán McNamara
599fab44ad hide ScopedPtr::reset and add disposeAndClear
Change-Id: I55d6e789abd408b8478a2b9ae141d8899af2c309
Reviewed-on: https://gerrit.libreoffice.org/18745
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-21 19:34:16 +00:00
Noel Grandin
99bfc363a6 convert Link<> to typed
Change-Id: I10b050dc4aae45e646761a82520caa96969bc511
Reviewed-on: https://gerrit.libreoffice.org/18700
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-20 06:37:36 +00:00
Caolán McNamara
3a00aaef2a boost->std
Change-Id: Ie490bf2c6921f393bdeed96b1a8815996b701bf0
Reviewed-on: https://gerrit.libreoffice.org/18670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-18 07:59:14 +00:00
Noel Grandin
1e2119fd02 convert Link<> to typed
Change-Id: I3d35a0bb75b6989dd13371543d1bdf3ef5f47641
2015-09-17 08:19:34 +02:00