mir/libreoffice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
403,714 Commits 1 Branch 0 Tags
Commit Graph

2933 Commits

Author SHA1 Message Date
Stephan Bergmann
fce88d8ff0 loplugin:stringconstant: Flag more inefficiencies 
Change-Id: I7c79445bfa1536706561752da107090599ef26a2
 2015-06-25 12:38:33 +02:00
Michael Meeks
6a6d7766f4 tdf#92258 - fix crash editing macro module name. 
Change-Id: I8e0bbab7d7497ed7c136ddbfba73618834d5a204
 2015-06-24 17:28:58 +01:00
Noel Grandin
07d85c4499 remove SFX_NOTIFY macro 
it has not served any purpose since we switched to using normal C++ RTTI
for the SfxHint objects

Change-Id: Ic81353bcb7863ce892eb75296248ca14d8fd6c86
 2015-06-24 12:06:34 +02:00
Jan Holesovsky
5ca1936975 rendercontext: Mass fix of using the wrong size. 
In the paints, we must use the size of the Window for the computations, not of
the RenderContext - the RenderContext can be much bigger than the Window in
the double-buffering case.

Fixes for example the list boxes, and many others.

Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6
 2015-06-23 10:32:28 +02:00
Andrea Gelmini
aade27554d Fix typos 
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-22 12:36:21 +00:00
Lionel Elie Mamane
a58affd770 protect against NULL current SfxViewShell 
Change-Id: I748493de799902f5acf905c7ce919e3ebbf1a800
 2015-06-17 14:38:46 +02:00
Andrea Gelmini
3fa7b0b70f Fix typos 
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e
Reviewed-on: https://gerrit.libreoffice.org/16310
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-16 11:25:13 +00:00
Andrea Gelmini
9b7e1bf43d Fix typos 
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41
Reviewed-on: https://gerrit.libreoffice.org/16295
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-16 10:59:53 +00:00
Noel Grandin
4ea281a3cc cppcheck:redundantAssignment 
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
 2015-06-15 13:34:14 +02:00
Noel Grandin
5a2e09989a cppcheck:redundantCondition 
Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
 2015-06-15 11:56:55 +02:00
Julien Nabet
b226928c6d cppcheck: redundantCondition [part1] 
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
 2015-06-14 12:17:55 +02:00
Noel Grandin
776a3f14f2 convert expressions like 'size() == 0' to 'empty()' 
Change-Id: Ia5c8c0f38a347f398d587970a22e03f29ffd37af
 2015-06-11 10:07:08 +02:00
Caolán McNamara
88b104f44a coverity#1302618 deref of NULL 
on examination this PreparePaint virtual is only called from
SvTreeListBox::PaintEntry1

and PaintEntry1 is only called from SvImpLBox::Paint in a

    for(sal_uInt16 n=0; n< nCount && pEntry; n++)
    {
        /*long nMaxRight=*/
        pView->PaintEntry1

loop so pEntry always exists given that test. Re-jig things
so these families of method take a reference instead of a pointer
so verifying it cannot be NULL and a whole pile of else paths
fall away

Change-Id: Ied40acb1c2263c21b4447832f8cb86f64ed9e80d
 2015-06-10 22:11:33 +01:00
Stephan Bergmann
d7b2fe39be loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: I6ea774c635335106a7a8ddc4214c20bdf3f021ba
 2015-06-08 16:23:13 +02:00
Noel Grandin
3f72218069 Apply new VclPtr clang plugin to catch potential problems. 
Omit the plugin, and sw's FrameControlsManager for now.

Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f
Reviewed-on: https://gerrit.libreoffice.org/16117
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2015-06-06 20:26:54 +00:00
Caolán McNamara
c0d6bc75b2 Resolves: tdf#90361 CellValueBinding/CellRangeListSource need WithArguments 
otherwise they are not initialized and every call on them throws.  This at
least results in the dialog editor not falling over immediately on inserting
anything in calc.

Change-Id: Ie1668ef440937c75dd08671c669c021c2efecd2a
 2015-06-05 14:53:24 +01:00
Noel Grandin
81610561ed uno::Sequence provides now begin and end 
use begin() and end() when calling std::copy on an uno::Sequence

Inspired by commit b34b648fc3262c5d9aa295f621e8fe9c97d4c6b2
"uno::Sequence provides now begin and end"

Change-Id: I08e8c3fd6144e77b95a26f85bc0daf6a9edeeb0b
Reviewed-on: https://gerrit.libreoffice.org/16057
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-06-04 06:35:44 +00:00
Stephan Bergmann
cfd6a855bf loplugin:cstylecast: deal with those that are (technically) const_cast 
Change-Id: I625929f9cfa3a2d403d0a4652e57c2bb7a998fa6
 2015-06-02 11:25:15 +02:00
Michael Meeks
ba81e5c6bd tdf#91702 - fix stack-based MessBox allocation. 
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7
Reviewed-on: https://gerrit.libreoffice.org/15954
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2015-05-29 12:16:28 +00:00
Tomaž Vajngerl
0af0211b0f tdf#91484 fix macro editor - Invalidate in paint 
Change-Id: I787da9a665e54caea229def185076b29c00fd11e
 2015-05-29 18:25:09 +09:00
Noel Grandin
e0b2e6e3f7 loplugin:loopvartoosmall 
Change-Id: Icbe68b31d4ab04ca3cd9f572e3598413946a75c7
 2015-05-29 08:48:41 +02:00
Philippe Jung
1379e2feaa Rewrite all calls like Dialog(params).Execute() 
Replace all calls looking like
  ADialog(some params).Execute()
by
  ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute()

Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639
Reviewed-on: https://gerrit.libreoffice.org/15915
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
 2015-05-28 08:44:31 +00:00
Noel Grandin
dbca69b975 tdf#91575 - CRASH: when "My Macros & Dialogs Standard" window close 
Change-Id: Iad4f67e78a0aa4c67f0c450e17278f873944aa23
 2015-05-26 12:42:56 +02:00
Noel Grandin
204d147b8a convert SCROLL constants to scoped enum 
Change-Id: I5696fa39b2d032735cea7abe039349d4f83cf68d
 2015-05-26 08:30:19 +02:00
Noel Grandin
e929194317 convert POINTER constants to scoped enum 
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19
Reviewed-on: https://gerrit.libreoffice.org/15825
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-05-22 06:32:35 +00:00
Caolán McNamara
3dd259ffa1 coverity#1298898 coverity seems a little confused here 
Change-Id: Ibc80e242b8fda8fb304ed5cd1a52716d1b7fc33d
 2015-05-20 09:08:11 +01:00
Noel Grandin
23b439a664 convert DEFAULTCONSTANT constant to scoped enum 
Change-Id: I5ebd77edfa29d6c6c7acea37e826ef1d625916c3
 2015-05-20 09:52:09 +02:00
Noel Grandin
25a47c5cd5 convert TEXT_DRAW constants to scoped enum 
Change-Id: Ic0f7f8fa236bb478b3598ae3fd3c1b30ebbf1a01
 2015-05-20 09:52:08 +02:00
Noel Grandin
ae451af87d basic: used typed LINKs 
Change-Id: I8770a782e7ff5529e30aee13558711bdd8a4070d
 2015-05-19 11:10:54 +02:00
Caolán McNamara
4b5091cfd7 cppunit: noExplicitConstructor 
Change-Id: Iaf1387ea236bf3a5db9b2165d5b827dbdcf95207
 2015-05-18 17:14:15 +01:00
Noel Grandin
368291e75d basctl: Use typed Links 
Change-Id: I0e0b6086852c06df88e1b623d4631f364eb28b09
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2015-05-18 16:59:00 +02:00
Caolán McNamara
0c0228c488 callcatcher: update unused code 
Change-Id: I43dd399368953c629916dad8104a296f837a6344
 2015-05-18 15:50:02 +01:00
Tomaž Vajngerl
b4bbb5e5d7 refactor how font, fg. and bg. are applied in widgets/controls 
- Move vcl::RenderContext to outdev.
- Change some methods on vcl::Window to accept RenderContext
  as parameter.
- Add ApplySettings to vcl::Window - This method is called before
  painting. Refactor existing classes that use InitSettings to
  have ApplySettings or mark the classes to be refactored later.
- Add RenderSettings for adding defered settings to rendering.
  This is similar to ApplySettings but for more ad-hoc calls.

Change-Id: I4ea58461f3b6b08ccfa3e0ddd1a4a3e04f8c4f45
 2015-05-18 11:22:49 +09:00
Michael Meeks
33414c8bf7 tdf#91239 - return VclPtr's from Create Fn.s and add missing dispose logic. 
Change-Id: I802b841040f608b5586704745cc9817603fb1879
 2015-05-15 19:05:46 +01:00
Julien Nabet
72e6c70738 tdf#91239 - add missing disposeAndClear logic for basctl. 
Change-Id: If5c8fbf453e47921b472a987e9e6cff283464dcf
 2015-05-15 19:05:46 +01:00
Andrea Gelmini
5b1337f7b2 tdf#62475: partial handmade fixes 
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4
Reviewed-on: https://gerrit.libreoffice.org/15712
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2015-05-15 17:55:15 +00:00
Caolán McNamara
6cbdd2a141 cppcheck: noExplicitConstructor 
Change-Id: I42d135456c7f9ce8bbd77db553be96149e4e75af
 2015-05-14 16:13:21 +01:00
Noel Grandin
741d9990bf convert QUICKHELP constants to scoped enum 
Change-Id: Ie7302c909feb2e83b8b5e62a5e6a1f901783fb49
 2015-05-14 12:00:40 +02:00
Tomaž Vajngerl
607582291e refactor "basctl" classes to use RenderContext 
Change-Id: I6eb54af9f793c614c823123c6f16a3dc4f3a0c0b
 2015-05-14 09:58:14 +09:00
Michael Meeks
936a496467 Switch VclBuilder constructors to use VclPtr. 
Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
 2015-05-12 09:40:38 +01:00
Michael Meeks
667910530d Revert "Switch VclBuilder constructors to use VclPtr." 
Behaves oddly; not ready yet.

This reverts commit 9f016bd69422bdfb4cf7c4f5e57356eb98db2d8c.

Change-Id: I30d746eac29d1dbe78d3072b10d2e22c051e3f4e
 2015-05-11 16:28:22 +01:00
Michael Meeks
9f016bd694 Switch VclBuilder constructors to use VclPtr. 
Change-Id: Id35a86eb52bbde6ca09a5e61a0b1a79b23be8faf
 2015-05-11 15:12:08 +01:00
Noel Grandin
82d68f9cbc convert COMMAND_ constants to scoped enum 
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95
Reviewed-on: https://gerrit.libreoffice.org/15671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-05-11 12:17:42 +00:00
Stephan Bergmann
000c31c384 loplugin:cstylecast: nop between pointer types of exactly same spelling 
Change-Id: I13f6c41a9918363d1b91d64ab2b8c331d007561a
 2015-05-11 12:48:59 +02:00
Tomaž Vajngerl
25a0bd7b90 refactor TreeListBox to use RenderContext 
Change-Id: I901a1f1f9732fb66718dca34c698a851e5b0d87f
 2015-05-11 10:03:29 +09:00
Stephan Bergmann
9bb254fc85 NOINSTANCE is implied now in IMPL_STATIC_LINK... 
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
 2015-05-10 11:25:47 +02:00
Stephan Bergmann
4a760a8d0b Replace IMPL_STATIC_LINK[_TYPED] with more useful variants 
Change-Id: Ic59c2c9079dce37ad76b6a1396a719d372253674
 2015-05-10 11:25:42 +02:00
Michael Meeks
266ce1cd53 tdf#91052 - more macros for 'make' constructors. 
Change-Id: Id05266810760f73db2daba10d1efa14aa9f88dd9
 2015-05-09 21:39:57 +01:00
Stephan Bergmann
5eb6bd4db7 lopluign:staticmethods: Handle DECL_LINK 
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
 2015-05-08 19:15:32 +02:00
Noel Grandin
2c8dc03733 convert BUTTONDIALOG constants to scoped enum 
Change-Id: Icbf73fe55ad604f762dd2b98fd39189bab82f061
Reviewed-on: https://gerrit.libreoffice.org/15648
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-05-07 13:27:55 +00:00