2933 Commits

Author SHA1 Message Date
Noel Grandin
2391931e21 convert SFXOBJECTSHELL_ constants to scoped enum
Change-Id: I5a159be0c342b778730cedb0fe35843c2c368c97
2015-04-10 09:48:07 +02:00
Noel Grandin
afc728fe76 convert SFXMODEL_ to scoped enum
and fix up some confusion in SC and STARMATH about which constants to
use

Change-Id: Ib75bc78a24bd2fad6ec6d7c94c4c1ad7dc222c1a
2015-04-10 09:48:07 +02:00
Michael Meeks
954e5e4b78 prophylactic double dispose audit.
Change-Id: Ia18c0b7a76fb0894efe33afaf69a0079c4583228
2015-04-09 22:35:14 +01:00
Noel Grandin
00f2787a4a vclwidgets: wrap all vcl::Window subclasses allocated on stack in VclPtr
Change-Id: Ia8b0d84bbf69f9d8f85505d019acdded14e25133

Conflicts:
	sw/qa/tiledrendering/tiledrendering.cxx
2015-04-09 22:17:00 +01:00
Noel Grandin
25edbe68db vcl: VclPtr conversion in various
Change-Id: Id4f0cc26e4f5bda345f41130c9838fc44312e98e
2015-04-09 21:35:14 +01:00
Noel Grandin
d380e713bc vcl: VclPtr conversion in basctl
Change-Id: Ieea1ab9426ed025d7d0f8baba8a6d10cb454e93e
2015-04-09 21:23:03 +01:00
Noel Grandin
14505bb67e loplugin:staticmethods
Change-Id: I715374b531da2850434b2436633b6042ecb9ebe0
2015-04-09 11:01:06 +02:00
Stephan Bergmann
54e87df11f Change INetProtocol enumerators to CamelCase
...to avoid clashes with macros and poor warnings about hiding global FILE

Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02 18:33:37 +02:00
Stephan Bergmann
44b3e56bb4 Change INetProtocol to scoped enumeration
...and fix o3tl::enumarray::operator [] const overload

Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-04-02 16:30:34 +02:00
Stephan Bergmann
a5a5fae1fa Replace remaining getCppuType et al with cppu::UnoType
Change-Id: I24164f5fe3654445190ca26856188a33070e7544
2015-04-01 08:35:23 +02:00
Stephan Bergmann
7e3139de9c Reduce to static_cast any reinterpret_cast from void pointers
Change-Id: Icaec7ce94a915945ff464d0734115c729e740c83
2015-03-31 13:12:04 +02:00
Stephan Bergmann
989f0ec573 Clean up C-style casts from pointers to void
Change-Id: I0db5c02e9fbc09fe7d85e46f1434c86b5b5b4853
2015-03-28 19:09:17 +01:00
Noel Grandin
28a1e1dded fix macro and enum name collision using CamelCase
so that the enum names remain consistent

Change-Id: I656069b484038d3bf17ecbb4f3e26395ca5a1b6d
2015-03-27 09:33:39 +02:00
Noel Grandin
93ddb2cc0b convert BUTTON_ constants to enum class
Change-Id: I0fd391a6b2850e5d7dcbf2cb95cfa39ee5561bd9
2015-03-27 08:33:43 +02:00
Stephan Bergmann
21997319a3 const_cast: convert some C-style casts and remove some redundant ones
Change-Id: I43f7a4c372502214c6f36413077d686921dba73b
2015-03-26 15:33:28 +01:00
Noel Grandin
72ddf425c2 loplugin:constantfunction: basctl
Change-Id: I675b6cee53a9cef240dd798b13515141e194828f
2015-03-24 10:31:17 +02:00
Noel Grandin
799a7878fd convert SFX_PRINTER constants to enum class
Change-Id: I5dca39f7668be2c03c904c33b6181ba769b70990
2015-03-24 09:36:59 +02:00
Noel Grandin
fba2d764d8 convert SfxPopupWindowType to enum class
Change-Id: I03813103d648c5745beab740403c7912cdff2756
2015-03-24 09:36:59 +02:00
Pranav Kant
33de587e95 tdf#88230: cleanup solar mutex yielding
Use SolarMutexReleaser, instead.

Change-Id: I276459c42b688813ea168d6fc80466a07a5ecba4
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2015-03-20 12:18:02 +00:00
Noel Grandin
3f18d628ec loplugin:constantfunction: sot
this appears to be completely unused

Change-Id: I74dad8b0c478a1aed035ce9cc663a74de157816e
2015-03-19 10:45:01 +02:00
Noel Grandin
4e6410ba01 loplugin:constantfunction: unotools
Change-Id: Icf543973dc9edde270016c8af7e4c08c57eff650
2015-03-19 10:45:00 +02:00
Noel Grandin
fb14be5f8f create new 'enum class' SotClipboardFormatId to unify types
of which there are several.

There are some issues here I am unsure of
- the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids
  Perhaps I should change them to use the common values and create new enum values where necessary?
- the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff
   numeric values to the underlying code, but perhaps further fixing is necessary?

Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
2015-03-18 14:23:50 +02:00
Swachhand Lokhande
b1534edf52 tdf#89592 Using initializer_lists to populate Sequence<PropertyValue>
Change-Id: Idef9dd55eb1719eaf592bc4a86440cbd5aa4fb32
Reviewed-on: https://gerrit.libreoffice.org/14781
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-03-10 10:26:59 +00:00
Caolán McNamara
938caeaf58 cppcheck: cstyleCast
Change-Id: I3a1aaafe30f13f2eb388f7db3d78ecafaf0a4a2d
2015-03-09 16:27:47 +00:00
Tobias Madl
8f9b0c8692 Idle: Changed to new enum name
Change-Id: Id3852abe9bc7bbe774331a7d691abd2a79ff59b4
2015-03-06 12:27:10 +00:00
Tobias Madl
2d95bc0510 Idle: Removed VCL_IDLE_PRIORITY_ prefix of enum
Change-Id: I12290bed7e4f298ab90393b8de6e2b6e7061e53f
2015-03-06 12:27:09 +00:00
Tobias Madl
57656eb1fa Idle and Timer are now completely independent
And everything is functionating pretty well.

Change-Id: Id7f5a995362f6f7c5235f2e9facb7c7f119f3140
2015-03-06 12:27:06 +00:00
Tobias Madl
826143684d Timer: Adapted all idle includes and enum uses
Change-Id: Id4ef36d6c80ad62306bdbaa7094c2cb0b8ff77da
2015-03-06 12:27:05 +00:00
Caolán McNamara
c622304965 V813: Decreased performance
Change-Id: Ica2563d9e8da15e19eb38246d4de54a1fcb75655
2015-03-04 00:51:57 +00:00
Noel Grandin
3c866bb8e4 replace SVX_SEARCHCMD_ constants with enum class
Change-Id: I675c488742219cc19624a21d1fc8e5033e7cbefa
2015-03-02 08:59:18 +02:00
Noel Grandin
ba233e87ef remove unnecessary parenthesis in return statements
found with
$ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;'

Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-23 09:26:58 +02:00
Caolán McNamara
3744d8506e boost->std
Change-Id: I8371b942d915f777a29ca01cd0aed674db0ca853
2015-02-17 16:24:05 +00:00
Radu Ioan
a8e6f0bea0 tdf#39440 - cppcheck cleanliness
Fixed some cppcheck defects

Change-Id: I25fd6aba9d76df98d20b9a1bb4c9d3c1bf6f84bb
Reviewed-on: https://gerrit.libreoffice.org/14487
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-17 06:15:54 +00:00
Noel Grandin
9f8ffc8dfe add GetSelectEntryData to ListBox and ComboBox
to reduce code clutter like
    pLbSelect->GetEntryData(pLbSelect->GetSelectEntryPos())
since this is a fairly frequent operation.

Change-Id: I41daf30fdeda2442ad1ac829e12f553233bae184
Reviewed-on: https://gerrit.libreoffice.org/14472
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-16 06:38:42 +00:00
Caolán McNamara
f8b80701e0 these can all be made const
Change-Id: I6a8af82e8612196f20143f4997eb95c80a2ca13d
2015-02-12 10:53:18 +00:00
Laurent Godard
d8a9c74f41 BASIC IDE : add the current procedure name in the status bar
Change-Id: Icecef1748bcc964670b0b95263314d9d8a4555f0
Reviewed-on: https://gerrit.libreoffice.org/14367
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-12 10:49:39 +00:00
Michael Stahl
5b8947a093 coverity#1268024 coverity#1267686: basctl: uncaught exception
DlgEdObj::_propertyChange() should have same exception spec. as
XPropertyChangeListener::propertyChange().

Change-Id: I8d5b628b7cc382dae55a9e17bf813fba647453eb
2015-02-10 14:49:23 +01:00
Stephan Bergmann
d25b49fb17 loplugin:deletedspecial
Change-Id: I71bfb6628bb746498ff47d6d9aba50e150757144
2015-02-07 12:35:55 +01:00
Ashod Nakashian
de68bb8514 Updated all precompiled headers.
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157
Reviewed-on: https://gerrit.libreoffice.org/14292
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-05 10:46:33 +00:00
Caolán McNamara
f08169c775 coverity#1267686 Uncaught exception
Change-Id: Iab9067590cd15b3b60cfa2a98ee6be30d2fdf13d
2015-02-01 22:10:37 +00:00
Noel Grandin
f61dbc3029 followup code removal after changing virtual methods to non-virtual
This cleanups up indentation and removes dead classes.

This is a followup patch to commit
272b1dd55797aacf511fb4342b0054e3697243f6
"new loplugin: change virtual methods to non-virtual"

Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26 08:42:29 +02:00
Noel Grandin
b44cbb26ef new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-26 08:42:28 +02:00
Tsutomu Uchino
15d2655fb6 Resolves: #i120772# do not ignore last three properties...
when special properties not found in watching window

(cherry picked from commit 8815f3f3fbb3632cccbbf8476f4c40c9bda8eb6e)

Conflicts:
	basctl/source/basicide/baside2b.cxx

Change-Id: I6069d55b9f894846a7b4d81b981cf4523b444753
2015-01-12 20:21:35 +00:00
Noel Grandin
5333782d09 convert SETTINGS_ #defines to 'enum class'
and dump the ones that nothing is listening to

Change-Id: I253ef284df785812a439dd160edba1b07fdbaac4
2015-01-12 12:57:05 +02:00
Noel Grandin
a5b5ad9f93 fdo#84938: replace DATACHANGED_ constants with 'enum class'
and drop DATACHANGED_DATETIME because no-one is using it

Change-Id: Id5ac9a7fbba0e35501ed82e5252f66858621f7ff
2015-01-12 12:57:04 +02:00
Michael Stahl
2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-09 00:00:47 +01:00
Noel Grandin
7f8f277b94 fdo#84938: convert STREAM_ #defines to 'enum class'
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-07 11:20:44 +02:00
Juan Picca
5573fd8cf9 fdo#39596: replace cstyle casts
Change-Id: I1a0814ec973b1dc0f4db4ee88a999d9ffc219e7a
Reviewed-on: https://gerrit.libreoffice.org/13701
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-05 10:06:36 +00:00
Adolfo Jayme Barrientos
adfc260b4b fdo#67343 Arrange Help button in a secondary group
This helps de-clutter action button groups and eases visual scanning.

This patch also contains little layout tweaks where needed to separate
the Help button from its neighbors when the dialog is too small.

Change-Id: I56aafdaf2a5351bd7bcb4db693e520fd5c5166ce
Reviewed-on: https://gerrit.libreoffice.org/13427
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-05 10:01:21 +00:00
Caolán McNamara
7f476fea47 boost::unordered_map -> c++11 std::unordered_map
Change-Id: I28438000c2b0a8e6ce4f5640f861f572c0cb83c8
2014-12-27 23:00:45 +00:00