1274 Commits

Author SHA1 Message Date
Noel Grandin
397a0afd3b convert B2VectorOrientation to scoped enum
Change-Id: Id7e444bc896ae5d52e5a0bd1b471679c4945afa4
2015-06-04 08:30:24 +02:00
Zsolt Bölöny
d0f6f00c1a Replaced boost::tuple with std::tuple
Change-Id: Ia001c8e1e00df85d2be93e330811a1081179785d
Reviewed-on: https://gerrit.libreoffice.org/15816
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-02 13:20:02 +00:00
Zsolt Bölöny
4fe7a99c4b Remove B1IRange, it's not used anywhere
Change-Id: I2eeded849b9b36611407e8ecc545d7801939e4c9
Reviewed-on: https://gerrit.libreoffice.org/15815
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-01 08:09:39 +00:00
Zsolt Bölöny
7a4e796889 Remove B1IBox, it's not used anywhere
Change-Id: Ifff5fc008552f80fcbb705013c1f578f5f825b24
Reviewed-on: https://gerrit.libreoffice.org/15814
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-01 08:08:02 +00:00
Noel Grandin
d5129a9dd6 new clang plugin: loopvartoosmall
Idea from bubli - look for loops where the index variable is of such
size that it cannot cover the range revealed by examining the length
part of the condition.

So far, I have only run the plugin up till the VCL module.

Also the plugin deliberately excludes anything more complicated than a
straightforward incrementing for loop.

Change-Id: Ifced18b01c03ea537c64168465ce0b8287a42015
2015-05-28 12:49:54 +02:00
Zsolt Bölöny
bda06661d8 Remove B3IPoint, it's not used anywhere
Change-Id: I7031c126179bbceebc40dcbdab5a0570db5bc29f
Reviewed-on: https://gerrit.libreoffice.org/15813
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-27 14:44:05 +00:00
Zsolt Bölöny
b37b5e115f B3IVector is not used anywhere
Change-Id: Ic439b33c974500f1b351b41a0e391ffec71007b3
Reviewed-on: https://gerrit.libreoffice.org/15808
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-27 13:46:57 +00:00
Zsolt Bölöny
135ced89b2 Remove B3IRange, it's not used anywhere
Change-Id: I19a6835eaab2efba530d30f871f1b4509b683801
Reviewed-on: https://gerrit.libreoffice.org/15812
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-27 13:45:38 +00:00
Zsolt Bölöny
19fc914aa6 Remove B3I64Tuple, it's not used by anything
Change-Id: Ie1b05375a8e8d634e6ef6b2bf6edde65b32574bd
Reviewed-on: https://gerrit.libreoffice.org/15811
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-26 08:44:57 +00:00
Thorsten Behrens
cd6ee5de8e comments: fix mis-use of eventual in English
The adjective was used as the German meaning, which translates to
maybe or possibly.

Change-Id: Iaf5b38f628b23796829a1c4bd3919d4e13b874f0
2015-05-24 21:50:20 +02:00
Julien Nabet
07dd5958fa Typo: Trapeziod->Trapezoid
Change-Id: Iab575622819e245b1459cba72dc34a9c387d00b6
2015-05-23 11:05:41 +02:00
Zsolt Bölöny
e346aa639c Use the better precision equality check in b2trapezoid.cxx
Change-Id: Ie048543ad19c12dc47f6638af7dc029a38da964e
Reviewed-on: https://gerrit.libreoffice.org/15805
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-21 19:45:24 +00:00
Zsolt Bölöny
15a7ae3e80 That was totally pointless
Change-Id: I6046461b2e26a8506249c4a2fdd783bbd2ec223f
Reviewed-on: https://gerrit.libreoffice.org/15810
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-19 19:38:14 +00:00
Caolán McNamara
4b5091cfd7 cppunit: noExplicitConstructor
Change-Id: Iaf1387ea236bf3a5db9b2165d5b827dbdcf95207
2015-05-18 17:14:15 +01:00
Takeshi Abe
5a7c1bc635 simplify code by replacing std::find_if with std::any_of/std::none_of
Change-Id: Ife6ab3544f73b1de60f5241c68466045161a4d88
Reviewed-on: https://gerrit.libreoffice.org/15615
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07 14:03:42 +00:00
Tor Lillqvist
3363f828d6 Drop misused lcl_ prefix
If used at all, lcl_ is supposed to be used for static functions truly local
to one source files. The functions here occur in several source files (well,
two, the one where they are defined and one other) so they are not "local" in
that sense. (But they could be local in the one file that uses them...) Also,
they are already in a basegfx::internal namespace.

While at it, drop the :: prefix eyesore from basegfx::internal, and align
parameter lists consistently.

Change-Id: I68b91075e0b1779ac0fa884d8f9e956f1ab7b308
2015-05-05 10:59:11 +03:00
Stephan Bergmann
eafd09e9fd More loplugin:simplifybool
Change-Id: Ic0e8d409e33dcc494a6111eba9ba405424ecd53f
2015-04-27 15:30:52 +02:00
Caolán McNamara
9e25f276d9 fix crash on export of ooo30155-1.sxw to odt
Change-Id: I1dd087ea6803f29756e1b78385a4a98f7378e616
2015-04-21 12:13:44 +01:00
Noel Grandin
44790193a7 loplugin:staticfunction
Change-Id: I982ba552579019e4902ae59fddf14a6b34ba5954
2015-03-27 10:51:08 +02:00
Noel Grandin
9bccd26037 convert CUTFLAG_ constants to enum class
Change-Id: I98dc5488954a4d46f7e0158790a4c3dabebfc1b3
2015-03-27 08:33:44 +02:00
Caolán McNamara
32f95a3551 V813: Decreased performance
Change-Id: I8a7528366156b288dc422b09cff0d5a32cde3c91
2015-03-04 13:07:40 +00:00
Radu Ioan
a8e6f0bea0 tdf#39440 - cppcheck cleanliness
Fixed some cppcheck defects

Change-Id: I25fd6aba9d76df98d20b9a1bb4c9d3c1bf6f84bb
Reviewed-on: https://gerrit.libreoffice.org/14487
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-17 06:15:54 +00:00
Ashod Nakashian
de68bb8514 Updated all precompiled headers.
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157
Reviewed-on: https://gerrit.libreoffice.org/14292
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-05 10:46:33 +00:00
Markus Mohrhard
b2462b3fea remove unused file
Change-Id: I8cc33007e99da38869daa48ff898593abc52c4ac
2015-01-18 16:36:26 +01:00
Zsolt Bölöny
babe4ab629 Removed lcl_putNumberChar() from basegfx.
It just calls OUStringBuffer.append() and doesn't do anything special.

Change-Id: Ie59a797a8d0d24cfab826516e2b5c4e58f90dd01
Reviewed-on: https://gerrit.libreoffice.org/13850
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-12 06:44:04 +00:00
Caolán McNamara
6b084f0001 asan: global-buffer-overflow on fdo55736-1.docx
Change-Id: If69a57aa9ff011cc670f868cb87b3a1c4d904435
2015-01-08 20:58:51 +00:00
Łukasz Hryniuk
9fd89a5952 fdo#39440 reduce scope of local variables
Beside scope changes, it fixes lack of initialization in a few places.

Change-Id: Ia09fdb9845d8ac17256330a5ec5168401c84f0f2
Reviewed-on: https://gerrit.libreoffice.org/13755
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-01-07 06:47:04 +00:00
Michael Weghorn
3338f47918 reduce scope of local variables
This eliminates some of the warnings from Cppcheck report of
2014-11-29.

Change-Id: Id5bf885de12a6de262d2cca9fa71627ac67f50d9
Reviewed-on: https://gerrit.libreoffice.org/13330
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-08 08:01:58 +00:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Louis-Francis Ratté-Boulianne
03c6479fd3 basegfx: Solve crossovers even if there is only one polygon in the polypolygon
Change-Id: If4fcb8a2c6ac40a4d694522ce4ed020bcb4466b8
2014-11-10 07:59:42 +01:00
Caolán McNamara
12bcfec04f markup with event type not checker type
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05 14:58:00 +00:00
Stephan Bergmann
a00bae79f9 Fix --disable-sal-log builds
Change-Id: Ie0250745c9bd39e6e81f5f9eb96e661de2e4e2ef
2014-10-28 11:54:34 +01:00
Caolán McNamara
17a0efcea5 coverity#1242792 Unused value
Change-Id: Iec4c69e7fea727cc507506b9570f1f6d0c20a70f
2014-10-28 10:31:26 +00:00
Armin Le Grand
e6bd33d442 Resolves: #i125447# corrected some string to number conversion...
tools to correct svg:d imports

(cherry picked from commit f077f99da3cb2903fa903dcf30e6cfd714fd009c)

Conflicts:
	basegfx/source/inc/stringconversiontools.hxx
	basegfx/source/tools/stringconversiontools.cxx

Change-Id: I7de1558682990f83e66fdded3d9d30e21e4f97fe
2014-10-08 14:58:43 +01:00
Caolán McNamara
fb6d3b883b disambiguate uniform_int_distribution
Change-Id: Ifa0c1b1983d1cc7f22d55b15dee88b7f709dbcf8
2014-10-07 14:21:16 +01:00
Caolán McNamara
8f436d3de7 use comphelper::rng::uniform_*_distribution everywhere
and automatically seed from time on first use

coverity#1242393 Don't call rand
coverity#1242404 Don't call rand
coverity#1242410 Don't call rand and additionally allow 0xFF as a value
coverity#1242409 Don't call rand
coverity#1242399 Don't call rand
coverity#1242372 Don't call rand
coverity#1242377 Don't call rand
coverity#1242378 Don't call rand
coverity#1242379 Don't call rand
coverity#1242382 Don't call rand
coverity#1242383 Don't call rand
coverity#1242402 Don't call rand
coverity#1242397 Don't call rand
coverity#1242390 Don't call rand
coverity#1242389 Don't call rand
coverity#1242388 Don't call rand
coverity#1242386 Don't call rand
coverity#1242384 Don't call rand
coverity#1242394 Don't call rand

Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-10-06 14:13:27 +01:00
Caolán McNamara
4fb93e9899 coverity#1242792 Unused value
Change-Id: I66000e2e3ae8d28f5f04bb6404c73feb2a1e8905
2014-10-03 16:30:29 +01:00
Noel Grandin
c9d4a2887c fdo#82577: Handle PolyPolygon
Put the TOOLS PolyPolygon class in the tools namespace. Avoids clash with the Windows
PolyPolygon typedef.

Change-Id: I811ecbb3d55ba4ce66e4555a8586f60fcd57fb66
2014-09-30 11:47:41 +02:00
Noel Grandin
8e58d9d08c loplugin: cstylecast
Change-Id: I8b1f0f6c100b4cf6d45c9e0c0f1e0a38ec081218
2014-09-22 14:36:14 +02:00
Stephan Bergmann
ca87db7da4 basegfx: sal_False/True -> false/true
Change-Id: I56eb340317d8b7991caad58dd0e4045d6e69fca9
2014-09-15 18:22:37 +02:00
Stephan Bergmann
dc4b82a030 Fixed some CppunitTest names
Change-Id: I57b039c7114c03944e8eaba9ca1bb81da563640a
2014-08-28 15:06:58 +02:00
Armin Le Grand
5554be7f4c Related: #i125349# refined to exclude possible recursive calls
(cherry picked from commit a02eb39b84d130e5923f72edb2abb3b21adf6fff)

Change-Id: Id068928f77a6efed44da9b83ecbf547302826591
2014-08-07 20:34:49 +01:00
Armin Le Grand
1ca06ce59b Related: #i125349# moved clip enhancements to base clipping functionality
(cherry picked from commit 7c5e9b9b3c5c899d63bf171ee1c9050db860337e)

Change-Id: I570e92c78196895bef329eb308eeb68ffc5e23d3
2014-08-07 20:34:49 +01:00
Caolán McNamara
45c2c02720 coverity#983561 Arguments in wrong order
and

coverity#983562 Arguments in wrong order

Change-Id: Ia9e95c8c5dbbf0a12ac06162e4fc3ff5e568f035
2014-08-07 18:00:53 +01:00
Caolán McNamara
092e10a582 coverity#983562 Arguments in wrong order
attempt to silence this warning

Change-Id: Icd8fa41a63bd3fe70b956f7af1818325b471e0f6
2014-08-07 18:00:53 +01:00
Markus Mohrhard
1d99fde435 no need to declare the variable outside of the loop
Change-Id: I4f910494114f7dd965a75f3f9482153e0268b89c
2014-07-06 02:15:20 +02:00
Markus Mohrhard
a7b81ceaa6 use empty instead of size to check if vector is empty
Change-Id: I6c90b95bdf2de441594d5d5c36f76e6aeeb74011
2014-07-06 02:15:20 +02:00
Markus Mohrhard
10f696d103 remove unnecessary whitespaces in basegfx
Change-Id: Ia97fb3895e855e9fb970b0874fc100e2b900a8b7
2014-07-06 02:15:20 +02:00
Matúš Kukan
3a8d0c0ff5 isFinished() not really used
Change-Id: I5558177fe61adbbff191042f1be22ecb0ce8f11a
2014-06-25 08:17:45 +02:00
David Tardon
8fae55c7d3 fdo#79615 create clipping polygon correctly
Change-Id: I758b6bc8da33a20a0807da171120a8f84214dcfd
2014-06-23 17:15:06 +02:00