2154 Commits

Author SHA1 Message Date
Stephan Bergmann
c26d6edbc1 LEAK_STATIC_DATA is always defined for WNT
cppu_no_leak and bndchk were remnants from pre-gbuild times

Change-Id: Ie9f325c20e39c100b4a7180a9925559f58bcca6b
Reviewed-on: https://gerrit.libreoffice.org/34153
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-12 14:03:53 +00:00
Stephan Bergmann
61396df4f4 LEAK_STATIC_DATA is only ever defined for WNT
Change-Id: I1aa7b56b44e5efc8ad407c8d0fe09927f622b5e7
2017-02-11 18:32:05 +01:00
Stephan Bergmann
8646ab97dc Remove MinGW support
In OOo times, there'd originally been efforts to allow building on Windows with
MinGW.  Later, in LO times, this has been shifted to an attempt of cross-
compiling for Windows on Linux.  That attempt can be considered abandoned, and
the relevant code rotting.

Due to this heritage, there are now three kinds of MinGW-specific code in LO:

* Code from the original OOo native Windows effort that is no longer relevant
  for the LO cross-compilation effort, but has never been removed properly.

* Code from the original OOo native Windows effort that is re-purposed for the
  LO cross-compilation effort.

* Code that has been added specifially for the LO cross-compilation effort.

All three kinds of code are removed.

(An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing
--with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.)

Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568
Reviewed-on: https://gerrit.libreoffice.org/34127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-10 18:01:27 +00:00
Stephan Bergmann
5595ee701e loplugin:useuniqueptr
Change-Id: I3a246a22baaac8195dc1b94c42994de7d80e8336
2017-02-02 15:17:52 +01:00
Stephan Bergmann
5a3722b230 loplugin:stringconstant
Change-Id: Ic22b9c0c245cca23770a05518534a666e00f9f3e
2017-02-01 08:27:50 +01:00
Noel Grandin
f1d83ac45f loplugin:stringconstant check for unnecessary OUString constructor..
..calls when creating exceptions

Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe
Reviewed-on: https://gerrit.libreoffice.org/33617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-28 09:22:55 +00:00
Samuel Mehrbrodt
f86845b606 iOS bridge: Log function names, not string pointers
Change-Id: I5db7a014e671bbf4b4eca9fcbaba4fdc2363e0f5
Reviewed-on: https://gerrit.libreoffice.org/33053
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-13 15:47:12 +00:00
Stephan Bergmann
3024e891b2 Fix undefined misaligned writes
same as 26cf118247855bb5caeac3d8e68906fbcfcdc837 for gcc_linux_x86-64

Change-Id: Ieb7a4c0497ea485e832da937786226f09feeff31
2016-12-16 07:46:41 +01:00
Rene Engelhard
a2dafe2fc7 fix sparc64 bridges build
Change-Id: Ic8483547966a319d3ecc1ae2fd5dfb785132f687
2016-11-27 20:08:30 +01:00
Stephan Bergmann
d689ad29c2 New o3tl::runtimeToOUString to convert from C++ runtime NTBS to OUString
Change-Id: I613bb70b6828f615fd45af38b2d873ece55ace60
2016-11-23 23:11:02 +01:00
Stephan Bergmann
9ec4c4ab05 Don't rely on __builtin_alloca when creating a call stack
same as 3f7c8ce1dca7eacb511def7799691be2e3d9a4a6 for gcc_linux_x86-64 (see there
for a more detailed commit message; plus trivial follow-up
5e04886917abad0541eb3ef6d51cd5dc0395af21 "Remove spurious vertical whitespace").
Except use labels 'Lpush', 'Lpushed' not starting with a dot ('.Lpush',
'.Lpushed'), as otherwise at least macOS 10.12.1 linker (ld64-274.1), when
building libgcc3_uno.dylib's __TEXT,__unwind_info section, would use
callvirtualmethod.o's __LD,__compact_unwind entry---covering the complete
callVirtualMethod function---only for the first part of the function up to the
.Lpush label, and would mark the remainder as having no unwind information (a
compact_unwind_encoding_t value of 0; see the inline comments in the
libunwind-35.3 source code,
<http://opensource.apple.com/source/libunwind/libunwind-35.3/>).  So if an
exception shall pass through that latter part it would lead to std::terminate.

Change-Id: Ib1e8a5e4534b11ebe96c3ce774f8e5e8d45476cf
2016-11-07 08:54:58 +01:00
Stephan Bergmann
c01e02425e Drop unnecessary nFPR parameter
same as 8a85f9f29f13805af449943990af8af8399ab7b5 for gcc_linux_x86-64 (see there
for a more detailed commit message)

Change-Id: Ic2765c21834aabf8f7690c0bdab4d6efe6d34585
2016-11-07 08:54:58 +01:00
Stephan Bergmann
6daac9adb4 Drop unused nGPR parameter
same as aa04177e7c43d75bc87875a9d8ce2393d7263822 for gcc_linux_x86-64

Change-Id: I2c1e203271aa0038b83c3c55a37eab59411a6857
2016-11-07 08:54:58 +01:00
Stephan Bergmann
fee419ae25 clang-cl loplugin: bridges
Change-Id: I46bcc6eb1f34184626d2f584d7164d84f54c2cf8
Reviewed-on: https://gerrit.libreoffice.org/29879
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-16 14:19:31 +00:00
Michael Stahl
b647996a9b replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)
... except in include/rtl, include/sal, include/uno, where sal_Size is
retained for compatibility, and where callers of rtl functions pass in
pointers that are incompatible on MSVC.

Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-15 12:01:11 +02:00
Stephan Bergmann
6af14d2d18 loplugin:override
Change-Id: I25cbca130c3e075d614d9bbb63b6264e8e73c165
2016-09-13 23:55:33 +02:00
Stephan Bergmann
91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
Tor Lillqvist
ef5e3bfc71 SAL_FALLTHROUGH
Change-Id: I9b13e20b873e919aef93e5c7548112c47f57612e
2016-08-20 23:39:19 +03:00
Tor Lillqvist
5a833144b5 SAL_FALLTHROUGH
Change-Id: I347c13b282ccbd40a5e2e4a504f0c8ee1882d602
2016-08-10 16:36:48 +03:00
James Clarke
3cb45765f2 (initial) sparc64 port
Change-Id: I8ec9bb5415a9e6b9083ba89a7790872d67625de1
2016-08-05 18:09:59 +02:00
Caolán McNamara
f5f0758080 Revert "hack for now"
This reverts commit f5792667cafef77cc4c142f4261f8b64280bc0fe.

it turns out it was the use of an intermediate GtkGrid which made a11y work
a little differently under gtk3. Clearly not intended to be pushed.

Change-Id: I6931163e07ea413acdd45ba1353f357d317fdfbd
2016-07-19 23:38:14 +01:00
Caolán McNamara
f5792667ca hack for now
Change-Id: I62673e60ac8785c74fc4f97ad76bcb02c7e28941
2016-07-19 22:33:34 +01:00
Stephan Bergmann
f541b99855 loplugin:nullptr: Better heuristic to determine code shared between C and C++
Change-Id: I51e1c5fa4639e51fac90f92adf3d87d12960d589
2016-07-11 14:32:07 +02:00
Stephan Bergmann
99db9f2295 Make --enable-symbols orthogonal to --enable-debug/-dbgutil
Change-Id: I523bc1d848e40489370eefe00046e0a257ed2505
Reviewed-on: https://gerrit.libreoffice.org/27058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-11 08:57:55 +00:00
Muhammet Kara
b6b34d5383 Clarify calculation precedence tdf#39440
Use parentheses to clarify the code.

Change-Id: I864dc6dacadb5b9ba9dca8e0abd9fa4e6db1eddc
Reviewed-on: https://gerrit.libreoffice.org/25677
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-05 09:35:40 +00:00
Michael Stahl
8ad0fb82d4 bridges: [loplugin:staticanonymous]
Change-Id: I9d2c233c7060ea5c7a6bc028a8146ee8b2fd555b
2016-06-21 18:20:26 +02:00
Michael Stahl
67f3a9a48f bridges: [loplugin:nullptr]
Change-Id: I7386569030fc95553bfb423d23d291430388992b
2016-06-21 18:20:26 +02:00
Michael Stahl
371ddde018 bridges: [loplugin:salbool]
Change-Id: I1924f2b18763e42013c2b5ce80b664674e460fc7
2016-06-21 18:20:26 +02:00
Michael Stahl
d7777467a3 bridges: -Werror,-Wimplicit-fallthrough
Change-Id: I1ad51d4dc7e6bddfc5fa8d6252a7d6349bd5dfb7
2016-06-21 18:20:25 +02:00
Gökhan Gurbetoğlu
3b197594d8 tdf#39440 Reduced the scope of the variable c
Change-Id: I14cf653a661664eeb31015bf8aa94f7c140dd87f
Reviewed-on: https://gerrit.libreoffice.org/26002
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-06-08 06:03:08 +00:00
Tor Lillqvist
e0849330bc Get rid of unnecessary directory levels $D/inc/$D
Change-Id: Ibf313b8948a493043006ebf3a8281487c1f67b48
Reviewed-on: https://gerrit.libreoffice.org/25532
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2016-05-27 17:10:45 +00:00
Stephan Bergmann
a890e3189b SAL_FALLTRHOUGH in Windows-only code
Change-Id: If35da46c209746a86687e1c3f60f72f2f08aa681
2016-05-25 08:42:15 +02:00
Stephan Bergmann
81ad706b95 Replace comment with SAL_FALLTHROUGH
Change-Id: I9ccba0369453af3b4b3328b9fca94429369c6524
2016-05-12 11:20:14 +02:00
Stephan Bergmann
14cd5182c5 Replace fallthrough comments with new SAL_FALLTHROUGH macro
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough.  (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)

Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently.  (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.)  C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.

Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10 16:42:16 +02:00
tymyjan
1269415560 tdf#97499 Fixed containers parameters clearing #7
Change-Id: Ieb9ab0f9c011a24ba329cfb063e3d7733dd1afcb
Reviewed-on: https://gerrit.libreoffice.org/24440
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-28 07:26:58 +00:00
tymyjan
6dbcebab6d tdf#97499 Fixed containers parameters clearing #6
Change-Id: I89ad45eacfffd3783687b158a45f3eda0b95dece
Reviewed-on: https://gerrit.libreoffice.org/24433
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-28 07:26:39 +00:00
Stephan Bergmann
a68a285076 bridges/inc/bridges/cpp_uno/bridge.hxx appears unused
Change-Id: I2b938739ebf4a5b13414bfa8ba27e83dd02b971d
Reviewed-on: https://gerrit.libreoffice.org/24370
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-25 20:01:33 +00:00
Stephan Bergmann
8a09cd241c loplugin:salbool
Change-Id: I3a96fd12e6fa3a64bd1888373dfce0f8f621aad4
2016-04-22 09:30:16 +02:00
Noel Grandin
8762aa986d clang-tidy modernize-loop-convert in b*
Change-Id: I8ac6eb59e213eafa78e3dc4578738b53e8adef5b
2016-04-21 10:27:17 +02:00
Stephan Bergmann
9a978d62ad loplugin:salbool: Automatic rewrite of sal_False/True
Change-Id: Ideaafe1920c9e27de7ed9e9f4fe9fc7cb8c3b6aa
2016-04-20 17:25:36 +02:00
Noel Grandin
b8eb294651 loplugin:passstuffbyref in various
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-14 10:24:47 +02:00
Jochen Nitschke
8c2f2e1dd7 tdf#94306 replace boost::noncopyable in ..
.. accessibility, avmedia, basctl, basic and bridges
remove boost from module if not needed anymore

Change-Id: I6177f8276766a0a7df1703e81bf1b448912df6e2
Reviewed-on: https://gerrit.libreoffice.org/23744
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-04 06:54:36 +00:00
Stephan Bergmann
88754ea53d Avoid reserved identifiers
Change-Id: I0e353e3d892e1d01155dd7e48f8d24597604d3c4
2016-03-10 18:32:13 +01:00
Stephan Bergmann
2e73ae7a62 -Werror,-Wshadow
Change-Id: Ib20a02a846b745b65ffcf9ec1d45b39a6e0c50e4
2016-03-04 08:50:11 +01:00
Stephan Bergmann
1e161eb96e Use config_cxxabi.h to check for __*class_type_info
...as needed e.g. when building on Linux with clang -stdlib=libc++ against
libc++abi

Change-Id: I1f6f5ebcf5410c65453549ecea77581ccdaabc17
2016-02-26 08:57:09 +01:00
Stephan Bergmann
3d63d0c14b Adapt __cxxabiv1 for libc++abi
...where it has an additional nonstandard member, at least on Linux x86-64.  Not
sure whether

  #if defined _LIBCPPABI_VERSION

is the best way to distinguish libc++abi from other C++ runtimes, but

  #define _LIBCPPABI_VERSION 1002

is what it has in its cxxabi.h.

Change-Id: I9edbca27aa2bedbc5b2e996fd5ffcfc2e8eb42d9
2016-02-26 08:57:09 +01:00
Stephan Bergmann
0fef230f0f Declarations based on config_cxxabi.h should be unrelated to _LIBCPP_VERSION
Change-Id: I79049fefad8b626b5c58728b9c05c4952fb97f1a
2016-02-26 08:57:08 +01:00
Stephan Bergmann
069506bcb0 Use config_cxxabi.h to check for __cxa_eh_globals, __cxa_exception
Change-Id: I467341da4bccb3afb82518b444cd101b3cdaacc9
2016-02-26 08:57:08 +01:00
Stephan Bergmann
128deeae81 cxxabi.h is not specific to GCC
Change-Id: Icaf4d4d41a36ae469f826ac08ab641a554dff3c9
2016-02-26 08:57:07 +01:00
Stephan Bergmann
baad027bb7 Expect _Unwind_Exception to be defined in the compilers' unwind.h
Change-Id: Ie27018d21cf356ea5c6953958b466153f93f9a51
2016-02-26 08:57:07 +01:00