2154 Commits

Author SHA1 Message Date
Noel Grandin
0063cf2856 java: make fields final where possible
found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18 12:44:28 +02:00
Tor Lillqvist
d388ef0b3b Blind fix attempt: include <osl/diagnose.h>
Change-Id: Ic734b56852212d4cee352fc3669dbb16838be8ae
2014-11-17 17:50:56 +02:00
Matúš Kukan
d743004ac4 missing include
Change-Id: Iac01fc756a74cbaeebd1d9a01ddea74bbaf18f4b
2014-11-17 15:40:58 +01:00
Michael Stahl
8b50d6b176 bridges: get at least the x86 bridge to build
Change-Id: Idd2f223e0c83e0a6a19e70bd677058b6899bf766
2014-11-17 12:50:00 +01:00
Michael Stahl
6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Michael Stahl
b3e5b5941f bridges, vcl: turns out there is sal/alloca.h; replace #ifdefery
Change-Id: I2eda8dab51e66af7856b55f2d5f297620e07ccdb
2014-11-17 11:06:51 +01:00
Brij Mohan Lal Srivastava
d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14 09:20:38 +01:00
Andrea Gelmini
da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
Noel Grandin
bb437029c1 java: convert fields to local variables where possible
found by PMD

Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542
Reviewed-on: https://gerrit.libreoffice.org/12376
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:03:29 +00:00
Noel Grandin
b95dcb97de java: last statement in finalize() method should be call to super.finalize()
Change-Id: I1785c6cef1fe7c1990207a76c263cff388cbb7e1
Reviewed-on: https://gerrit.libreoffice.org/12375
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 08:02:18 +00:00
Stephan Bergmann
269b0b4081 Avoid -fsanitize=signed-integer-overflow
Change-Id: Icec67e6eb57605102cabf494d3e2bb6249d785c7
2014-11-11 08:28:52 +01:00
Stephan Bergmann
fc0d57b7af Revert "use the new OUString::fromUtf8 method"
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498,
not all places that use e.g. OStringToOUString to convert potential UTF-8
are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and
some places like e.g. in codemaker are happy with the best-effort effect
of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06 17:24:13 +01:00
Noel Grandin
05050cdb23 use the new OUString::fromUtf8 method
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-06 13:51:10 +02:00
Caolán McNamara
12bcfec04f markup with event type not checker type
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05 14:58:00 +00:00
Caolán McNamara
07f9a7dc83 some coverity false positive markup efforts
Change-Id: Id17c3426cb4a5913881201a0bf2f569ca5002303
2014-11-03 20:44:57 +00:00
Noel Grandin
eb8530cc90 fix sparc build
after my commit e7bc3cab019fbf040f9fb8b53ae2cf3f977d200b
"remove boilerplate in UNO Exception constructor calls"

Change-Id: Iccf79e3c41c860e15078b791fed551a9526aa453
2014-11-03 11:59:36 +02:00
Andrea Gelmini
0c0e3e7539 Fixed typos. No automatic tools (sed, and so on).
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f
Reviewed-on: https://gerrit.libreoffice.org/12150
Reviewed-by: Bryan Quigley <gquigs@gmail.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30 17:16:02 +00:00
Caolán McNamara
dff10fc454 coverity#704134 silence Resource leak in object
Change-Id: I7c2400e9f340562380423eb3300bbcf3eb4c4871
2014-10-30 14:34:28 +00:00
Noel Grandin
0371a63365 remove unnecessary 'using namespace rtl' declarations
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29 11:28:54 +00:00
Noel Grandin
25d70197a4 java: when overriding finalize(), keep it protected
Change-Id: I44456b3244f2190e33a7333c13492eea52bb06e4
2014-10-16 12:27:11 +02:00
Noel Grandin
a760e45df6 fix use of RuntimeException constructor
Change-Id: Ia8fe44ea365183a8dec8027812b4877be080070d
2014-10-14 15:26:49 +02:00
Caolán McNamara
c539459403 coverity#706248 Uncaught exception
because get_stack_trace uses rtl_mem::allocate and that throws on a (unlikely)
memory allocation failure

Change-Id: Ic2d0e6ec76eab5cf73025fa4d3199c29eb5b2982
2014-10-08 20:45:11 +01:00
Michael Stahl
3b59dbbffd remove HAVE_GCC_PRAGMA_DIAGNOSTIC_SCOPE check and macro
This is supported in GCC 4.6.0 already:
https://gcc.gnu.org/onlinedocs/gcc-4.6.0/gcc/Diagnostic-Pragmas.html

Change-Id: I2f67e588eea3a323a2e9c81e39e56ab2e715a817
2014-10-02 20:00:18 +02:00
Michael Stahl
86cd29772e remove HAVE_GCC_PRAGMA_DIAGNOSTIC_MODIFY check and macro
This has been supported by GCC and clang for a very long time.

Change-Id: I410a2b39004c932003f8cbefe935aedb109b1163
2014-10-02 20:00:17 +02:00
Tor Lillqvist
f49ff3f576 We always build 64-bit OS X code
Change-Id: I527c66c7be1372ab5ddf86625667d2f315e9b5d3
2014-10-01 17:28:01 +03:00
Tor Lillqvist
ec14701234 We require OS X SDK 10.8 or newer now
Change-Id: I68eee76c8710c89af8e3c1e1006345f908923ece
2014-10-01 17:27:59 +03:00
Stephan Bergmann
67a9ae4dd8 Improve debug output
Change-Id: Iba0c35a5bc07ac7b67186c3eeae1a2c926a6bc69
2014-09-29 23:18:26 +02:00
Stephan Bergmann
2311c8d677 Precise, platform-specific Class-Path path for NativeLibraryLoader use
Change-Id: I4aecc887fc4654618444616ef83ff71266a2f93a
2014-09-29 21:57:41 +02:00
Stephan Bergmann
22730b9f48 The unused source_arena arg to alloc/freeExec can just be null
Change-Id: I16f8a9e8f421215fe5d392ba3f1f304618d70174
2014-09-26 10:19:58 +02:00
Noel Grandin
83636d2c09 java: when rethrowing exceptions, store the original cause
so that we get a nice complete stacktrace when it hits the final
handler

Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-09-25 13:47:25 +02:00
Stephan Bergmann
9703cc63ce Remove o3tl/heap_ptr.hxx, use std::unique_ptr instead
Change-Id: Iac70c9be13892a36bfb5975f62e5345b88d4f144
2014-09-24 14:54:51 +02:00
Tor Lillqvist
e29862bcc5 PPC Mac support can go away now (again)
Change-Id: Ie1b2ab13eda584c48aaa0a4a0941f1be451697c1
2014-09-23 09:12:21 +03:00
Robert Antoni Buj i Gelonch
ec2d5ac371 jni_uno: string comparison
Change-Id: If093afb43f6ad8d4fcf6c0ec426eb48a6061ef3e
Reviewed-on: https://gerrit.libreoffice.org/11470
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-17 06:08:51 +00:00
Norbert Thiebaud
4fa8282816 mac: clean-up obsolete conditional code based on old SDK
Change-Id: Ie2d476780a48b5815961598e214343d5def962c1
2014-09-13 20:21:07 +02:00
Stephan Bergmann
8d12e4ec8b No -fstack-protect-strong for gcc3_linux_aarch64/cpp2uno.cxx vtableSlotCall
Change-Id: I52efda594d87c37c2d38c61b54f1eebcc76cdfce
2014-09-04 15:26:58 +02:00
Tor Lillqvist
5c004922b2 Start of support for Android on AArch64
The build does not get far before it runs into trouble in the GNU libstdc++
headers, though:

android-ndk-r10/sources/cxx-stl/gnu-libstdc++/4.9/libs/x86/include/bits/opt_random.h:33:23:
fatal error: x86intrin.h: No such file or directory

Change-Id: I9d459c64980091ba8bf5b3d631d47342625f6be9
2014-08-30 01:03:33 +03:00
Julien Nabet
35e260c4a3 cppcheck: va_end_missing
Change-Id: I316830b56aba7874cff4a164925520a7b6c6131d
2014-08-29 21:38:58 +02:00
Stephan Bergmann
235fa0334e Linux AArch64 port
Change-Id: I37044a37348b203944a8eb9d2204e619055f069d
2014-08-29 17:17:42 +02:00
Caolán McNamara
7da6716e98 sigh, simply forgot to include the endian header
so the ppc64 bridge was broken

Change-Id: Ib60274ed25531f500bcd97f5ea9b04091ce01825
2014-08-29 11:30:15 +01:00
David Tardon
ef8b94ab0e cast arg to the right type
According to desc., typelib_TypeDescription can be safely used where
typelib_TypeDescriptionReference is expected.

Change-Id: Ibc3effd7e2894ba6ff738503e747f5157c146454
2014-08-28 16:19:17 +02:00
David Tardon
b38de1f8f3 fix variable name
Change-Id: I170f0390f8f510591d444f44c20434b15077e687
2014-08-28 13:44:20 +02:00
Caolán McNamara
af73a28e85 if _CALL_ELF -> if defined(_CALL_ELF) && _CALL_ELF == 2
Change-Id: I34e9a98586b795a3fa31ae775aee7898b36e65d4
2014-08-22 21:09:55 +01:00
Caolán McNamara
b3213401a2 pasted in reverse
Change-Id: I6a3f8c9bffd2dbac90c73e472f99dd97b9977127
2014-08-22 15:16:10 +01:00
Caolán McNamara
6ab1951ea2 Resolves: rhbz#1125588 ppc64le passes testtools
*bzzt*, <lightning arcs, faint smell of ozone>, it's alive!

Change-Id: I0b42f4e2603e6d76200d63ab2e26bbb856ae1173
2014-08-22 15:08:56 +01:00
Caolán McNamara
ee6fcdd18b Related: rhbz#1125588 ppc64le fix simple struct returning
Change-Id: I1e253922fdb606648eff9865f1125a24e35b0d9a
2014-08-22 13:53:19 +01:00
Caolán McNamara
970ad502e3 Related: rhbz#1125588 ppc64le has new struct passing rules
http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01145.html
http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01147.html

now we just fail instead of crash

Change-Id: I329c676337885bcf4fdfdcdb5912d75424862126
2014-08-22 13:34:50 +01:00
Caolán McNamara
6396e18f4d Related: rhbz#1125588 force existence of argument save area
ELFv2 ABI on ppc64 optimises stack allocation
(http://gcc.gnu.org/ml/gcc-patches/2013-11/msg01149.html
so we're getting no argument save area

This now appears to pass the simple cases and onwards
to the tricky ones

Change-Id: Ie56d148ebea7fcfc023cb7183bc97f09186e66b4
2014-08-22 12:10:42 +01:00
Caolán McNamara
d8fcd8ca9a Related: rhbz#1125588 get to the end of cpp_mediate on ppc64le
Change-Id: Id3928ef5ac68ea13a7aa8723bc8b068ecf8075a0
2014-08-21 16:34:39 +01:00
Caolán McNamara
4c5bbbf059 Related: rhbz#1125588 get as far as privateSnippetExecutor
Change-Id: Icc386083ecd9faefbedebbb9d2496a4eddfa0b2b
2014-08-21 15:45:59 +01:00
Caolán McNamara
170109708e Related: rhbz#1125588 first steps for ppc64le
almost certainly won't get us too far, but a start

Change-Id: Ic20b97a97b6d506c32322173bd8332d15c3a4555
2014-08-21 08:54:16 +01:00