6729 Commits

Author SHA1 Message Date
Caolán McNamara
8211548e7d svx: load BitmapEx resources instead of Image ones
Change-Id: Id23523170f757361f3fc3d8a18b6db827f45d109
2017-01-19 15:13:30 +00:00
Noel Grandin
afaa10da25 make SfxItemSet with SAL_WARN_UNUSED
Change-Id: Ia74ca329d8438f614169031acfbe0406faf7c281
Reviewed-on: https://gerrit.libreoffice.org/33268
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-19 05:41:29 +00:00
Jochen Nitschke
e87071ac57 replace boost::checked_deleter with std::default_delete
and remove all traces of boost/checked_delete.hpp

Change-Id: I4486d0e07a7197d75f8739c8c6d79670163eaab2
Reviewed-on: https://gerrit.libreoffice.org/33182
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-17 20:24:17 +00:00
Jan-Marek Glogowski
fdc612619c Refactor Scheduler to add Task class
Moves all the "task-specific" stuff into a Task class and just
keeps the "real" static Scheduler functions in the original
Scheduler class.

Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2017-01-17 16:08:47 +01:00
Jan-Marek Glogowski
9e51007039 tdf#97087 GDB pretty print the Scheduler task list
In addition to the GDB pretty printer, this annotates a lot more
Timers and Idles.

Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c
2017-01-17 16:08:46 +01:00
Caolán McNamara
74b92741b8 b*, c*: load BitmapEx resources instead of Image ones
Change-Id: Idbf99de17e5349712ef7c3da3ce8bb8b5f879ef7
2017-01-16 11:45:35 +00:00
Noel Grandin
570d8dab6d new loplugin: useuniqueptr: chart2
Change-Id: Ic029ed28fd6de8cf4ee204585c1c6e0c8a4b67ff
Reviewed-on: https://gerrit.libreoffice.org/32960
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-16 06:10:10 +00:00
Khaled Hosny
b885db5dbd loplugin:nullptr
Change-Id: Iaf69f87564ff0f9f8aab6fafb833714426c8bc30
2017-01-10 16:27:47 +02:00
Noel Grandin
b022985505 loplugin:unusedfields
Change-Id: I9611511cb3480734dea3c3cbaf0d659071366ad1
Reviewed-on: https://gerrit.libreoffice.org/32873
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-10 06:28:22 +00:00
Tamás Zolnai
5af78ee8df This lock seems useless
m_pCurrentMainType->commitToModel creates the same lock.

Change-Id: Iaecf6b3392ce7b1371623f962b0fdc58f8ddaa07
2017-01-05 04:22:05 +01:00
Tamás Zolnai
a3cf075880 I miss empty lines from between these function definitions
Change-Id: Icec3a948a92bf54bfc442b34cf806e053a9096f3
2017-01-05 02:17:51 +01:00
Tamás Zolnai
e885c4429a m_bDoLiveUpdate is always true
Change-Id: I169027a02bd4e0e5c2e0011e6aca4d6063547ca0
2017-01-05 02:02:04 +01:00
Tamás Zolnai
1f9fcc1413 Remove useless explicit bool conversion
Change-Id: I81caa89fe2ebfb88ce4eb36b8edb9460e9aca9c8
2017-01-05 01:22:57 +01:00
Jochen Nitschke
a29bd2dabb cleanup tailing backslashes
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2
Reviewed-on: https://gerrit.libreoffice.org/32491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-30 18:48:24 +00:00
Noel Grandin
833e6ca9d2 use std::vector instead of naked array in SfxItemPool
Change-Id: I2d4ac010ff5818e673567cee05700872588918e4
Reviewed-on: https://gerrit.libreoffice.org/32384
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-12-26 18:35:59 +00:00
Stephan Bergmann
9bb574590e ODR violation (base class must be the same across compilation units)
Change-Id: I6e386574d0366ef75f24811266134d93b28dc3a5
2016-12-21 14:55:54 +01:00
Stephan Bergmann
cc7e9b5dbe No apparent reason for an unnamed namespace in an include file here
Change-Id: I56f21c94086b34f766e3f2745f5a1291af676984
2016-12-21 14:50:58 +01:00
Noel Grandin
735a002507 convert EnumContext::Context to scoped enum
Change-Id: I16ec63beb801073e5d604d852892c2fd6e8d8fc3
Reviewed-on: https://gerrit.libreoffice.org/32272
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-21 10:34:13 +00:00
Khaled Hosny
8960d05164 Recreate the reference files, again
After the rounding change in 9eb4b14ffa57cd7bbdf0fc43096f5f1e65c8e388.

Change-Id: I0836ba34f23d256075611e9fae1658cf4d737a89
Reviewed-on: https://gerrit.libreoffice.org/32242
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-12-21 09:40:08 +00:00
bansan85
a631e0fe94 Add move column right and move row up in DataTable
Change-Id: Ib224a99636dfbb4451aa26263573af2f3d31b84a
Reviewed-on: https://gerrit.libreoffice.org/32265
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-12-21 08:25:12 +00:00
Markus Mohrhard
4dc5e08671 recreate the reference files
Change-Id: I24c5943cbb371717e3354fe292800abd1536129e
Reviewed-on: https://gerrit.libreoffice.org/32139
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-18 19:45:25 +00:00
Markus Mohrhard
9340516671 add missing component file
Change-Id: Ica945030f955cb192cee44a0f97f4f9d881bf9a0
Reviewed-on: https://gerrit.libreoffice.org/32138
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-18 18:49:24 +00:00
Tor Lillqvist
db9aec4520 -Werror,-Wunused-function
Change-Id: Ia6c8c807c90931da4a5f3cab79d178f88bce290e
2016-12-18 11:01:56 +02:00
Stephan Bergmann
83d2c5180d Adapt to no-longer explicit OUStringLiteral ctor
...from previous commit

Change-Id: I062b7cd212c17e7eb5274476e6859228d0477c7f
Reviewed-on: https://gerrit.libreoffice.org/32098
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-17 16:12:02 +00:00
Caolán McNamara
e3077960cd fix !HAVE_FEATURE_UI build
Change-Id: I5df340811b98c87f8b64fbaca469e2cd4535b81f
2016-12-17 15:59:23 +00:00
Caolán McNamara
48b561c770 post glew->epoxy, we don't need to link to win openg32 and mac OpenGL
Change-Id: Iadc373961dcca788b1174ee71cb386979ce064ed
Reviewed-on: https://gerrit.libreoffice.org/31954
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13 21:01:48 +00:00
Tor Lillqvist
092e361031 Fix fallout from 60b1c95cc47831246f097ee13dda8bcd71c57eb4
Change-Id: I77722619a249616ab59af0eeaeb075e89040c715
2016-12-13 18:31:30 +02:00
Noel Grandin
872cf486c5 Revert "verify SolarMutex when ref-counting VclPtr" series
This reverts the following commits:

    commit 722f4e1d86710f2facd37d7e040df9e1fd585e26
    tdf#104573 - Assertion failed: SolarMutex not locked

    commit f04ec99f5e6a543b8191ced61db4710c3c0de356
    tdf#104573 - Assertion failed: SolarMutex not locked

    commit 71b1e3ff6374c23e65200d3bcafca387d29af04f
    tdf#104573 - Assertion failed: SolarMutex not locked when trying

    commit e794ce1eef6730e5a46d5fb0aa6db2895ede85e7
    verify that we hold the SolarMutex when ref-counting VclPtr

IRC discussion:
<noelgrandin> sberg, maybe I should revert this whole "VclPtr assert" series, I don't have mental bandwidth to sort this out properly now
<sberg> noelgrandin, what I fear is that you'll end up adding lots of SolarMutex locks to small places, where the proper fix would be to add it further out; and once such a dreaded recursive SolarMutex lock is in place (but needlessly so, once the proper fix is done), it's hard to clean that up again
<noelgrandin> sberg, yeah, in that case I'll just remove all of this, leave it for another day

Change-Id: Ie4f84b72b79a1b7e80164b5c7693af398c2c569a
Reviewed-on: https://gerrit.libreoffice.org/31946
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13 13:04:34 +00:00
Caolán McNamara
482d7ce61b change from glew to epoxy
because that works under wayland out of the box and gtk3 uses it already

Change-Id: Iefaac31e325534a81a5389f752804af917c1baef
Reviewed-on: https://gerrit.libreoffice.org/31213
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13 11:33:18 +00:00
Noel Grandin
c3586b684c OSL_TRACE->SAL in chart2..oox
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2
Reviewed-on: https://gerrit.libreoffice.org/31907
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13 06:12:00 +00:00
Tor Lillqvist
345800501c loplugin:staticmethods
Change-Id: Ia470ed848c5c27de1b0ae3fa89a59f6cb2ae38fe
2016-12-12 15:52:53 +02:00
Tor Lillqvist
45566e7cc9 loplugin:unreffun and loplugin:externandnotdefined
Change-Id: I69f11aa5dd81834aa916a66437d8c091cdf245f3
2016-12-12 15:52:53 +02:00
Julien Nabet
ae18926c2f AccessibleEventNotifier AccessibleBase (chart2)
See https://cgit.freedesktop.org/libreoffice/core/commit/?id=0c876d497dd3320cbc06cf21b7b14ab859755bac
This one fixes tdf#104551

Change-Id: Idd173bcb85655ec1b210fa00510fbabba0f5d867
Reviewed-on: https://gerrit.libreoffice.org/31844
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-11 05:02:14 +00:00
Julien Nabet
1fce5b024e tdf#104534: Retrieve list of patterns
using same way as gradients, bitmap, etc.

Change-Id: I49788d5af163aa6f06a12c87ee08e6599fc940c8
Reviewed-on: https://gerrit.libreoffice.org/31833
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-10 15:15:08 +00:00
Noel Grandin
e794ce1eef verify that we hold the SolarMutex when ref-counting VclPtr
Change-Id: If0c5a8c99f0f853c9ecad0f1a4a7299d69805b34
Reviewed-on: https://gerrit.libreoffice.org/31755
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08 17:26:41 +00:00
Tor Lillqvist
dc199952d3 Try to fix a --disable-gui problem
Change-Id: I7fa187b0dea7f058f7486fe2c2e16693f21c063c
2016-12-08 14:21:20 +02:00
Noel Grandin
2d48f5fc0a convert VCLEVENT constants to scoped enum
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba
Reviewed-on: https://gerrit.libreoffice.org/31675
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07 07:10:39 +00:00
Stephan Bergmann
9b8fb82150 loplugin:unnecessaryoverride
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-06 10:20:01 +01:00
Jean-Tiare Le Bigot
18b3138a7a tdf#102621: import empty chart cells as NaN instead of 0
Change-Id: I574c3f719e52bc2244597532783130564621a891
Reviewed-on: https://gerrit.libreoffice.org/31303
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-01 17:32:03 +00:00
Khaled Hosny
74314b11a4 Drop a bunch of font metrics flags
These flags mean nothing these days, there are either always true or
always false, since we no longer support bitmap or Type 1 fonts.

Change-Id: Ie14ca480225a6346d868a44e58e7666c3a06931d
Reviewed-on: https://gerrit.libreoffice.org/31346
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-11-29 13:38:48 +00:00
Noel Grandin
e6ffb539ee loplugin:vclwidgets check for assigning from VclPt<T> to T*
Inspired by a recent bug report where we were assigning the result
of VclPtr<T>::Create to a raw pointer.

As a consequence, we also need to change various methods that were
returning newly created Window subclasses via raw pointer, to
instead return those via VclPtr

Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b
Reviewed-on: https://gerrit.libreoffice.org/31318
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-29 06:45:42 +00:00
Michael Stahl
6bb20609a2 vcl: rename Window::Notify to EventNotify
There is annoying overloading between Window::Notify and
SfxListener::Notify, and the Window one has apparently fewer
implementations, so rename that and remove lots of disambiguating
"using Notify" in multiply inheriting classes.

Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49
2016-11-24 22:56:34 +01:00
Stephan Bergmann
705af606f7 loplugin:unnecessaryoverride (dtors) in chart2
Change-Id: I013fd81467b353262e8de554a06a0b24e4deca6d
2016-11-23 18:37:35 +01:00
David Tardon
3ea0ecdcf4 add missing dep
Change-Id: I7ebf3d83833424a089a6befb1fe038fdd85ead35
2016-11-21 09:44:39 +01:00
David Tardon
bbb9264610 add missing deps on ui files
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-21 09:44:39 +01:00
Norbert Thiebaud
d8a8ed04b1 gbuild allow unitest to run once per lang in WITH_LANG_LIST
this is motivated by the new screenshot feature
the initial proposed solution involved running make screenshot once per lang
which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big
windows slavebot.

with this patch, one can run make screenshot just once and get all the screenshot
the elapsed time is 36 inutes on the same box/same config a 10x improvement.

Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939
Reviewed-on: https://gerrit.libreoffice.org/30970
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-20 13:34:40 +00:00
Noel Grandin
fde0892f2d loplugin:unusedmethods
Change-Id: I567c672a0606ac11c0f269fcf5cc3906684e23f9
Reviewed-on: https://gerrit.libreoffice.org/30950
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18 11:00:59 +00:00
Noel Grandin
bb674aa550 loplugin:unusedfields
Change-Id: Id2dbbf384637223db3d334d95332251832918003
Reviewed-on: https://gerrit.libreoffice.org/30927
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-17 13:10:42 +00:00
Samuel Mehrbrodt
ec4e48c750 Fix typos
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672
Reviewed-on: https://gerrit.libreoffice.org/30872
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15 14:51:34 +00:00
Noel Grandin
3bf5bc2e19 Revert some chart2 shader-affecting changes
from

    commit 8d4a306eb04742f499ab693e7f8ebd3ae3c01415
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Tue Nov 15 11:26:59 2016 +0200
    loplugin:unusedfields

and

    commit c79b7fd8d4e6e029cf8e6bfb2c7e10b52a4d5781
    Author: Noel Grandin <noel@peralex.com>
    Date: 2015-11-20 10:41:00 (GMT)
    loplugin:unusedfields in chart2

Change-Id: I6b61aa9c6abb1d51e96d5eb6c623d86fd6fd5b82
2016-11-15 15:47:25 +02:00